Skip to content

fix: Install Zig for LSP builds - #13158

Merged
anthonyshew merged 1 commit into
mainfrom
shew/fix-vscode-builds
Jun 29, 2026
Merged

anthonyshew merged 1 commit into
mainfrom
shew/fix-vscode-builds

Conversation

@anthonyshew

Copy link
Copy Markdown
Contributor

Why

VS Code extension release builds fail because turborepo-lsp now links turborepo-ghostty-sys, whose build script requires zig. The main release Rust build already installs Zig, but the LSP workflow did not, so every VS Code extension Rust matrix job failed before packaging.

What

Install the shared Zig toolchain setup in the LSP Rust build matrix before cargo build. Update the repo workflow notes so future release workflow changes preserve this requirement.

How

Validated the workflow YAML parses and confirmed the failed release logs show turborepo-ghostty-sys panicking on missing zig across macOS and Windows. Pre-push hooks ran: lint-staged, turbo run format check:toml, and cargo fmt --check.

@anthonyshew
anthonyshew requested a review from a team as a code owner June 29, 2026 20:58
@anthonyshew
anthonyshew requested review from tknickman and removed request for a team June 29, 2026 20:58
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
examples-basic-web Ready Ready Preview, Comment, Open in v0 Jun 29, 2026 8:58pm
examples-designsystem-docs Ready Ready Preview, Comment, Open in v0 Jun 29, 2026 8:58pm
examples-gatsby-web Ready Ready Preview, Comment, Open in v0 Jun 29, 2026 8:58pm
examples-kitchensink-blog Ready Ready Preview, Comment, Open in v0 Jun 29, 2026 8:58pm
examples-nonmonorepo Ready Ready Preview, Comment, Open in v0 Jun 29, 2026 8:58pm
examples-svelte-web Ready Ready Preview, Comment, Open in v0 Jun 29, 2026 8:58pm
examples-tailwind-web Ready Ready Preview, Comment, Open in v0 Jun 29, 2026 8:58pm
examples-vite-web Ready Ready Preview, Comment, Open in v0 Jun 29, 2026 8:58pm
turbo-site Ready Ready Preview, Comment, Open in v0 Jun 29, 2026 8:58pm

@anthonyshew
anthonyshew merged commit c1bc71f into main Jun 29, 2026
18 of 19 checks passed
@anthonyshew
anthonyshew deleted the shew/fix-vscode-builds branch June 29, 2026 20:58
anthonyshew pushed a commit that referenced this pull request Jun 30, 2026
## Release v2.10.2-canary.1

> [!CAUTION]
> Versioned docs aliasing FAILED. [View
logs](https://github.com/vercel/turborepo/actions/runs/28455389159)

### Changes

- feat: Support devEngines packageManager in workspaces (#13150)
(`9d94ae5`)
- release(turborepo): 2.10.1-canary.3 (#13149) (`0d32225`)
- feat: Update add package manager codemod (#13151) (`27ca962`)
- feat: Update workspace package manager declarations (#13154)
(`f878719`)
- release(turborepo): 2.10.1 (#13156) (`8c3bbe4`)
- docs: Prefer devEngines packageManager (#13155) (`6598f7c`)
- fix: Install Zig for LSP builds (#13158) (`c1bc71f`)
- ci: Pin macOS Rust builds to macOS 15 (#13167) (`16fe0a4`)
- feat: Recognize nub as a package manager (#13120) (`782b168`)
- fix: Preserve 3-level nested Bun lockfile entries during prune
(#13168) (`799fa5a`)
- fix: Avoid following nested symlinked cache outputs (#13166)
(`502ceaf`)
- feat: Add nub package manager support to JavaScript packages (#13169)
(`53cddc8`)
- fix: Link ghostty-vt statically on Windows MSVC (#13171) (`e950d71`)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
anthonyshew pushed a commit that referenced this pull request Jun 30, 2026
## Release v2.10.2

> [!CAUTION]
> Versioned docs aliasing FAILED. [View
logs](https://github.com/vercel/turborepo/actions/runs/28458202079)

### Changes

- release(turborepo): 2.10.1 (#13156) (`8c3bbe4`)
- docs: Prefer devEngines packageManager (#13155) (`6598f7c`)
- fix: Install Zig for LSP builds (#13158) (`c1bc71f`)
- ci: Pin macOS Rust builds to macOS 15 (#13167) (`16fe0a4`)
- feat: Recognize nub as a package manager (#13120) (`782b168`)
- fix: Preserve 3-level nested Bun lockfile entries during prune
(#13168) (`799fa5a`)
- fix: Avoid following nested symlinked cache outputs (#13166)
(`502ceaf`)
- feat: Add nub package manager support to JavaScript packages (#13169)
(`53cddc8`)
- fix: Link ghostty-vt statically on Windows MSVC (#13171) (`e950d71`)
- release(turborepo): 2.10.2-canary.1 (#13172) (`c597bb5`)
- feat: Add nub to create-turbo options (#13173) (`82b1cf1`)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This branch had an error being deployed

1 failed deployment
Preview – turborepo-eve-agent — 92064835 Deployed Jun 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant