Disable worker_threads by default for firebase compatibility #9199

ctavan · 2019-10-25T14:46:12Z

Multiple worker threads can cause problems when certain dependencies are being used, see e.g. #7894

This patch allows disabling of worker threads by setting config.experimental.cpus = 1.

The benefit of spawning 1 worker thread, if there is any at all, should very limited anyways, so the workload can just as well be processed in the main thread.

Fixes: #7894

ijjk · 2019-10-25T14:52:28Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	15.7s	15.5s	-182ms
nodeModulesSize	48.7 MB	48.7 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..4a7b46563.js	14.9 kB	14.9 kB	✓
16b1a7225520..6563.js gzip	5.38 kB	5.38 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..d2.module.js	10.8 kB	10.8 kB	✓
16b1a7225520..dule.js gzip	4.05 kB	4.05 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..11.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.68 kB	8.68 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.51 kB	1.51 kB	✓
hooks.js gzip	789 B	789 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.15 kB	8.15 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	24.7 kB	24.7 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.54 kB	1.54 kB	✓
_app.module.js gzip	756 B	756 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.28 kB	4.28 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	794 B	794 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.69 kB	3.69 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	23.3 kB	23.3 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	17.7s	16.8s	-914ms
nodeModulesSize	48.7 MB	48.7 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..4a7b46563.js	14.9 kB	14.9 kB	✓
16b1a7225520..6563.js gzip	5.38 kB	5.38 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..d2.module.js	10.8 kB	10.8 kB	✓
16b1a7225520..dule.js gzip	4.05 kB	4.05 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..11.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.68 kB	8.68 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.51 kB	1.51 kB	✓
hooks.js gzip	789 B	789 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.15 kB	8.15 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	24.7 kB	24.7 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.54 kB	1.54 kB	✓
_app.module.js gzip	756 B	756 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.28 kB	4.28 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	794 B	794 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.69 kB	3.69 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	23.3 kB	23.3 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_error.js	234 kB	234 kB	✓
_error.js gzip	62.8 kB	62.8 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	235 kB	235 kB	✓
index.js gzip	62.9 kB	62.9 kB	✓
link.js	267 kB	267 kB	✓
link.js gzip	71.9 kB	71.9 kB	✓
routerDirect.js	260 kB	260 kB	✓
routerDirect.js gzip	69.9 kB	69.9 kB	✓
withRouter.js	260 kB	260 kB	✓
withRouter.js gzip	69.8 kB	69.8 kB	✓
Overall change	1.26 MB	1.26 MB	✓

Commit: 0470c9e

ctavan · 2019-10-25T14:55:03Z

~~Looks like build time was reduced by skipping worker threads when only 1 CPU is available 😲~~

Edit: The changes in duration rather seem to be within the standard fluctuations…

ijjk · 2019-10-25T14:58:36Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	14.9s	15.5s	⚠️ +577ms
nodeModulesSize	48.7 MB	48.7 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..4a7b46563.js	14.9 kB	14.9 kB	✓
16b1a7225520..6563.js gzip	5.38 kB	5.38 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..d2.module.js	10.8 kB	10.8 kB	✓
16b1a7225520..dule.js gzip	4.05 kB	4.05 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..11.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.68 kB	8.68 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.51 kB	1.51 kB	✓
hooks.js gzip	789 B	789 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.15 kB	8.15 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	24.7 kB	24.7 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.54 kB	1.54 kB	✓
_app.module.js gzip	756 B	756 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.28 kB	4.28 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	794 B	794 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.69 kB	3.69 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	23.3 kB	23.3 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	15.3s	14.8s	-489ms
nodeModulesSize	48.7 MB	48.7 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..4a7b46563.js	14.9 kB	14.9 kB	✓
16b1a7225520..6563.js gzip	5.38 kB	5.38 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..d2.module.js	10.8 kB	10.8 kB	✓
16b1a7225520..dule.js gzip	4.05 kB	4.05 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..11.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.68 kB	8.68 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.51 kB	1.51 kB	✓
hooks.js gzip	789 B	789 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.15 kB	8.15 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	24.7 kB	24.7 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.54 kB	1.54 kB	✓
_app.module.js gzip	756 B	756 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.28 kB	4.28 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	794 B	794 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.69 kB	3.69 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	23.3 kB	23.3 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_error.js	234 kB	234 kB	✓
_error.js gzip	62.8 kB	62.8 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	235 kB	235 kB	✓
index.js gzip	62.9 kB	62.9 kB	✓
link.js	267 kB	267 kB	✓
link.js gzip	71.9 kB	71.9 kB	✓
routerDirect.js	260 kB	260 kB	✓
routerDirect.js gzip	69.9 kB	69.9 kB	✓
withRouter.js	260 kB	260 kB	✓
withRouter.js gzip	69.8 kB	69.8 kB	✓
Overall change	1.26 MB	1.26 MB	✓

Commit: 03a6610

ijjk

Hi, can you add an integration test for this relating to #7894?

ctavan · 2019-10-28T16:23:40Z

Sure will try. Any pointer to a similar test that I could use as a template?

Currently, there is no way of specifying the number of worker threads of `next export` when run as part of `next build`. I suggest a sane default should be to just use the same amount of workers that were used during the build process which currently seems to be configured through `config.experimental.cpus`. This setting is already respected in the two other places where jest-workers are in use: The TerserPlugin and the staticCheckWorkers in `next build`.

Multiple worker threads can cause problems when certain dependencies are being used, see e.g. vercel#7894 This patch allows disabling of worker threads by setting `config.experimental.cpus = 1`. The benefit of spawning 1 worker thread, if there is any at all, should very limited anyways, so the workload can just as well be processed in the main thread.

ctavan · 2019-10-28T19:33:41Z

@ijjk I think I figured it out and added a corresponding integration test.

I verified that the test covers #7894 by temporarily reverting the Only enable worker threads if there is more than 1 worker commit and runnning the tests:

yarn testonly --testPathPattern "build-firebase-only-sequentially"

After restoring that commit it passes:

I also rebased along the way…

ijjk · 2019-10-28T19:41:40Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	17s	16.7s	-354ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	17.1s	17.2s	⚠️ +38ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	✓
link.js	274 kB	274 kB	✓
link.js gzip	73.4 kB	73.4 kB	✓
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	✓
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	✓
Overall change	1.29 MB	1.29 MB	✓

Commit: 684c8ff

ijjk · 2019-10-28T19:59:50Z

Awesome thanks for the test case! Instead of disabling worker_threads based on the number of cpus it looks like this is a valid case for an extra config since we don't want to slow down builds to avoid this error which is related to worker_threads.

I just pushed a change renaming the suite and adding a workerThreads option that allows opting-in to them without lowering parallelization since we can still leverage concurrency without causing the error by only disabling worker_threads

examples/with-firebase-authentication/next.config.js

ijjk · 2019-10-28T20:07:44Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	17.6s	17.3s	-227ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +252 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	18s	18.1s	⚠️ +65ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +252 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	✓
link.js	274 kB	274 kB	✓
link.js gzip	73.4 kB	73.4 kB	✓
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	✓
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	✓
Overall change	1.29 MB	1.29 MB	✓

Commit: 6d30574

ctavan · 2019-10-28T20:12:56Z

Sounds reasonable!

Are you sure that the workerThreads config is not needed in the terser plugin?

ijjk · 2019-10-28T20:15:25Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	15s	14.7s	-217ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +254 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	15.3s	15.8s	⚠️ +583ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +254 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	✓
link.js	274 kB	274 kB	✓
link.js gzip	73.4 kB	73.4 kB	✓
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	✓
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	✓
Overall change	1.29 MB	1.29 MB	✓

Commit: d0979f3

stale

Timer · 2019-10-28T20:19:38Z

@ctavan

Are you sure that the workerThreads config is not needed in the terser plugin?

Yup! Export/Prerender is actually evaluating the code, which results in this bug. Terser is just parsing it as a string into an AST (and back out).

…van/next.js into improve-worker-count-configurability

ctavan · 2019-10-28T20:23:10Z

@Timer thanks for the explanation. I did indeed not dig into the code deep enough, just searched for worker thread usage...

Thanks for tidying up my mess 😉

TerserPlugin for consistency

ijjk · 2019-10-28T20:27:43Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	16.2s	16.1s	-126ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +254 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	16.9s	16.7s	-250ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +254 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	✓
link.js	274 kB	274 kB	✓
link.js gzip	73.4 kB	73.4 kB	✓
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	✓
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	✓
Overall change	1.29 MB	1.29 MB	✓

Commit: d854702

ijjk · 2019-10-28T20:31:57Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	16.3s	16.2s	-98ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +646 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	16.7s	16.6s	-78ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +646 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	✓
link.js	274 kB	274 kB	✓
link.js gzip	73.4 kB	73.4 kB	✓
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	✓
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	✓
Overall change	1.29 MB	1.29 MB	✓

Commit: efc83a2

ijjk · 2019-10-28T20:38:05Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	15.7s	15.4s	-312ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +680 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	16.5s	15.7s	-790ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +680 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	✓
link.js	274 kB	274 kB	✓
link.js gzip	73.4 kB	73.4 kB	✓
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	✓
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	✓
Overall change	1.29 MB	1.29 MB	✓

Commit: 95747e1

ijjk · 2019-10-28T23:55:52Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	14.1s	14.1s	-15ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +680 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
buildDuration	14.1s	14.2s	⚠️ +114ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +680 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.86 kB	5.86 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..b6ebb586e.js	19.8 kB	19.8 kB	✓
16b1a7225520..586e.js gzip	7.25 kB	7.25 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..4c.module.js	15.9 kB	15.9 kB	✓
16b1a7225520..dule.js gzip	6.08 kB	6.08 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	200 B	200 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	ctavan/next.js improve-worker-count-configurability	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	✓
link.js	274 kB	274 kB	✓
link.js gzip	73.4 kB	73.4 kB	✓
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	✓
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	✓
Overall change	1.29 MB	1.29 MB	✓

Commit: 8cf0996

ctavan requested review from ijjk, lfades, Timer and timneutkens as code owners October 25, 2019 14:46

ctavan mentioned this pull request Oct 25, 2019

next build fails with "Module did not self-register." #7894

Closed

ctavan force-pushed the improve-worker-count-configurability branch 2 times, most recently from eb8e264 to a509a8d Compare October 25, 2019 15:12

ijjk previously requested changes Oct 28, 2019

View reviewed changes

ctavan added 4 commits October 28, 2019 20:32

Disable parallel build for firebase authentication example

b45c011

Add integration test to cover vercel#7894

684c8ff

ctavan force-pushed the improve-worker-count-configurability branch from a509a8d to 684c8ff Compare October 28, 2019 19:33

ctavan requested a review from ijjk October 28, 2019 19:34

Rename test suite and add worker_threads config

6d30574

ijjk reviewed Oct 28, 2019

View reviewed changes

examples/with-firebase-authentication/next.config.js Outdated Show resolved Hide resolved

Disable worker_threads by default

d0979f3

ijjk changed the title ~~Improve worker configurability~~ Disable worker_threads bye default for firebase compatibility Oct 28, 2019

ijjk changed the title ~~Disable worker_threads bye default for firebase compatibility~~ Disable worker_threads by default for firebase compatibility Oct 28, 2019

Timer added this to the 9.1.2 milestone Oct 28, 2019

Timer added the priority: high label Oct 28, 2019

Timer added the Type: Bug label Oct 28, 2019

Update index.test.js

d854702

Timer added the ready to land label Oct 28, 2019

Timer approved these changes Oct 28, 2019

View reviewed changes

Use workerThreads config for TerserPlugin

1f953f2

ijjk approved these changes Oct 28, 2019

View reviewed changes

Merge branch 'improve-worker-count-configurability' of github.com:cta…

efc83a2

…van/next.js into improve-worker-count-configurability

ijjk requested a review from Timer October 28, 2019 20:23

Timer approved these changes Oct 28, 2019

View reviewed changes

Update to use workerThreads config in

95747e1

TerserPlugin for consistency

Disable node 12 specific test

8cf0996

Timer merged commit 14ed867 into vercel:canary Oct 29, 2019

ctavan mentioned this pull request Oct 29, 2019

firebase/firestore breaks Next.js builds due to grpc limitations firebase/firebase-js-sdk#2299

Closed

snyk-bot mentioned this pull request Nov 25, 2019

[Snyk] Upgrade next from 9.0.4 to 9.1.3 ajesse11x/now-examples#17

Open

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable worker_threads by default for firebase compatibility #9199

Disable worker_threads by default for firebase compatibility #9199

ctavan commented Oct 25, 2019 •

edited by ijjk

Loading

ijjk commented Oct 25, 2019

ctavan commented Oct 25, 2019 •

edited

Loading

ijjk commented Oct 25, 2019

ijjk left a comment •

edited

Loading

ctavan commented Oct 28, 2019

ctavan commented Oct 28, 2019

ijjk commented Oct 28, 2019

ijjk commented Oct 28, 2019 •

edited

Loading

ijjk commented Oct 28, 2019

ctavan commented Oct 28, 2019

ijjk commented Oct 28, 2019

Timer commented Oct 28, 2019

ctavan commented Oct 28, 2019

ijjk commented Oct 28, 2019

ijjk commented Oct 28, 2019

ijjk commented Oct 28, 2019

ijjk commented Oct 28, 2019

Disable worker_threads by default for firebase compatibility #9199

Disable worker_threads by default for firebase compatibility #9199

Conversation

ctavan commented Oct 25, 2019 • edited by ijjk Loading

ijjk commented Oct 25, 2019

Stats from current PR

ctavan commented Oct 25, 2019 • edited Loading

ijjk commented Oct 25, 2019

Stats from current PR

ijjk left a comment • edited Loading

Choose a reason for hiding this comment

ctavan commented Oct 28, 2019

ctavan commented Oct 28, 2019

ijjk commented Oct 28, 2019

Stats from current PR

ijjk commented Oct 28, 2019 • edited Loading

ijjk commented Oct 28, 2019

Stats from current PR

ctavan commented Oct 28, 2019

ijjk commented Oct 28, 2019

Stats from current PR

Timer commented Oct 28, 2019

ctavan commented Oct 28, 2019

ijjk commented Oct 28, 2019

Stats from current PR

ijjk commented Oct 28, 2019

Stats from current PR

ijjk commented Oct 28, 2019

Stats from current PR

ijjk commented Oct 28, 2019

Stats from current PR

ctavan commented Oct 25, 2019 •

edited by ijjk

Loading

ctavan commented Oct 25, 2019 •

edited

Loading

ijjk left a comment •

edited

Loading

ijjk commented Oct 28, 2019 •

edited

Loading