Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable worker_threads by default for firebase compatibility #9199

Merged
merged 11 commits into from
Oct 29, 2019
Merged

Disable worker_threads by default for firebase compatibility #9199

merged 11 commits into from
Oct 29, 2019

Commits on Oct 28, 2019

  1. Pass config.experimental.cpus to export during build 

    Currently, there is no way of specifying the number of worker threads of
`next export` when run as part of `next build`.

I suggest a sane default should be to just use the same amount of
workers that were used during the build process which currently seems to
be configured through `config.experimental.cpus`.

This setting is already respected in the two other places where
jest-workers are in use: The TerserPlugin and the staticCheckWorkers in
`next build`.
    @ctavan
    ctavan committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    d4db464 View commit details
    Browse the repository at this point in the history

  2. Only enable worker threads if there is more than 1 worker 

    Multiple worker threads can cause problems when certain dependencies are
being used, see e.g. vercel#7894

This patch allows disabling of worker threads by setting
`config.experimental.cpus = 1`.

The benefit of spawning 1 worker thread, if there is any at all, should
very limited anyways, so the workload can just as well be processed in
the main thread.
    @ctavan
    ctavan committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    1516361 View commit details
    Browse the repository at this point in the history

  3. Disable parallel build for firebase authentication example

    @ctavan
    ctavan committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    b45c011 View commit details
    Browse the repository at this point in the history

  4. Add integration test to cover vercel#7894

    @ctavan
    ctavan committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    684c8ff View commit details
    Browse the repository at this point in the history

  5. Rename test suite and add worker_threads config

    @ijjk
    ijjk committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    6d30574 View commit details
    Browse the repository at this point in the history

  6. Disable worker_threads by default

    @ijjk
    ijjk committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    d0979f3 View commit details
    Browse the repository at this point in the history

  7. Update index.test.js

    @Timer
    Timer committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    d854702 View commit details
    Browse the repository at this point in the history

  8. Use workerThreads config for TerserPlugin

    @ijjk
    ijjk committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    1f953f2 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'improve-worker-count-configurability' of github.com:cta… 

    …van/next.js into improve-worker-count-configurability
    @ijjk
    ijjk committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    efc83a2 View commit details
    Browse the repository at this point in the history

  10. Update to use workerThreads config in 

    TerserPlugin for consistency
    @ijjk
    ijjk committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    95747e1 View commit details
    Browse the repository at this point in the history

  11. Disable node 12 specific test

    @ijjk
    ijjk committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    8cf0996 View commit details
    Browse the repository at this point in the history