Disable worker_threads by default

vercel · Oct 28, 2019 · d0979f3 · d0979f3
1 parent 6d30574
commit d0979f3
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 17 deletions.
diff --git a/examples/with-firebase-authentication/next.config.js b/examples/with-firebase-authentication/next.config.js
diff --git a/packages/next/build/webpack/plugins/terser-webpack-plugin/src/TaskRunner.js b/packages/next/build/webpack/plugins/terser-webpack-plugin/src/TaskRunner.js
@@ -28,8 +28,8 @@ export default class TaskRunner {
 
     if (this.maxConcurrentWorkers > 1) {
       this.workers = new Worker(worker, {
-        numWorkers: this.maxConcurrentWorkers,
         enableWorkerThreads: true,
+        numWorkers: this.maxConcurrentWorkers,
       })
       this.boundWorkers = options => this.workers.default(options)
     } else {

diff --git a/packages/next/next-server/server/config.ts b/packages/next/next-server/server/config.ts
@@ -48,7 +48,7 @@ const defaultConfig: { [key: string]: any } = {
     publicDirectory: false,
     sprFlushToDisk: true,
     deferScripts: false,
-    workerThreads: true,
+    workerThreads: false,
   },
   future: {
     excludeDefaultMomentLocales: false,

diff --git a/test/integration/firebase-grpc/test/index.test.js b/test/integration/firebase-grpc/test/index.test.js
@@ -10,7 +10,10 @@ const nextConfig = path.join(appDir, 'next.config.js')
 
 describe('Builds with firebase dependency only sequentially', () => {
   it('Throws an error when building with firebase dependency with worker_threads', async () => {
-    await fs.remove(nextConfig)
+    await fs.writeFile(
+      nextConfig,
+      `module.exports = { experimental: { workerThreads: true } }`
+    )
     const results = await nextBuild(appDir, [], { stdout: true, stderr: true })
     expect(results.stdout + results.stderr).toMatch(/Build error occurred/)
     expect(results.stdout + results.stderr).toMatch(
@@ -19,12 +22,8 @@ describe('Builds with firebase dependency only sequentially', () => {
   })
 
   it('Throws no error when building with firebase dependency without worker_threads', async () => {
-    await fs.writeFile(
-      nextConfig,
-      `module.exports = { experimental: { workerThreads: false } }`
-    )
-    const results = await nextBuild(appDir, [], { stdout: true, stderr: true })
     await fs.remove(nextConfig)
+    const results = await nextBuild(appDir, [], { stdout: true, stderr: true })
     expect(results.stdout + results.stderr).not.toMatch(/Build error occurred/)
     expect(results.stdout + results.stderr).not.toMatch(
       /grpc_node\.node\. Module did not self-register\./