Skip to content

fix: approval timeout lifecycle + late decision delivery#6711

Merged
noanflaherty merged 1 commit into
mainfrom
swarm/tg-approval-gaps/task-5
Feb 22, 2026
Merged

fix: approval timeout lifecycle + late decision delivery#6711
noanflaherty merged 1 commit into
mainfrom
swarm/tg-approval-gaps/task-5

Conversation

@noanflaherty
Copy link
Copy Markdown
Contributor

@noanflaherty noanflaherty commented Feb 22, 2026

Context

Addresses review feedback on #6691 and #6699

Changes

  • On approval poll timeout, mark event as processed instead of failed (avoids conflicting retry through processMessage)
  • After a decision is applied in handleApprovalInterception, add brief async poll for run terminal state and deliver reply (handles late approvals after original poll exits)
  • Update tests for new timeout and post-decision delivery behavior

Open with Devin

…n delivery fallback

Co-Authored-By: Claude <noreply@anthropic.com>
@noanflaherty noanflaherty self-assigned this Feb 22, 2026
@noanflaherty noanflaherty merged commit 9abc2c5 into main Feb 22, 2026
@noanflaherty noanflaherty deleted the swarm/tg-approval-gaps/task-5 branch February 22, 2026 20:43
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

Comment thread assistant/src/runtime/routes/channel-routes.ts
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 543a9164df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assistant/src/runtime/routes/channel-routes.ts
Comment thread assistant/src/runtime/routes/channel-routes.ts
@noanflaherty
Copy link
Copy Markdown
Contributor Author

Addressed in #6726

noanflaherty added a commit that referenced this pull request Feb 23, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
noanflaherty added a commit that referenced this pull request Feb 23, 2026
Co-authored-by: Claude <noreply@anthropic.com>
@noanflaherty
Copy link
Copy Markdown
Contributor Author

Addressed in #6956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant