Skip to content

fix: timeout lifecycle + channel capability parity#6699

Merged
noanflaherty merged 1 commit into
mainfrom
swarm/tg-approval-gaps/task-2
Feb 22, 2026
Merged

fix: timeout lifecycle + channel capability parity#6699
noanflaherty merged 1 commit into
mainfrom
swarm/tg-approval-gaps/task-2

Conversation

@noanflaherty
Copy link
Copy Markdown
Contributor

@noanflaherty noanflaherty commented Feb 22, 2026 •
edited by devin-ai-integration Bot
Loading

Context

Part of #6682: Telegram Approval Follow-Up Gap Closure

Changes

  • On approval poll timeout with non-terminal run, call recordProcessingFailure so the retry sweep can pick it up
  • Extend RunOrchestrator.startRun() to accept optional sourceChannel parameter for resolving channel capabilities
  • Pass sourceChannel from channel-routes approval path so Telegram runs get Telegram capabilities
  • Add tests for timeout failure recording and channel capability resolution

Closes #6684

Open with Devin

@noanflaherty @claude
fix: add timeout-to-retry lifecycle and channel capability parity for…
eaa91c9 
… approval flow

Co-Authored-By: Claude <noreply@anthropic.com>
@noanflaherty noanflaherty self-assigned this Feb 22, 2026
@noanflaherty noanflaherty merged commit 4d71da6 into main Feb 22, 2026
@noanflaherty noanflaherty deleted the swarm/tg-approval-gaps/task-2 branch February 22, 2026 20:31
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Feb 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Feb 22, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eaa91c93a3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assistant/src/runtime/routes/channel-routes.ts
@noanflaherty noanflaherty mentioned this pull request Feb 22, 2026
Merged
@noanflaherty
Copy link
Copy Markdown
Contributor Author

noanflaherty commented Feb 22, 2026

Addressed in #6711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

@noanflaherty noanflaherty

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

M2: Timeout lifecycle + channel capability parity

1 participant

@noanflaherty