Skip to content

fix: decision lifecycle + stale callback hardening#6691

Merged
noanflaherty merged 1 commit into
mainfrom
swarm/tg-approval-gaps/task-1
Feb 22, 2026
Merged

fix: decision lifecycle + stale callback hardening#6691
noanflaherty merged 1 commit into
mainfrom
swarm/tg-approval-gaps/task-1

Conversation

@noanflaherty

@noanflaherty noanflaherty commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

Context

Part of #6682: Telegram Approval Follow-Up Gap Closure

Changes

  • Remove immediate deliverReplyViaCallback() call after approval decision in handleApprovalInterception — final reply now only comes from terminal run completion path
  • Ensure stale callback button presses (callbackData present, no pending approval) return stale_ignored and never enter normal message processing
  • Add/update tests for decision lifecycle and stale callback safety

Closes #6683


Open with Devin

…callback handling

Co-Authored-By: Claude <noreply@anthropic.com>
@noanflaherty noanflaherty self-assigned this Feb 22, 2026
@noanflaherty noanflaherty merged commit be95d47 into main Feb 22, 2026
@noanflaherty noanflaherty deleted the swarm/tg-approval-gaps/task-1 branch February 22, 2026 20:26

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69f7352d0f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assistant/src/runtime/routes/channel-routes.ts
@noanflaherty

Copy link
Copy Markdown
Contributor Author

Addressed in #6711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

M1: Decision lifecycle + stale callback hardening

1 participant