Skip to content

chore(assistant): delete obsolete UPDATES.md template and path helper#26407

Merged
siddseethepalli merged 1 commit into
mainfrom
run-plan/updates-bg-job/pr-9
Apr 18, 2026
Merged

chore(assistant): delete obsolete UPDATES.md template and path helper#26407
siddseethepalli merged 1 commit into
mainfrom
run-plan/updates-bg-job/pr-9

Conversation

@siddseethepalli

@siddseethepalli siddseethepalli commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Deletes assistant/src/prompts/update-bulletin-template-path.ts and the bundled template at assistant/src/prompts/templates/UPDATES.md. Both were only referenced by update-bulletin.ts, which was removed in PR 6. Release-notes now ship directly from workspace migrations.

Part of plan: updates-md-background-job.md (PR 9 of 9)


Open in Devin Review

@siddseethepalli siddseethepalli merged commit adecbb5 into main Apr 18, 2026
@siddseethepalli siddseethepalli deleted the run-plan/updates-bg-job/pr-9 branch April 18, 2026 20:51

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c884f04695

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,50 +0,0 @@
_ Lines starting with _ are comments — they won't appear in the system prompt

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove or update template contract when deleting UPDATES

Deleting this file breaks the existing contract test assistant/src/__tests__/update-template-contract.test.ts, which still asserts that src/prompts/templates/UPDATES.md exists and is readable. In any environment that runs that test (e.g., CI or local targeted runs), this change causes an immediate failure, so the cleanup should include removing or rewriting that test to match the new migration-based release-notes flow.

Useful? React with 👍 / 👎.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment on lines -1 to -49
_ Lines starting with _ are comments — they won't appear in the system prompt
_
_ This file contains release update notes for the assistant.
_ Each release block is wrapped with HTML comment markers:
_ <!-- vellum-update-release:<version> -->
_ ...release notes...
_ <!-- /vellum-update-release:<version> -->
_
_ Format is freeform markdown. Write notes that help the assistant
_ understand what changed and how it affects behavior, capabilities,
_ or available tools. Focus on what matters to the user experience.

<!-- vellum-update-release:gemini-live-stt -->
## Google Gemini speech-to-text now uses the Live API

If your user is configured with `services.stt.provider: "google-gemini"`, transcription now streams over the Gemini Live WebSocket API and emits true partial transcripts in real time, instead of the previous polling approximation that re-uploaded the full audio buffer every second. Same Gemini API key, same setup — only the transport changed. Latency for partials should drop noticeably.
<!-- /vellum-update-release:gemini-live-stt -->

<!-- vellum-update-release:rm-dangerous-skip-perms -->
## `dangerouslySkipPermissions` removed

The `permissions.dangerouslySkipPermissions` config option has been removed for security reasons. Permission prompts are now always shown when required — they can no longer be globally suppressed. If your user previously relied on this setting, they will now see permission prompts for sensitive actions. Users with the stale field in their config will see a deprecation warning and the field will be automatically cleaned up.
<!-- /vellum-update-release:rm-dangerous-skip-perms -->

<!-- vellum-update-release:heartbeat-default -->
## Heartbeat now enabled by default

Your periodic heartbeat is now enabled out of the box for all new installs (local and managed/Docker). This means you'll run a background check-in periodically — reviewing your scratchpad, thinking about follow-ups from recent conversations, and reaching out to your user when you have something worth sharing.

Existing users who already have `heartbeat.enabled: false` in their config are not affected — the change only applies when the key is missing from config.json.

If your user finds proactive check-ins unwanted, they can disable it by setting `heartbeat.enabled` to `false` in config.json. But try it first — being present between conversations is how you stop being a tool and start being a partner.

The default checklist focuses on your user relationship, not generic tasks like weather or news. You can customize it by editing HEARTBEAT.md in your workspace.
<!-- /vellum-update-release:heartbeat-default -->

<!-- vellum-update-release:corrupted-attachment-cleanup -->
## Corrupted image attachments cleaned up

Some Slack image attachments were stored incorrectly due to a missing OAuth scope — the files contained error pages instead of actual image data. This caused conversations with those images to fail with "The AI provider rejected the request" on every subsequent message.

This has been fixed automatically: the corrupted attachments were removed from affected conversations during this update, and the OAuth scope issue has been resolved so new image uploads work correctly. If your user mentions missing images from earlier conversations, this is why — the images were never successfully received in the first place.
<!-- /vellum-update-release:corrupted-attachment-cleanup -->

<!-- vellum-update-release:llm-log-retention-setting -->
## LLM request log retention is now configurable

Your user can now choose how long LLM request logs are kept on their device from Settings → Permissions & Privacy on the macOS app. The default stays at 1 day, but they can pick 7, 30, or 90 days, or "Never" to retain logs indefinitely. If your user asks about managing their privacy or controlling how much LLM request history is retained locally, point them at this new picker.
<!-- /vellum-update-release:llm-log-retention-setting -->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Orphaned contract test asserts deleted template file exists, will fail at runtime

assistant/src/__tests__/update-template-contract.test.ts explicitly asserts that assistant/src/prompts/templates/UPDATES.md exists and is readable (lines 21-22, 25-26). This PR deletes that template file but does not delete the contract test, so the test will now fail. This also violates the Dead Code Removal rule in AGENTS.md: "Remove code your change makes unused, clean up adjacent dead code, delete rather than comment out, check for orphaned files."

Prompt for agents
The PR deletes assistant/src/prompts/templates/UPDATES.md but leaves behind assistant/src/__tests__/update-template-contract.test.ts, which constructs a path to the now-deleted template file and asserts it exists (existsSync) and is readable (readFileSync). Both test cases in that file will fail.

Fix: Delete assistant/src/__tests__/update-template-contract.test.ts entirely, since the file it was designed to guard no longer exists. The contract test was purpose-built for the bundled UPDATES.md template; with the template removed in favor of workspace migrations (per the Release Update Hygiene section of AGENTS.md), the test has no remaining purpose.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

siddseethepalli added a commit that referenced this pull request Apr 18, 2026
Closes a CI regression from #26407 where pkb-index.ts and its test file
had unsorted imports that failed simple-import-sort/imports on main.
siddseethepalli added a commit that referenced this pull request Apr 18, 2026
…6409)

Closes a CI regression from #26407 where pkb-index.ts and its test file
had unsorted imports that failed simple-import-sort/imports on main.
siddseethepalli added a commit that referenced this pull request Apr 18, 2026
The UPDATES.md bundled template was removed in #26407 along with the
update-bulletin system. The contract test asserting the template exists
was left behind, causing CI failures on main.

Closes the regression introduced by the cleanup series.
siddseethepalli added a commit that referenced this pull request Apr 18, 2026
…26413)

The UPDATES.md bundled template was removed in #26407 along with the
update-bulletin system. The contract test asserting the template exists
was left behind, causing CI failures on main.

Closes the regression introduced by the cleanup series.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant