Skip to content

fix(assistant): sort imports in pkb-index to unblock lint on main#26409

Merged
siddseethepalli merged 1 commit into
mainfrom
do/fix-pkb-import-sort
Apr 18, 2026
Merged

fix(assistant): sort imports in pkb-index to unblock lint on main#26409
siddseethepalli merged 1 commit into
mainfrom
do/fix-pkb-import-sort

Conversation

@siddseethepalli

@siddseethepalli siddseethepalli commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Reorder imports in `assistant/src/memory/pkb/pkb-index.ts` and `pkb-index.test.ts` to satisfy `simple-import-sort/imports`.
  • Lint has been red on `main` since commit c2080dd; this restores green.

Original prompt

--yolo Fix the specific CI issue in this failing job only: https://github.com/vellum-ai/vellum-assistant/actions/runs/24613597878/job/71972072374


Open in Devin Review

Closes a CI regression from #26407 where pkb-index.ts and its test file
had unsorted imports that failed simple-import-sort/imports on main.
@siddseethepalli siddseethepalli merged commit b09e622 into main Apr 18, 2026
@siddseethepalli siddseethepalli deleted the do/fix-pkb-import-sort branch April 18, 2026 20:53

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@siddseethepalli

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant