Skip to content

feat(assistant): run update-bulletin job on daemon startup#26400

Merged
siddseethepalli merged 1 commit into
mainfrom
run-plan/updates-bg-job/pr-5
Apr 18, 2026
Merged

feat(assistant): run update-bulletin job on daemon startup#26400
siddseethepalli merged 1 commit into
mainfrom
run-plan/updates-bg-job/pr-5

Conversation

@siddseethepalli

@siddseethepalli siddseethepalli commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Swaps the blocking syncUpdateBulletinOnStartup() call in the daemon startup path for a fire-and-forget dynamic import of runUpdateBulletinJobIfNeeded(). The job module is only loaded once dbReady is true.
  • Respects the daemon-never-blocks-startup invariant: any failure is logged at warn and startup continues.

Part of plan: updates-md-background-job.md (PR 5 of 9)


Open in Devin Review

@siddseethepalli siddseethepalli merged commit 4b72760 into main Apr 18, 2026
@siddseethepalli siddseethepalli deleted the run-plan/updates-bg-job/pr-5 branch April 18, 2026 20:47

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread assistant/src/daemon/lifecycle.ts
Comment thread assistant/src/daemon/lifecycle.ts
@siddseethepalli

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b72760315

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assistant/src/daemon/lifecycle.ts
@siddseethepalli

Copy link
Copy Markdown
Contributor Author

Feedback addressed in subsequent merged PRs:

Codex P1 (wake-resolver race + checkpoint poisoning):

Devin (dead syncUpdateBulletinOnStartup tree):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant