fix: remove arbitrary 500-word threshold from document-writer skill#24388
Conversation
The word count threshold was arbitrary and prevented the skill from being used for shorter content that would still benefit from the document editor. Co-Authored-By: Claude <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| includes: | ||
| - "document" |
There was a problem hiding this comment.
🟡 catalog.json not updated to reflect new includes metadata in SKILL.md
The PR adds includes: ["document"] to the document-writer SKILL.md frontmatter but does not update the corresponding entry in skills/catalog.json:66-77. Every other skill that declares includes in its SKILL.md has the field mirrored in catalog.json under metadata.vellum.includes (e.g., oura at skills/catalog.json:218, restaurant-reservation at skills/catalog.json:264, voice-setup at skills/catalog.json:450). The repo has a dedicated script scripts/skills/generate-catalog.mjs for regenerating the catalog, and the most recent catalog commit is titled "chore: regenerate skills/catalog.json", confirming the expectation that the two stay in sync. The runtime skill loading reads includes from the parsed SKILL.md so core behavior is unaffected, but the catalog manifest served to clients and used for discovery will be missing this dependency information for document-writer.
Prompt for agents
The skills/catalog.json entry for document-writer (around line 66-77) needs to be updated to include the new includes field under metadata.vellum, matching the pattern used by all other skills with includes (e.g. oura, voice-setup, slack-app-setup). The entry should change from:
"vellum": { "display-name": "Document Writer" }
to:
"vellum": { "display-name": "Document Writer", "includes": ["document"] }
Alternatively, run the scripts/skills/generate-catalog.mjs script to regenerate the catalog automatically.
Was this helpful? React with 👍 or 👎 to provide feedback.
| includes: | ||
| - "document" |
There was a problem hiding this comment.
🚩 Semantic overlap between document-writer (catalog) and document (bundled) skills
The document-writer first-party catalog skill and the document bundled skill have significant overlap in purpose — both deal with creating/editing long-form documents using the document editor. With this PR, document-writer now includes the document skill, meaning loading document-writer will also load document's SKILL.md content. The document bundled skill (assistant/src/config/bundled-skills/document/SKILL.md) is a concise 34-line skill focused on the tools (document_create, document_update), while document-writer is a 199-line skill with detailed workflow guidance, examples, and anti-patterns. The includes relationship makes sense (document-writer provides the workflow guidance, document provides the tool definitions), but reviewers should verify this is the intended skill architecture and that loading both doesn't produce conflicting instructions for the LLM.
Was this helpful? React with 👍 or 👎 to provide feedback.
The word count threshold was arbitrary and prevented the skill from being used for shorter content that would still benefit from the document editor. Co-authored-by: Claude <noreply@anthropic.com>
1 participant
Summary
🤖 Generated with Claude Code