Skip to content

fix: remove arbitrary 500-word threshold from document-writer skill #24388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asharma53 merged 1 commit into from
Apr 8, 2026
Merged

fix: remove arbitrary 500-word threshold from document-writer skill #24388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions skills/document-writer/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ metadata:
emoji: "📝"
vellum:
display-name: "Document Writer"
includes:
- "document"
Comment on lines +9 to +10
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 catalog.json not updated to reflect new includes metadata in SKILL.md

The PR adds includes: ["document"] to the document-writer SKILL.md frontmatter but does not update the corresponding entry in skills/catalog.json:66-77. Every other skill that declares includes in its SKILL.md has the field mirrored in catalog.json under metadata.vellum.includes (e.g., oura at skills/catalog.json:218, restaurant-reservation at skills/catalog.json:264, voice-setup at skills/catalog.json:450). The repo has a dedicated script scripts/skills/generate-catalog.mjs for regenerating the catalog, and the most recent catalog commit is titled "chore: regenerate skills/catalog.json", confirming the expectation that the two stay in sync. The runtime skill loading reads includes from the parsed SKILL.md so core behavior is unaffected, but the catalog manifest served to clients and used for discovery will be missing this dependency information for document-writer.

Prompt for agents 
The skills/catalog.json entry for document-writer (around line 66-77) needs to be updated to include the new includes field under metadata.vellum, matching the pattern used by all other skills with includes (e.g. oura, voice-setup, slack-app-setup). The entry should change from:

"vellum": { "display-name": "Document Writer" }

to:

"vellum": { "display-name": "Document Writer", "includes": ["document"] }

Alternatively, run the scripts/skills/generate-catalog.mjs script to regenerate the catalog automatically.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +9 to +10
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Semantic overlap between document-writer (catalog) and document (bundled) skills

The document-writer first-party catalog skill and the document bundled skill have significant overlap in purpose — both deal with creating/editing long-form documents using the document editor. With this PR, document-writer now includes the document skill, meaning loading document-writer will also load document's SKILL.md content. The document bundled skill (assistant/src/config/bundled-skills/document/SKILL.md) is a concise 34-line skill focused on the tools (document_create, document_update), while document-writer is a 199-line skill with detailed workflow guidance, examples, and anti-patterns. The includes relationship makes sense (document-writer provides the workflow guidance, document provides the tool definitions), but reviewers should verify this is the intended skill architecture and that loading both doesn't produce conflicting instructions for the LLM.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

---

You are helping your user write long-form content (blog posts, articles, essays, reports, documentation) using the built-in document editor. This skill should be used whenever the user asks to write, draft, or create any document-like content.
Expand All @@ -19,10 +21,9 @@ You are helping your user write long-form content (blog posts, articles, essays,
- Reports
- Guides or tutorials
- Documentation
- Any long-form written content (500+ words)
- Any written content that benefits from the document editor

**DO NOT use this skill for:**
- Short responses or explanations (< 500 words)
- Code snippets or technical implementations
- Interactive apps or dashboards (use `app_create` instead)
- Quick summaries
Expand Down
Loading