Skip to content

chore: sync catalog.json with document-writer includes metadata#24402

Merged
asharma53 merged 1 commit into
mainfrom
do/sync-catalog-includes
Apr 8, 2026
Merged

chore: sync catalog.json with document-writer includes metadata#24402
asharma53 merged 1 commit into
mainfrom
do/sync-catalog-includes

Conversation

@asharma53
Copy link
Copy Markdown
Contributor

@asharma53 asharma53 commented Apr 8, 2026

Summary

Original prompt

can you address the feedback in this PR comment? #24388

🤖 Generated with Claude Code


Open with Devin

@asharma53 asharma53 merged commit 8d504fd into main Apr 8, 2026
@asharma53 asharma53 deleted the do/sync-catalog-includes branch April 8, 2026 19:14
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread skills/catalog.json
"name": "watch-together",
"description": "Watch TV shows and movies with the user in real time by processing screen captures into frames and audio analysis.",
"metadata": {
"vellum": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 watch-together emoji is nested under metadata.vellum unlike other skills

The watch-together entry has emoji nested under metadata.vellum.emoji (skills/catalog.json:472-473), while nearly all other skills place it at metadata.emoji (e.g., agentmail at line 10). This is because the watch-together/SKILL.md:4-6 frontmatter nests emoji under vellum: rather than at the top level of metadata:. The catalog generator copies metadata as-is from frontmatter, so this is a pre-existing inconsistency in the SKILL.md, not introduced by this PR. It may affect emoji resolution if the consumer only checks metadata.emoji and not metadata.vellum.emoji.

(Refers to lines 472-473)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

noanflaherty pushed a commit that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant