Skip to content

docs(attachments): document vellum-attachment usage and outbound attachment architecture#2281

Merged
siddseethepalli merged 2 commits into
mainfrom
attachments/pr18-docs-prompt
Feb 15, 2026
Merged

docs(attachments): document vellum-attachment usage and outbound attachment architecture#2281
siddseethepalli merged 2 commits into
mainfrom
attachments/pr18-docs-prompt

Conversation

@siddseethepalli
Copy link
Copy Markdown
Contributor

@siddseethepalli siddseethepalli commented Feb 15, 2026

Summary

  • Add attachment syntax instructions to the system prompt (<vellum-attachment /> directive) so the assistant knows how to attach files/images
  • Document runtime API attachment metadata and fetch endpoint in the main README
  • Document Telegram outbound attachment behavior (sendPhoto/sendDocument, oversized skip, partial failure notices) in the gateway README
  • Update architecture diagram: add gateway attachment sender node, update IPC message types to show optional attachments field on message_complete and generation_handoff

Test plan

  • All 32 system-prompt tests pass
  • Verified buildSystemPrompt() output includes the new "Sending Files and Images" section

🤖 Generated with Claude Code


Open with Devin

siddseethepalli and others added 2 commits February 15, 2026 05:20
…chment architecture

Add attachment syntax instructions to the system prompt so the assistant
knows how to use <vellum-attachment /> directives. Document the runtime
API attachment metadata and fetch endpoint in the main README. Document
Telegram outbound attachment behavior in the gateway README.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update IPC message types (message_complete, generation_handoff) to show
optional attachments field. Add gateway attachment sender to the system
overview diagram.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@siddseethepalli siddseethepalli merged commit f051def into main Feb 15, 2026
2 of 3 checks passed
@siddseethepalli siddseethepalli deleted the attachments/pr18-docs-prompt branch February 15, 2026 05:21
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 330dc50349

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assistant/src/config/system-prompt.ts
Comment thread README.md
Comment thread README.md
@siddseethepalli
Copy link
Copy Markdown
Contributor Author

Addressed in #2299

@siddseethepalli
Copy link
Copy Markdown
Contributor Author

All three Codex comments have been addressed or triaged:

  1. Host attachments always denied - Stale. approveHostAttachmentRead now delegates to the permission checker via check(), not hardcoded false. Added in feat(attachments): gate host directives via confirmation flow #2285.
  2. Attachments not on message_complete/generation_handoff - Stale. Both events now include attachments payload when present (session.ts lines 999 and 1015). Added in feat(attachments): emit assistant attachments on completion events #2286.
  3. Missing conversationKey - Already fixed in main by a concurrent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant