docs(attachments): add required conversationKey param to messages endpoint#2299
Merged
Merged
Conversation
The GET /v1/assistants/:id/messages endpoint requires a conversationKey query parameter, but the docs omitted it — callers following the docs would get a 400 error. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
2 tasks
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversationKeyquery parameter to theGET /v1/assistants/:id/messagesendpoint documentation in README.mdAddresses feedback from PR #2281 (codex review comment about missing conversationKey).
The other two codex review comments on #2281 were incorrect:
approveHostReadis hardcoded tofalse, butapproveHostAttachmentRead()actually delegates to the permission checker and can returntruewhen trusted.message_completeandgeneration_handoffdon't include attachments, but both events conditionally include theattachmentsfield whenemittedAttachments.length > 0.Test plan
handleListMessagesinhttp-server.tsrequiresconversationKeyquery parameter (returns 400 without it)Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com