docs(attachments): add conversationKey to messages endpoint#2301
Closed
siddseethepalli wants to merge 1 commit into
Closed
docs(attachments): add conversationKey to messages endpoint#2301siddseethepalli wants to merge 1 commit into
siddseethepalli wants to merge 1 commit into
Conversation
…point The GET /v1/assistants/:id/messages endpoint requires a conversationKey query parameter (returns 400 without it). Update the README to show the parameter in the endpoint path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing - the conversationKey fix was already applied in main by another PR. The remaining two Codex comments on #2281 are stale (host approval and IPC attachment payloads both work correctly in current code). |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversationKeyquery parameter to theGET /v1/assistants/:id/messagesendpoint in the READMEhandleListMessagesinhttp-server.ts), so the docs were incompleteAddresses review feedback from Codex on #2281 (comment #3 - missing conversationKey).
The other two Codex comments on #2281 are stale:
approveHostAttachmentReadnow delegates to the permission checker viacheck(), not hardcoded falseattachmentspayload when present (lines 999 and 1015 in session.ts)Test plan
Generated with Claude Code