-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class \CRM_Mosaico_AbDemux not found - potential conflict with org.civicoop.areas ? #427
Comments
@totten @seamuslee001 are we also clearing the services on extension upgrades in an ok order? @ufundo if you manually delete the file above it should work? The services are cached in files like |
Hi @eileenmcnaughton thanks for help. Was getting the same error even after deleting the I noticed this civicrm/civicrm-core#19141 and wondered if might be relevant. Have just found the extension upgrade seems to work OK if the site is upgraded to 5.33.1 before extension upgrade. If the container-thing-I-don't-understand is required for smooth upgrade perhaps this new 2.6 Mosaico release should require 5.32 where it is merged into core? |
@mattwire I think that makes sense to increment the supported version to reduce issues people hit / have to be supported - people on 5.28 can continue to use 2.5 until the next civi security release drops... |
@ufundo @eileenmcnaughton I've upgraded a number of 5.28.4 sites to 2.6 with no issues. That said, I had similar issues on a number of sites when flexmailer moved from extension to core extension and #19141 probably resolves those issues too. So I'd say not mosaico specific. I don't mind incrementing min-version but 2.6 is already released and published. |
@ufundo I have the same issue as you do. Cant upgrade to 2.6 without the fatal error you describe |
Sorry @magnolia61 (though I guess it's nice to know it's not just me ;) Unfortunately I've found the apparently successful extension upgrade after upgrading to 5.33.1 was only on the surface. No longer crashes every page but is still throwing the error in other places (every time cron runs at least, not sure where else...) |
Strangely it started crashing fatally on 5.33.1 in the same way it had on 5.28, so seemingly not resolved by #19141 . FWIW no crashes after commenting
Will try to dig a bit more into later today... |
@totten any thoughts? |
Did some digging. Seems to be a conflict with @jaapjansma 's https://lab.civicrm.org/extensions/areas . Disabling areas extension resolves the crashing and have been able to reproduce the error on a fresh buildkit by just installing mosaico and areas (CiviCRM 5.35.alpha1 Drupal 7.78). I'm afraid I couldn't see why the conflict though. @magnolia61 - I wonder if this is the case for you also? |
Good sleuthing! |
Spot on. Disabling the Area extension did the trick. @jaapjansma would you have a clue on how this could be connected? |
I don't know what causes this error. |
Hmm, I can't see anything in code for either extension that looks like it would clash. Would it be appropriate to raise an issue on the Areas repo as well? |
Yes that would appropriate to do so. ps. I am the original developer of the area extension so a fix would be more than welcome. |
It might be that those lines are causing the issue: https://lab.civicrm.org/extensions/areas/-/blob/master/areas.php#L144 |
Note that I also had this error upgrading to 2.6 and could not recover by disabling the areas extension via the database. 5.32.2-Drupal 7.78 |
I'm having this problem on Civi 5.33.2 (D8 latest) and I don't have the Areas extension installed. My backtrace follows.
|
I couldn't replicate this on my dmaster with Mosaico and Areas (though I haven't updated my dev site so it's still on 5.34, not 5.35). However, I notice that what Areas and Salutations have in common is they both make an API3 call inside the I don't know Symfony very well, but I think I've got several pieces of this puzzle:
This seems like something @totten is the expert on. This is starting to feel like an issue in core rather than the extensions. |
I have the same Problem on a civicrm 5.28.3, when updating mosaico extension. CiviCRM throws this error on all sites then. I do not have areas installed in that env. I also cannot find Extensions that are utilizing This is reproducible, tested on 2 sites with above specs. |
We're also seeing this on a single CiviCRM site with Areas and Mosaico that was just upgraded to Drupal 9. |
I have a one-line patch that very likely solves this problem. I would wait for Jenkins to run a pass on it, but after that it'd be great to hear from others (on the PR!) whether the patch fixes this bug. |
@MegaphoneJon patch worked for me! |
I have this same error on a wordpress civicrm site without areas extension. The patch from @MegaphoneJon did not work for me. |
I have found the issue and proposed a fix: #446 The issue is that the |
This was fixed in an earlier 2.x release via #446 |
Hi,
Upgrade from 2.5 to 2.6 caused this fatal error around the container / service loading for me on CiviCRM 5.28.3 , Drupal 7, PHP 7.3:
Class \CRM_Mosaico_AbDemux not found in CachedCiviContainer->getMosaicoAbDemuxService() (line 840 .../civicrm/templates_c/CachedCiviContainer.~~~~.php)
Tried clearing caches and manually emptying templates_c directory with no success. Works again downgrading to 2.5. Some compatibility issue?
The text was updated successfully, but these errors were encountered: