Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2232 Permit hook_civicrm_container and some other prebootish… #19141

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

seamuslee001
Copy link
Contributor

… hooks to run during upgrade and clear out the asset builder cache post upgrade

Overview

This is an alternate to #19133 This aims to achieve the same result of a smooth upgrade by permitting the hook_civicrm_container running during the upgrade and some other hooks which might assist end users and also when I tested locally I found I couldn't create a new mosaico mailing after upgrade from 5.32 to 5.34 because aset builder cache was problematic so this clears it as well

Before

Error about undefined service

After

No error and smooth upgrade

ping @eileenmcnaughton @kcristiano

@civibot
Copy link

civibot bot commented Dec 8, 2020

(Standard links)

@civibot civibot bot added the master label Dec 8, 2020
@kcristiano
Copy link
Member

@seamuslee001 Thanks. I built a tarball based on master (5.34-alpa) and 5.33 (5.33-RC) with the patch and upgraded two sites with the built in flexmailer and Mosaico 2.5

  • r-run 5.33-RC to 5.34-alpha success
  • r-run 5.30.0 to 5.33-RC success

This looks good to merge. I'd actually want to target 5.33 so it gets in the RC and then we can merge 5.33 to master.

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 I think rc would make sense - that gives us the option of backporting if we choose

… hooks to run during upgrade and clear out the asset builder cache post upgrade
@seamuslee001 seamuslee001 changed the base branch from master to 5.33 December 8, 2020 20:47
@civibot civibot bot added 5.33 and removed master labels Dec 8, 2020
@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton @kcristiano rebased onto the RC now

@kcristiano
Copy link
Member

Thanks Seamus. I did another upgrade with this on a rebuilt 5.33-RC tarball and it works perfectly. I think it's good to merge

@eileenmcnaughton
Copy link
Contributor

Nice - thanks @seamuslee001 - I think this will resolve a slow trickle of errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants