Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #427 #446

Merged
merged 1 commit into from
May 24, 2021
Merged

Fix for issue #427 #446

merged 1 commit into from
May 24, 2021

Conversation

jaapjansma
Copy link
Contributor

No description provided.

@jaapjansma jaapjansma mentioned this pull request Apr 23, 2021
Closed
@mattwire
Copy link
Collaborator

@totten This look ok?

@totten
Copy link
Collaborator

totten commented Apr 23, 2021 •
edited
Loading

Aaah, very interesting. I've only skimmed the original discussion, but I'm OK with this conceptually as a near-term fix for Mosaico.

I would be curious about whether it's been fixed incidentally on civicrm-core@master. We had some recent PRs to address other "class not found" issues for edge-cases of the extension-lifecycle.

Specifically, if one adds this to info.xml, then it should provide more robust classloading:

<classloader>
  <psr0 prefix="CRM_" path="" />
</classloader>

@jaapjansma
Copy link
Contributor Author

I have tried to add the code below to info.xml but the error still occurs. (It is on CiviCRM 5.35.0)

<classloader>
  <psr0 prefix="CRM_" path="" />
</classloader>

@mattwire mattwire merged commit 0e458ea into veda-consulting-company:2.x May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaapjansma @mattwire @totten