Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ rand #424

Merged
merged 2 commits into from
Aug 23, 2019
Merged

⬆️ rand #424

merged 2 commits into from
Aug 23, 2019

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Aug 22, 2019

I'm submitting a(n) other

Description

Update rand to the next major version (0.7)

Motivation

avoid rand duplication across ecosystem

Tests

cargo test locally works

Related Issue(s)

@Dylan-DPC-zz
Copy link
Member

Thanks do look at #417

@matklad
bump MSRV to 1.32.0
3098118 
It would be ideal not to do this, but `rand`, which is a pretty
foundational crate, has 1.32.0 as MSRV, and it seems pretty unlikely
that anyone uses `uuid` and does not depend on new rand via some other
crate.
@matklad
Copy link
Contributor Author

matklad commented Aug 22, 2019

Yeah, rand bumping msrv to 1.32.0 is unfortunate. That said, 1.32.0 is just one version ahead of 1.31.0, and rand is pretty widely used anyway

@Dylan-DPC-zz
Copy link
Member

Dylan-DPC-zz commented Aug 22, 2019 •
edited
Loading

I was referring to this. Not sure if it still holds true. We are blocked on the std issue

@matklad
Copy link
Contributor Author

matklad commented Aug 22, 2019

Hm, I am confused... How it worked with rand 0.6? Surely, to generate a random number for UUID V4 one needs to call into OS for entropy?

@matklad
Copy link
Contributor Author

matklad commented Aug 23, 2019

So, I've looked more into this, and it seems like we are all set?

rand indeed needs std to make thread_local work, and UUID already depends on rand with default features (ie, std is always enabled for rand, with old 0.6 version or with new 0.7).

I might be missing something obvious, but std/no_std seems completely irrelevant.

The only problem with rand is that its MSRV is 1.32, and I argue it's fine to bump MSRV for UUID as well, blaming rand :D

@kinggoesgaming
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Aug 23, 2019
@bors @matklad
Merge #424
013b8eb 
424: ⬆️ rand r=kinggoesgaming a=matklad

**I'm submitting a(n)** other


# Description

Update rand to the next major version (0.7)

# Motivation

avoid rand duplication across ecosystem

# Tests
`cargo test` locally works

# Related Issue(s)


Co-authored-by: Aleksey Kladov <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2019

Build succeeded

@bors bors bot merged commit 3098118 into uuid-rs:master Aug 23, 2019
@matklad matklad deleted the rand branch August 23, 2019 20:08
@matklad matklad mentioned this pull request Aug 24, 2019
Closed
@Dylan-DPC-zz
Copy link
Member

Thanks. Sorry for the confusion. Never got time to discuss what exactly the no std problem was 😆

@KodrAus KodrAus mentioned this pull request Oct 17, 2019
Merged
bors bot added a commit that referenced this pull request Oct 17, 2019
@bors @KodrAus
Merge #433
aa6d78f 
433: Prepare for 0.8.0 release r=Dylan-DPC a=KodrAus

Closes #431 

[Changeset since the last release](0.7.4...master)

Includes:

- #427 
- #419 
- #424 
- #418 
- #413 
- #407 
- #404 
- #400 
- #399 
- #398 
- #397 
- #396 
- #394 
- #393 
- #390
- #389 
- #388 

I've also added some docs to the 128bit integer methods to clarify how they're different than `to_fields` (for consistency with other uuid libs in the wild).

Co-authored-by: Ashley Mannix <[email protected]>
@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinggoesgaming kinggoesgaming kinggoesgaming approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

@KodrAus KodrAus Awaiting requested review from KodrAus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matklad @Dylan-DPC-zz @kinggoesgaming