add sentence to Uuid::to_timestamp docs specifying format
#404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e timestamp (i.e. what the number represents)
jonathanstrong
requested review from
Dylan-DPC-zz,
kinggoesgaming and
KodrAus
as code owners
kinggoesgaming
approved these changes
May 10, 2019
|
Thanks @jonathanstrong bors r+ |
bors bot
added a commit
that referenced
this pull request
May 10, 2019
404: add sentence to `Uuid::to_timestamp` docs specifying format r=kinggoesgaming a=jonathanstrong I'm submitting a small addition to the documentation for `Uuid::to_timestamp`. # Description The sentence explains what the timestamp number represents (100ns intervals since 1582-10-15). # Motivation I think it's wise to include since this is not a common timestamp format in other contexts. Co-authored-by: Jonathan Strong <[email protected]>
bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
433: Prepare for 0.8.0 release r=Dylan-DPC a=KodrAus Closes #431 [Changeset since the last release](0.7.4...master) Includes: - #427 - #419 - #424 - #418 - #413 - #407 - #404 - #400 - #399 - #398 - #397 - #396 - #394 - #393 - #390 - #389 - #388 I've also added some docs to the 128bit integer methods to clarify how they're different than `to_fields` (for consistency with other uuid libs in the wild). Co-authored-by: Ashley Mannix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a small addition to the documentation for
Uuid::to_timestamp.Description
The sentence explains what the timestamp number represents (100ns intervals since 1582-10-15).
Motivation
I think it's wise to include since this is not a common timestamp format in other contexts.