-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing adapter traits using macro #396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamAndMath
requested review from
Dylan-DPC-zz,
kinggoesgaming and
KodrAus
as code owners
April 8, 2019 13:54
Self doesn't work rust-lang/rust#52808uuid/src/adapter/core_support/mod.rs Lines 26 to 31 in 7da2597
This comment was generated by todo based on a
|
Self doesn't work rust-lang/rust#52808uuid/src/adapter/core_support/mod.rs Lines 33 to 38 in 7da2597
This comment was generated by todo based on a
|
Dylan-DPC-zz
approved these changes
Apr 8, 2019
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Apr 8, 2019
396: Implementing adapter traits using macro r=Dylan-DPC a=adamAndMath I'm submitting a refactor of trait implementations for adapter traits # Description As all the trait implementations are the same across all adapters, they can be implemented using a single macro. # Motivation Reducing code duplication and improving transparency of intent. # Tests As there are no code changes, this change is covered by existing tests Co-authored-by: Adam <[email protected]>
Had this in mind for a LONGGG time thanks |
bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
433: Prepare for 0.8.0 release r=Dylan-DPC a=KodrAus Closes #431 [Changeset since the last release](0.7.4...master) Includes: - #427 - #419 - #424 - #418 - #413 - #407 - #404 - #400 - #399 - #398 - #397 - #396 - #394 - #393 - #390 - #389 - #388 I've also added some docs to the 128bit integer methods to clarify how they're different than `to_fields` (for consistency with other uuid libs in the wild). Co-authored-by: Ashley Mannix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a refactor of trait implementations for adapter traits
Description
As all the trait implementations are the same across all adapters, they can be implemented using a single macro.
Motivation
Reducing code duplication and improving transparency of intent.
Tests
As there are no code changes, this change is covered by existing tests