Bugfix/fixes 251 #465
Bugfix/fixes 251 #465
Conversation
|
|
||
| const PATH_SEPARATOR = path.sep; | ||
| const PATH_SEPARATOR = /Windows/i.test(os.release()) ? '\\' : '/'; |
There was a problem hiding this comment.
You can use isWindows function from utils/common/platform
|
@Scotsoo Can you reply to this on the main issue ? #251 (comment) |
|
Need some help here. Can someone test this on windows and confirm? This was the initial fix (fcc12fb) for the phantom folder issue that occurred while renaming The rename perfectly works in linux and mac. The problem is only on windows. |
Apologies, replied |
|
So have been testing around a bit and the Path separator seems to be the underlying issue. So when this fix is merged, But before we merge this, I would suggest moving the |
…me/delete needs to be run only on windows" This reverts commit fcc12fb. # Conflicts: # packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js # packages/bruno-app/src/utils/common/platform.js
|
Done! After reverted changeset + PATH_SEP moved to platform: |
|
Also deletion works so fixes #265 too |
| }) | ||
| .catch(reject); | ||
| ipcRenderer.invoke('renderer:rename-item', item.pathname, newPathname, newName).then(() => { | ||
| dispatch(_renameItem({ newName, itemUid, collectionUid })) |
There was a problem hiding this comment.
I think the _renameItem call can be removed, because this was basically the original fix.
|
Merged. Thanks @Scotsoo ! |
Fixes underlying issue with using path.sep in windows: #251