Skip to content

Bugfix/fixes 251 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 18, 2023
Merged

Bugfix/fixes 251 #465

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
094bf7b
fix(#251): Uses os.release to get correct pathsep for windows
Scotsoo Oct 8, 2023
b47b056
Merge branch 'main' into bugfix/fixes-251
Scotsoo Oct 8, 2023
ff3c666
use isWindowsOS()
Scotsoo Oct 10, 2023
9ca22cd
Merge tag 'v0.22.1' into bugfix/fixes-251
Scotsoo Oct 10, 2023
b07ccbd
adds PATH_SEPARATOR constant
Scotsoo Oct 14, 2023
7808a6d
Revert "fix(#251, #265): phantoms folders fix on rename/delete needs …
Scotsoo Oct 14, 2023
0f1fb72
fix(#251): Re-add platform var
Scotsoo Oct 14, 2023
211f941
rm renameitem
Scotsoo Oct 15, 2023
074cbf0
cleanup
Scotsoo Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import path from 'path';
import { uuid } from 'utils/common';
import find from 'lodash/find';
import map from 'lodash/map';
Expand All @@ -24,8 +23,9 @@ import {
} from 'utils/collections';
import { parseQueryParams, stringifyQueryParams } from 'utils/url';
import { getSubdirectoriesFromRoot, getDirectoryName } from 'utils/common/platform';
import os from 'os';

const PATH_SEPARATOR = path.sep;
const PATH_SEPARATOR = /Windows/i.test(os.release()) ? '\\' : '/';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use isWindows function from utils/common/platform

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


const initialState = {
collections: [],
Expand Down