renaming folder under collection ends up with a phantom folder

[mreiland]

Repro:

1. create a collection named 'test'
2. create a folder named 'inner folder' inside the test collection
3. create a request named 'google' inside the folder named 'inner folder'
4. select the 'elipses' menu next to the folder and select rename
5. rename to 'inner folder (renamed)
6. observe there are now two folders, 1 named 'inner folder' with nothing in it and 1 named 'inner folder (renamed)' with the 'google' request in it.
7. you will not be able to interact with the 'inner folder' in any way.
8. close and restart bruno and the 'inner folder' goes away.

see attached screenshot for evidence.

[helloanoop]

Hi @mreiland

The rename works fine on my machine. I am using Mac x64
Can you let me know which OS you are using ?

[AyushNigam-1]

Hey , I am using windows 11 x64 , Same issue is with me.

[helloanoop]

@mreiland This has been fixed by @not-known-person in v0.16.5
You can download the latest version from the website.

Closing this issue. Please re-open if the issues still persists.

[mreiland]

@helloanoop

Apologies for the delay, I'm on Windows 10 and can confirm this is fixed in the latest version of bruno.

Thank you for such a quick response!

[Scotsoo]

I was looking at this last weekend and where I think this fix does indeed fix the issue, I don't think it's the real fix.
I think the real problem is due to path.sep returning the unix / rather than the windows \\ as it's running in a browser environment path.sep gets a bit confused. Meaning that the context doesn't update using the natural triggers.

See example, this is based on v0.16.5 (pre the fix above) on a windows machine.

PR raised: #465

[helloanoop]

@Scotsoo Just to confirm - what you are you recommending is to apply your fix - #465 (fixing the path) and revert this fix fcc12fb right ?

const PATH_SEPARATOR = path.sep;

console.log('PATH_SEPARATOR', PATH_SEPARATOR);

Can you confirm that by logging the path.sep on top you dev console - you are not seeing \\ while running this on windows?
I was assuming that this would automatically resolve to \\ when being run on windows

[Scotsoo]

Yep, that's correct. I'm not seeing path.sep as \ on windows as it's something to do with the runtime actually running as a browser.
My gif above is recorded on a windows machine