Fixed issue 211 #390
Fixed issue 211 #390
Conversation
fixed failed to load api specification error (unstructuredstudio#363) fixed failed to load api specification error added style to fix text wrap (unstructuredstudio#373) Add hot reloading to media container (unstructuredstudio#382) Add new search features (unstructuredstudio#362) * Finish creators and projects search migration * Finish creators and projects search migration * Add tag search * Add search for projects with tags * Fix search bar on mobile * use 0 rather than 0 with units in css * Remove print * Default search type to projects * Disable scroll lock Revert package-lock (unstructuredstudio#383) improveConsistency: fixed title text small, extra vertical space ... (unstructuredstudio#369) * improveConsistency: fixed title text small, extra vertical space and inconsitent padding of buttons fix text overflow issue in signup page phone number field (unstructuredstudio#378) removed spacing between icons
alicendeh
requested review from
NdibeRaymond,
tuxology and
ajain1921
as code owners
|
Here @NdibeRaymond. I closed the other PR and opened this one. Please have a look |
|
Thanks @alicendeh . The Clap-bookmark-views "button" does not look ok still since its all squashed together on the left while there is empty space on right. I have some ideas to really make this way better. It would go a bit out of scope of #211 's requirements. So for now, essentially we could just right align the complete button (containing all 3 elements) and reduce width so that it looks more balanced. Also introduce a bit of padding between text and the icon as well. This will do for now and we can improve this in another iteration. |
|
@alicendeh when you upload the patch for @tuxology 's review we will merge this. |
Got it. Working on that. |
okay, @NdibeRaymond. I was working on the mobile section so I couldn't modify this the other day. But am on it now. |
|
Hello @tuxology and @NdibeRaymond. I did the necessary corrections requested.
OUTPUT
|
|
This looks better. We are almost there! Can we remove full width of the "clap-bookmark-views" element and just have it enough to cover the 3 "buttons" (and the whole button remains aligned right as well)? |
Please @tuxology am a little lostZ |
|
@alicendeh We do something like this for now
This design will eventually change in a few months as we optimize the position of these elements, but for now, this will help! |
|
Alright, I see now, Thanks. |
|
Hello @tuxology I have done the change you requested OUTPUT |
|
Hello @tuxology please you havent responded to this yet |
|
Hello @tuxology the content of the package-lock.json is same as whats currently on the repo |
|
@alicendeh Looks like there is a difference (https://github.com/unstructuredstudio/zubhub/pull/390/files#diff-1e460fd2de8f7f6c83ff9c821068937ff5f1be7769d2ec1679a1280f19d8263a). Did you update your |
|
@tuxology please have a look now |
|
@alicendeh @tuxology It seems like this PR adds the ability to select multiple categories on the Create Project Form. I believe it's leading to Issue #424. Is this a feature we want? For now, I'm going to remove the multiple category addition to fix the issue and maybe discuss if this is something we want in the future. |
|
@ajain1921 I think yes, you are right. I merged too soon. This has some stale code from the other category issue (possibly should have been included in #395) that we decided not to merge. Thanks for removing he multiple category code that got included in this PR. @alicendeh Please take a note for next PRs that they should not have stale code from other issues. A general approach is to always create separate feature branched from the main |
|
Noted @tuxology thqnks. This won't happen again |
Summary
Realigned buttons in project page and reduced vertical spacing between clab,bookmark,view button row and photos div
Changes
Screenshots