fixed uneven padding / spacing between icons on the video's button bar, more visible when the bar becomes horizontal. #409
Conversation
godsakani
requested review from
NdibeRaymond,
tuxology and
ajain1921
as code owners
There was a problem hiding this comment.
@godsakani Thanks 🙏 There are conflicts since some styles have been already updated as part of #390. Make sure you keep the styles of the right alignment of horizontal bar and the spacing between the text and icon. The spacing also is very close to what was fixed in #390 so there are many overlaps in this PR. There could be very few improvements still (the left padding is not same as right padding for example I think).
In addition, we need to change icon order, but this is a larger UX improvement. I recommend you propose better UX than what is already there. Some ideas are: moving the bookmark as a separate button on far right, changing the background of "views" since it is a non-interactive element and its confusing to group them in same container etc. So all this needs some fresh ideas.
Ok @tuxology thanks for the review and correction. |
|
I suggest we close this PR. If you feel there could be new improvements that can be done to existing UI, we can keep it open. Let me know! |
@tuxology Is ok if we close the PR. Because alicendeh already did the improvement as you requested. |
Summary
Fix #173
Closes #173
I changed the display to inline-flex, I gave a flex direction to column and align the items to left using justify-content which help fix the mobile horizontal view. Also for the desktop view I gave a padding-right and also height to align the contents.
Changes
Screenshots