fix proto type

[chronark]

The js proto types are completely wrong, so I had to roll my own, and that broke it
now it's fixed

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
dashboard	Ready	Preview, Comment	Feb 19, 2026 5:53pm
engineering	Ready	Preview, Comment	Feb 19, 2026 5:53pm

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes introduce a new SentinelConfig type definition and refactor Sentinel configuration property access patterns across multiple files, replacing the nested policy.config.value.keySpaceIds structure with a flatter policy.keyauth.keySpaceIds approach.

Changes

Cohort / File(s)	Summary
Sentinel Config Type Definition web/apps/dashboard/lib/trpc/routers/deploy/environment-settings/sentinel/update-middleware.ts	Introduces new exported SentinelConfig type with policies array structure, replacing inline anonymous type usage in updateMiddleware.
Sentinel Config Type Usage web/apps/dashboard/lib/trpc/routers/deploy/environment-settings/get.ts, web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/sentinel-settings/keyspaces.tsx	Updates type assertions and property access patterns to use SentinelConfig type and access keyauth.keySpaceIds instead of config.value.keySpaceIds.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is minimal and lacks required sections from the template including issue reference, type of change checkbox, testing instructions, and required checklist items.	Add issue number, select appropriate change type checkboxes, describe testing steps, and complete the required checklist to follow the repository's contribution guidelines.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix proto type' is concise and directly relates to the primary change—fixing protocol type definitions that were previously incorrect.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-proto-type

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

web/apps/dashboard/lib/trpc/routers/deploy/environment-settings/sentinel/update-middleware.ts (1)

52-57: ⚠️ Potential issue | 🔴 Critical

Hardcoded keySpaceIds ignores validated input.

The code validates input.keyspaceIds (lines 29-50) but then discards it and hardcodes ["ks_NNh4XwVsZiwG"]. This means user-selected keyspaces are never persisted—likely a copy-paste artifact or debug leftover.

🐛 Proposed fix

       sentinelConfig.policies.push({
         id: "keyauth-policy",
         name: "API Key Auth",
         enabled: true,
-        keyauth: { keySpaceIds: ["ks_NNh4XwVsZiwG"] },
+        keyauth: { keySpaceIds: input.keyspaceIds },
       });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@web/apps/dashboard/lib/trpc/routers/deploy/environment-settings/sentinel/update-middleware.ts`
around lines 52 - 57, Replace the hardcoded keySpaceIds in the API Key Auth
policy with the validated input value so user-selected keyspaces are persisted:
inside the block that pushes to sentinelConfig.policies (the object with id
"keyauth-policy" and name "API Key Auth"), set keyauth.keySpaceIds to the
validated input (input.keyspaceIds) rather than the literal ["ks_NNh4XwVsZiwG"];
keep the existing validation logic around input.keyspaceIds (lines ~29-50) and
ensure the pushed policy uses that validated array.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@web/apps/dashboard/lib/trpc/routers/deploy/environment-settings/get.ts`:
- Around line 30-34: The current code unsafely casts parsed JSON to
SentinelConfig using "as SentinelConfig"; replace this with runtime validation:
define a Zod schema (e.g., sentinelConfigSchema) matching SentinelConfig and use
sentinelConfigSchema.parse(JSON.parse(Buffer.from(runtimeSettings.sentinelConfig).toString()))
to produce a validated SentinelConfig, returning undefined when
runtimeSettings.sentinelConfig is falsy or catching/handling parse errors;
update the field construction that references sentinelConfig and
runtimeSettings.sentinelConfig to use the validated result instead of the type
assertion.

---

Outside diff comments:
In
`@web/apps/dashboard/lib/trpc/routers/deploy/environment-settings/sentinel/update-middleware.ts`:
- Around line 52-57: Replace the hardcoded keySpaceIds in the API Key Auth
policy with the validated input value so user-selected keyspaces are persisted:
inside the block that pushes to sentinelConfig.policies (the object with id
"keyauth-policy" and name "API Key Auth"), set keyauth.keySpaceIds to the
validated input (input.keyspaceIds) rather than the literal ["ks_NNh4XwVsZiwG"];
keep the existing validation logic around input.keyspaceIds (lines ~29-50) and
ensure the pushed policy uses that validated array.