fix: domain refetch and promotion disable rule

[ogzhanolguncu]

What does this PR do?

This PR fixes invalidation issue of domain list when we make new deploys. Also, "Promotion" and "Rollback" was cancelled due to wrong "liveDeployment" data.

How should this be tested?

• Run make dev
• Run go run . dev seed local
• Run

go run . dev github trigger-webhook \                                                                                                                                                                                                         
--project-id proj_xxx \
--repository ogzhanolguncu/demo_api \
--commit-sha ab364086945db3271aee15d35444b2cfc2da04a7

• Make sure domains reappear after a refresh
• Make sure you can rollback and promote

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
dashboard	Ready	Preview, Comment	Feb 12, 2026 5:19pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
engineering	Ignored	Preview	Feb 12, 2026 5:19pm

[coderabbitai]

📝 Walkthrough

Walkthrough

Defers the initial domains query until project data is available, adds a project-scoped liveDeployment resolution for deployment actions, and adjusts UI behavior for custom domain delete visibility and env-variables header/add controls.

Changes

Cohort / File(s)	Summary
Data Provider & Core Logic web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/data-provider.tsx	Moved domainsQuery declaration after projectQuery, introduced module-scope project derived from projectQuery.data?.at(0), added useEffect to refetch domains when project.liveDeploymentId changes, and updated memo dependencies to include projectQuery, domainsQuery, deploymentsQuery, and environmentsQuery.
Deployment Status web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/components/table/deployments-list.tsx	Changed resolution of the live deployment used for action column to derive from project?.liveDeploymentId (via getDeploymentById) rather than per-row deployment.id; isLive remains compared against the project's liveDeploymentId.
Domain Management UI web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/details/custom-domains-section/custom-domain-row.tsx	Removed opacity-based hover reveal from the delete Button, making the delete control visible at all times while keeping hover text color styling.
Environment Variables UI web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/details/env-variables-section/add-env-vars.tsx, web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/details/env-variables-section/index.tsx	Deleted an extraneous trailing whitespace text node after the Trash button; replaced single header expand button with a small control group adding a conditional Plus button that starts the add-new-variable flow (and expands if needed) alongside the existing ChevronDown toggle.
Misc / Manifests manifest_file, package.json	Small manifest/package adjustments (minor lines changed).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description provides a clear summary of fixes and includes testing steps, but lacks issue reference, type of change checkbox, and several required checklist items.	Add 'Fixes #' issue reference, mark the change type (Bug fix), and complete required checklist items (self-review, build/format checks, console.logs removed, latest main merged).

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: domain refetch and promotion disable rule' directly aligns with the PR's objectives: fixing domain list invalidation on new deploys and correcting liveDeployment data for promotion/rollback actions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-domain-refetch-and-promotion

---

No actionable comments were generated in the recent review. 🎉

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In
`@web/apps/dashboard/app/`(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/components/table/deployments-list.tsx:
- Around line 295-297: The memoized columns capture a stale getDeploymentById
closure because columns is only memoized on [selectedDeploymentId, project];
update the memo to include getDeploymentById in its dependency array so render
functions always see the latest deployment lookup, or alternatively compute
liveDeployment with a separate useMemo that depends on project?.liveDeploymentId
and getDeploymentById (so the lookup runs when deployments change) and then use
that fresh liveDeployment inside columns; reference the symbols columns,
getDeploymentById, liveDeployment, selectedDeploymentId, and project when making
the change.

In
`@web/apps/dashboard/app/`(app)/[workspaceSlug]/projects/[projectId]/(overview)/details/env-variables-section/index.tsx:
- Around line 68-96: The icon-only Buttons rendered around the Plus and
ChevronDown lack accessible names; add aria-label props to both Button
components so screen readers can announce their actions (e.g., on the Plus
Button add aria-label="Add environment variable" and on the ChevronDown Button
add aria-label="Toggle environment variables"). Keep the existing onClick
handlers (startAdding, toggleExpanded) and visual behavior (isExpanded,
setIsExpanded, cn) unchanged; if you prefer visible tooltips, also set title to
the same string to provide hover text.