chore: upgrade builderd's go version to latest#3929
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughUpdated Go toolchain version in a single go.mod file from 1.24.4 to 1.25.1. No other configuration or code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
go/deploy/builderd/go.mod(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Test Go API Local / Test
- GitHub Check: Test API / API Test Local
- GitHub Check: Build / Build
- GitHub Check: Test Packages / Test
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
go/deploy/builderd/go.mod (1)
3-3: LGTM: go directive bumped to Go 1.25.1 (current).
go 1.25.1is valid in go.mod and will direct toolchain selection appropriately (Go ≥1.21). Go 1.25 shipped in August 2025 and 1.25.1 was released on September 3, 2025. Looks good. (go.dev, groups.google.com)
| module github.com/unkeyed/unkey/go/deploy/builderd | ||
|
|
||
| go 1.24.4 | ||
| go 1.25.1 |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Run tidy with the new language version.
After bumping, run in this module to refresh metadata as needed:
(cd go/deploy/builderd && go mod tidy -go=1.25)🤖 Prompt for AI Agents
In go/deploy/builderd/go.mod around line 3, the Go version was bumped to 1.25.1
but module metadata wasn’t refreshed; run the tidy command in that module to
update go.sum and module metadata: execute (cd go/deploy/builderd && go mod tidy
-go=1.25), verify go.sum changes, and commit the updated go.mod/go.sum.
💡 Verification agent
🧩 Analysis chain
Verify CI/tooling pick up 1.25.1 automatically.
Ensure:
- CI (e.g., actions/setup-go) uses go-version-file or a semver that resolves to 1.25.x.
- Local/distro toolchains (Dockerfiles, Makefiles, build images) aren’t pinned to older 1.24.x.
Run this to audit the repo for potential mismatches:
🏁 Script executed:
#!/bin/bash
# From repo root
echo "== go directives in all modules =="
rg -nP '^\s*go\s+1\.\d+(\.\d+)?\b' -g '*go.mod' -S -C0
echo -e "\n== toolchain directives (if any) =="
rg -nP '^\s*toolchain\s+go1\.\d+(\.\d+)?\b' -g '*go.mod' -S -C0
echo -e "\n== GH Actions: setup-go usage =="
rg -nP -C2 'uses:\s*actions/setup-go' .github/workflows \
&& rg -nP -C1 'go-version-file|go-version' .github/workflows
echo -e "\n== Dockerfiles referencing golang images =="
fd -t f -H 'Dockerfile*' | xargs -I{} rg -n 'golang:' -n {}Length of output: 1621
Update CI and Dockerfiles to Go 1.25.x
- CI: the
autofix.ci.yamlworkflow usesgo-version-file: ./go/go.mod(which pins Go 1.24.4), so it won’t pick up thego 1.25.1directive ingo/deploy/builderd/go.mod. Point the action at the correct module file or use a semvergo-version: '1.25.x'. - Dockerfiles: every
FROM golang:1.24[-alpine]needs to be bumped togolang:1.25[-alpine]to match the new module Go versions.
🤖 Prompt for AI Agents
In go/deploy/builderd/go.mod around line 3, the project file specifies "go
1.25.1" but CI and Dockerfiles still pin Go 1.24; update the CI workflow to
reference the correct module (change go-version-file to point at
./go/deploy/builderd/go.mod) or set go-version to a semver like '1.25.x', and
update all Dockerfiles that use FROM golang:1.24 or golang:1.24-alpine to use
golang:1.25 or golang:1.25-alpine so the runtime/build images match the module
Go directive.
chronark
deleted the
09-08-chore_upgrade_builderd_s_go_version_to_latest
branch
2 participants
What does this PR do?
Fixes # (issue)
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists
Type of change
How should this be tested?
Checklist
Required
pnpm buildpnpm fmtconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit