Skip to content

chore: upgrade builderd's go version to latest #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chronark merged 3 commits into from
Sep 9, 2025
Merged

chore: upgrade builderd's go version to latest #3929

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e9c5b8
chore: Remove tenancy/environment/project IDs if there are any
chronark Sep 8, 2025
8e27beb
chore: upgrade builderd's go version to latest
chronark Sep 8, 2025
f0f2002
Merge branch 'main' into 09-08-chore_upgrade_builderd_s_go_version_to…
Flo4604 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/deploy/builderd/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/unkeyed/unkey/go/deploy/builderd

go 1.24.4
go 1.25.1
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Run tidy with the new language version.

After bumping, run in this module to refresh metadata as needed:

(cd go/deploy/builderd && go mod tidy -go=1.25)
🤖 Prompt for AI Agents 
In go/deploy/builderd/go.mod around line 3, the Go version was bumped to 1.25.1
but module metadata wasn’t refreshed; run the tidy command in that module to
update go.sum and module metadata: execute (cd go/deploy/builderd && go mod tidy
-go=1.25), verify go.sum changes, and commit the updated go.mod/go.sum.

💡 Verification agent

🧩 Analysis chain

Verify CI/tooling pick up 1.25.1 automatically.

Ensure:

  • CI (e.g., actions/setup-go) uses go-version-file or a semver that resolves to 1.25.x.
  • Local/distro toolchains (Dockerfiles, Makefiles, build images) aren’t pinned to older 1.24.x.

Run this to audit the repo for potential mismatches:

🏁 Script executed:

#!/bin/bash
# From repo root

echo "== go directives in all modules =="
rg -nP '^\s*go\s+1\.\d+(\.\d+)?\b' -g '*go.mod' -S -C0

echo -e "\n== toolchain directives (if any) =="
rg -nP '^\s*toolchain\s+go1\.\d+(\.\d+)?\b' -g '*go.mod' -S -C0

echo -e "\n== GH Actions: setup-go usage =="
rg -nP -C2 'uses:\s*actions/setup-go' .github/workflows \
  && rg -nP -C1 'go-version-file|go-version' .github/workflows

echo -e "\n== Dockerfiles referencing golang images =="
fd -t f -H 'Dockerfile*' | xargs -I{} rg -n 'golang:' -n {}

Length of output: 1621

Update CI and Dockerfiles to Go 1.25.x

  • CI: the autofix.ci.yaml workflow uses go-version-file: ./go/go.mod (which pins Go 1.24.4), so it won’t pick up the go 1.25.1 directive in go/deploy/builderd/go.mod. Point the action at the correct module file or use a semver go-version: '1.25.x'.
  • Dockerfiles: every FROM golang:1.24[-alpine] needs to be bumped to golang:1.25[-alpine] to match the new module Go versions.
🤖 Prompt for AI Agents 
In go/deploy/builderd/go.mod around line 3, the project file specifies "go
1.25.1" but CI and Dockerfiles still pin Go 1.24; update the CI workflow to
reference the correct module (change go-version-file to point at
./go/deploy/builderd/go.mod) or set go-version to a semver like '1.25.x', and
update all Dockerfiles that use FROM golang:1.24 or golang:1.24-alpine to use
golang:1.25 or golang:1.25-alpine so the runtime/build images match the module
Go directive.


require (
connectrpc.com/connect v1.18.1
Expand Down