Skip to content

feat: use spire for tls#3496

Merged
chronark merged 4 commits intomainfrom
07-09-feat_use_spire_for_tls
Jul 11, 2025
Merged

feat: use spire for tls#3496
chronark merged 4 commits intomainfrom
07-09-feat_use_spire_for_tls

Conversation

@chronark
Copy link
Collaborator

@chronark chronark commented Jul 9, 2025 •
edited
Loading

What does this PR do?

Add configuration options for Metald service and SPIFFE authentication to the control plane.

This PR adds two new configuration fields to the Config struct:

  • MetaldAddress: Specifies the full URL of the metald service for VM operations
  • SPIFFESocketPath: Defines the path to the SPIFFE agent socket for mTLS authentication

Fixes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Verify that the control plane can be configured with the new MetaldAddress and SPIFFESocketPath options
  • Confirm that when these options are set, the control plane can properly connect to the metald service using SPIFFE authentication

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2bbc1ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2025 7:47am
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2025 7:47am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 9, 2025 •
edited
Loading

Warning

Rate limit exceeded

@chronark has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 08c655f and 2bbc1ec.

📒 Files selected for processing (1)
  • go/apps/ctrl/config.go (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chronark chronark mentioned this pull request Jul 9, 2025
Merged
18 tasks
@chronark Graphite App
Copy link
Collaborator Author

chronark commented Jul 9, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chronark chronark mentioned this pull request Jul 9, 2025
Merged
18 tasks
@vercel vercel bot temporarily deployed to Preview – engineering July 9, 2025 11:55 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard July 9, 2025 11:55 Inactive
This was referenced Jul 9, 2025
Merged
Merged
Merged
@chronark chronark marked this pull request as ready for review July 11, 2025 07:43
Base automatically changed from 07-09-feat_workflow_calls_metald_to_create_and_boot_a_vm to main July 11, 2025 07:44
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@chronark chronark merged commit 46eef29 into main Jul 11, 2025
20 of 23 checks passed
@chronark chronark deleted the 07-09-feat_use_spire_for_tls branch July 11, 2025 07:44
@vercel vercel bot temporarily deployed to Preview – engineering July 11, 2025 07:47 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard July 11, 2025 07:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perkinsjr perkinsjr Awaiting requested review from perkinsjr perkinsjr is a code owner

@imeyer imeyer Awaiting requested review from imeyer imeyer is a code owner

@Flo4604 Flo4604 Awaiting requested review from Flo4604 Flo4604 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chronark