feat: workflow calls metald to create and boot a vm by chronark · Pull Request #3495 · unkeyed/unkey

chronark · 2025-07-09T11:55:01Z

What does this PR do?

Integrate VM provisioning into the deployment workflow. This PR adds the ability to create, check, and boot VMs as part of the deployment process using the metald client. It also refactors the build status polling logic to be more robust and structured.

Fixes #(issue)

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

Test the deployment workflow with a valid Docker image to verify VM creation and boot
Verify build status polling works correctly with different build states
Test error handling when VM creation or boot fails
Verify the workflow correctly updates version and build statuses in the database

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

New Features
- Added automated virtual machine provisioning and booting as part of the deployment process, including detailed status checks and readiness polling.
Improvements
- Enhanced build status polling with clearer logging and more robust error handling.
- Deployment status updates are now more precise, reducing redundant database writes and improving reliability.

vercel · 2025-07-09T11:55:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 11, 2025 7:46am
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 11, 2025 7:46am

changeset-bot · 2025-07-09T11:55:07Z

⚠️ No Changeset found

Latest commit: 0dbc2b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-07-09T11:55:08Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd3dac2 and 0dbc2b1.

📒 Files selected for processing (2)

go/apps/ctrl/run.go (1 hunks)
go/apps/ctrl/services/version/deploy_workflow.go (5 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

chronark · 2025-07-09T11:55:18Z

chore: formatting and linting #3514
feat: finish demo #3502
chore: remove old protos #3497
feat: use spire for tls #3496
feat: workflow calls metald to create and boot a vm #3495 👈 (View in Graphite)
chore: move vmprovisioner protos to shared proto #3494
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

…nd_boot_a_vm

github-actions · 2025-07-11T07:44:04Z

Thank you for following the naming conventions for pull request titles! 🙏

chronark added 2 commits July 9, 2025 11:14

chore: move vmprovisioner protos to shared protochore

2af1b10

feat: workflow calls metald to create and boot a vm

0de77f5

This was referenced Jul 9, 2025

chore: move vmprovisioner protos to shared proto #3494

Merged

feat: use spire for tls #3496

Merged

vercel bot temporarily deployed to Preview – engineering July 9, 2025 11:57 Inactive

vercel bot temporarily deployed to Preview – dashboard July 9, 2025 11:57 Inactive

This was referenced Jul 9, 2025

chore: remove old protos #3497

Merged

feat: finish demo #3502

Merged

chore: formatting and linting #3514

Merged

chronark marked this pull request as ready for review July 11, 2025 07:42

chronark requested review from Flo4604, imeyer and perkinsjr as code owners July 11, 2025 07:42

Base automatically changed from 07-09-chore_move_vmprovisioner_protos_to_shared_protochore to main July 11, 2025 07:43

Merge branch 'main' into 07-09-feat_workflow_calls_metald_to_create_a…

0dbc2b1

…nd_boot_a_vm

chronark merged commit 08c655f into main Jul 11, 2025
20 of 23 checks passed

chronark deleted the 07-09-feat_workflow_calls_metald_to_create_and_boot_a_vm branch July 11, 2025 07:44

vercel bot temporarily deployed to Preview – engineering July 11, 2025 07:45 Inactive

vercel bot temporarily deployed to Preview – dashboard July 11, 2025 07:46 Inactive

coderabbitai bot mentioned this pull request Jul 16, 2025

feat: e2e deploy with docker works #3567

Merged

18 tasks

This was referenced Sep 2, 2025

feat: update protos and control plane #3901

Merged

feat(deploy): redesign metald network architecture #3818

Merged

coderabbitai bot mentioned this pull request Sep 10, 2025

feat: spawn in ctrl #3944

Merged

18 tasks

coderabbitai bot mentioned this pull request Sep 28, 2025

refactor: krane, a lightweight k8s service and metald successor #4030

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: workflow calls metald to create and boot a vm#3495

feat: workflow calls metald to create and boot a vm#3495
chronark merged 3 commits intomainfrom
07-09-feat_workflow_calls_metald_to_create_and_boot_a_vm

chronark commented Jul 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jul 9, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jul 9, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 9, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

chronark commented Jul 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

chronark commented Jul 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

chronark commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chronark commented Jul 9, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 9, 2025 •

edited

Loading

changeset-bot bot commented Jul 9, 2025 •

edited

Loading

coderabbitai bot commented Jul 9, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

chronark commented Jul 9, 2025 •

edited

Loading

github-actions bot commented Jul 11, 2025 •

edited

Loading