Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
📝 WalkthroughWalkthroughThe changes update the handling of JSON fields in the database for identities and audit logs. SQL statements and Go struct fields are modified to explicitly cast relevant parameters as JSON and use Changes
Sequence Diagram(s)sequenceDiagram
participant API Handler
participant DB Layer
participant MySQL
API Handler->>DB Layer: Prepare Insert/Update with Meta as json.RawMessage
DB Layer->>MySQL: Execute SQL with CAST(? AS JSON) for meta fields
MySQL-->>DB Layer: Store/retrieve meta as JSON type
DB Layer-->>API Handler: Return operation result
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (22)
🧰 Additional context used🧠 Learnings (14)📓 Common learningsgo/pkg/db/queries/audit_log_insert.sql (1)go/pkg/db/queries/identity_insert.sql (1)go/apps/api/routes/v2_identities_list_identities/cross_workspace_test.go (2)go/apps/api/routes/v2_identities_delete_identity/200_test.go (1)go/apps/api/routes/v2_identities_create_identity/200_test.go (1)go/pkg/db/queries/audit_log_target_insert.sql (1)go/pkg/db/queries/identity_update.sql (1)go/apps/api/routes/v2_identities_create_identity/handler.go (1)go/apps/api/routes/v2_identities_get_identity/200_test.go (1)go/pkg/db/querier_generated.go (1)go/pkg/db/identity_insert.sql_generated.go (1)go/pkg/db/audit_log_target_insert.sql_generated.go (2)go/pkg/db/identity_update.sql_generated.go (1)🧬 Code Graph Analysis (3)go/apps/api/routes/v2_identities_update_identity/403_test.go (1)
go/apps/api/routes/v2_identities_get_identity/404_test.go (1)
go/pkg/db/audit_log_target_insert.sql_generated.go (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
🔇 Additional comments (35)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
Graphite Automations"Post a GIF when PR approved" took an action on this PR • (07/09/25)1 gif was posted to this PR based on Andreas Thomas's automation. |
* refactor: use docker-compose with testcontainerrefactos * feat: get rid of testcontainers and just rawdog docker-compose * feat: onboarding key creation (#3459) * feat: add new expandable configs * feat: add form submit with conditionals * feat: add description for each section and disable form --------- Co-authored-by: James P <james@unkey.dev> * refactor: add minimized load more (#3399) * refactor: add minimized load more * chore: fmt * refactor: get rid of useEffect animation * chore: fmt * chore: llm search moved to ui (#3409) * llm search moved with docs and replaced in dashboard * eng docs change * [autofix.ci] apply automated fixes * minor refactor from c-rabbit * rabbit * [autofix.ci] apply automated fixes * rabbit --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> * fix: calendar bug (#3478) * fix: first time selection * fix: resetting to initial date of the month * fix: date validation issue * fix: day selection by bypassing react-day-picker * feat: return permission slugs (#3481) * chore(release): version packages (#3482) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: add listPermissions and listRoles (#3483) * chore(release): version packages (#3484) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: Initial implementation of Unkey Deploy (#3488) * feat: Initial implementation of Unkey Deploy - Introduce four core services: assetmanagerd, billaged, builderd, metald - Implement VM lifecycle management with Firecracker/Cloud Hypervisor support - Add SPIFFE/SPIRE integration for mTLS inter-service communication - Include systemd service files and CLI tools for each service - Set up observability with OpenTelemetry and Grafana LGTM stack - Implement tenant isolation, resource management, and usage billing Signed-off-by: Ian Meyer <k@imeyer.io> * [autofix.ci] apply automated fixes --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * fix: cast JSON for interpolate params (#3492) * refactor: use docker-compose with testcontainerrefactos * feat: get rid of testcontainers and just rawdog docker-compose --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: Oğuzhan Olguncu <21091016+ogzhanolguncu@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> Co-authored-by: CodeReaper <148160799+MichaelUnkey@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ian Meyer <imeyer@users.noreply.github.com> Co-authored-by: Flo <53355483+Flo4604@users.noreply.github.com>
* feat: get rid of testcontainers and just rawdog docker-compose * feat: onboarding key creation (#3459) * feat: add new expandable configs * feat: add form submit with conditionals * feat: add description for each section and disable form --------- Co-authored-by: James P <james@unkey.dev> * refactor: add minimized load more (#3399) * refactor: add minimized load more * chore: fmt * refactor: get rid of useEffect animation * chore: fmt * chore: llm search moved to ui (#3409) * llm search moved with docs and replaced in dashboard * eng docs change * [autofix.ci] apply automated fixes * minor refactor from c-rabbit * rabbit * [autofix.ci] apply automated fixes * rabbit --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> * fix: calendar bug (#3478) * fix: first time selection * fix: resetting to initial date of the month * fix: date validation issue * fix: day selection by bypassing react-day-picker * feat: return permission slugs (#3481) * chore(release): version packages (#3482) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: add listPermissions and listRoles (#3483) * chore(release): version packages (#3484) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: Initial implementation of Unkey Deploy (#3488) * feat: Initial implementation of Unkey Deploy - Introduce four core services: assetmanagerd, billaged, builderd, metald - Implement VM lifecycle management with Firecracker/Cloud Hypervisor support - Add SPIFFE/SPIRE integration for mTLS inter-service communication - Include systemd service files and CLI tools for each service - Set up observability with OpenTelemetry and Grafana LGTM stack - Implement tenant isolation, resource management, and usage billing Signed-off-by: Ian Meyer <k@imeyer.io> * [autofix.ci] apply automated fixes --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * fix: cast JSON for interpolate params (#3492) * refactor: use docker-compose with testcontainers (#3476) * refactor: use docker-compose with testcontainerrefactos * feat: get rid of testcontainers and just rawdog docker-compose * feat: onboarding key creation (#3459) * feat: add new expandable configs * feat: add form submit with conditionals * feat: add description for each section and disable form --------- Co-authored-by: James P <james@unkey.dev> * refactor: add minimized load more (#3399) * refactor: add minimized load more * chore: fmt * refactor: get rid of useEffect animation * chore: fmt * chore: llm search moved to ui (#3409) * llm search moved with docs and replaced in dashboard * eng docs change * [autofix.ci] apply automated fixes * minor refactor from c-rabbit * rabbit * [autofix.ci] apply automated fixes * rabbit --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> * fix: calendar bug (#3478) * fix: first time selection * fix: resetting to initial date of the month * fix: date validation issue * fix: day selection by bypassing react-day-picker * feat: return permission slugs (#3481) * chore(release): version packages (#3482) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: add listPermissions and listRoles (#3483) * chore(release): version packages (#3484) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: Initial implementation of Unkey Deploy (#3488) * feat: Initial implementation of Unkey Deploy - Introduce four core services: assetmanagerd, billaged, builderd, metald - Implement VM lifecycle management with Firecracker/Cloud Hypervisor support - Add SPIFFE/SPIRE integration for mTLS inter-service communication - Include systemd service files and CLI tools for each service - Set up observability with OpenTelemetry and Grafana LGTM stack - Implement tenant isolation, resource management, and usage billing Signed-off-by: Ian Meyer <k@imeyer.io> * [autofix.ci] apply automated fixes --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * fix: cast JSON for interpolate params (#3492) * refactor: use docker-compose with testcontainerrefactos * feat: get rid of testcontainers and just rawdog docker-compose --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: Oğuzhan Olguncu <21091016+ogzhanolguncu@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> Co-authored-by: CodeReaper <148160799+MichaelUnkey@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ian Meyer <imeyer@users.noreply.github.com> Co-authored-by: Flo <53355483+Flo4604@users.noreply.github.com> * fix: clean up --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: Oğuzhan Olguncu <21091016+ogzhanolguncu@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> Co-authored-by: CodeReaper <148160799+MichaelUnkey@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ian Meyer <imeyer@users.noreply.github.com> Co-authored-by: Flo <53355483+Flo4604@users.noreply.github.com>

What does this PR do?
How should this be tested?
Run tests
Checklist
Required
pnpm buildpnpm fmtconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit
Bug Fixes
Refactor
Tests