Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning Rate limit exceeded@ogzhanolguncu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 18 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes replace framer-motion-based animations with CSS keyframe animations in selection controls, add a collapsible UI state to the loading indicator footer, and introduce two new arrow icon components. The icons are also exported through the main icons index. No public API signatures were altered for existing components. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant LoadMoreFooter
participant UI
User->>LoadMoreFooter: Render component
alt hide prop is true
LoadMoreFooter-->>UI: Render nothing (null)
else isOpen is false
LoadMoreFooter-->>UI: Render minimized button (bottom-right)
User->>LoadMoreFooter: Click maximize
LoadMoreFooter->>UI: Render expanded footer (bottom-center)
else isOpen is true
LoadMoreFooter-->>UI: Render expanded footer (bottom-center)
User->>LoadMoreFooter: Click minimize
LoadMoreFooter->>UI: Render minimized button (bottom-right)
User->>LoadMoreFooter: Click "Load more"
LoadMoreFooter->>UI: Trigger onLoadMore callback
end
Suggested reviewers
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/selection-controls/index.tsx(4 hunks)apps/dashboard/components/virtual-table/components/loading-indicator.tsx(2 hunks)internal/icons/src/icons/arrows-to-all-directions.tsx(1 hunks)internal/icons/src/icons/arrows-to-center.tsx(1 hunks)internal/icons/src/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (9)
internal/icons/src/icons/arrows-to-center.tsx (1)
15-116: Well-implemented icon component following established patterns.The
ArrowsToCentercomponent correctly follows the standard icon component structure with proper prop handling, size mapping, and SVG construction. The geometric elements create a clear visual representation of arrows pointing inward.internal/icons/src/icons/arrows-to-all-directions.tsx (1)
15-116: Consistent implementation with clear visual purpose.The
ArrowsToAllDirectionscomponent properly implements the outward-pointing arrows icon following the same established patterns as other icon components. The SVG geometry correctly represents the intended visual concept.internal/icons/src/index.ts (1)
7-8: Proper export additions maintaining alphabetical order.The new icon exports are correctly placed and follow the established export pattern.
apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/selection-controls/index.tsx (3)
61-63: Cleaner early return logic.The direct
return nullis more straightforward than the previous conditional rendering approach.
67-138: Effective migration from framer-motion to CSS animations.The CSS keyframe animations provide a lightweight alternative to framer-motion while maintaining smooth transitions. The
slideInFromTopandbounceInanimations are well-timed and appropriate for the UI context.
219-231: Simplified counter animation approach.The refactored
AnimatedCounteris cleaner and more performant than the previous digit-by-digit animation approach, while still providing visual feedback for value changes.apps/dashboard/components/virtual-table/components/loading-indicator.tsx (3)
1-1: Appropriate icon usage for the minimize/maximize functionality.The
ArrowsToAllDirectionsandArrowsToCentericons effectively communicate the expand and collapse actions respectively.
31-42: Clean state management for collapsible functionality.The
isOpenstate and toggle handlers are well-implemented with proper use ofuseCallbackfor performance optimization.
158-203: Comprehensive and well-crafted CSS animations.The keyframe animations provide smooth, professional transitions that enhance the user experience. The timing functions and delays are well-balanced for a cohesive feel.
...apiId]/keys/[keyAuthId]/_components/components/table/components/selection-controls/index.tsx
Show resolved
Hide resolved
apps/dashboard/components/virtual-table/components/loading-indicator.tsx
Show resolved
Hide resolved
|
why are we doing this? what problem is this solving? |
|
without minimizing, load more section blocks logs at the bottom |
|
but it still blocks them, just slightly less, right? |
|
it is but much less it used to take entire middle section |
* refactor: use docker-compose with testcontainerrefactos * feat: get rid of testcontainers and just rawdog docker-compose * feat: onboarding key creation (#3459) * feat: add new expandable configs * feat: add form submit with conditionals * feat: add description for each section and disable form --------- Co-authored-by: James P <james@unkey.dev> * refactor: add minimized load more (#3399) * refactor: add minimized load more * chore: fmt * refactor: get rid of useEffect animation * chore: fmt * chore: llm search moved to ui (#3409) * llm search moved with docs and replaced in dashboard * eng docs change * [autofix.ci] apply automated fixes * minor refactor from c-rabbit * rabbit * [autofix.ci] apply automated fixes * rabbit --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> * fix: calendar bug (#3478) * fix: first time selection * fix: resetting to initial date of the month * fix: date validation issue * fix: day selection by bypassing react-day-picker * feat: return permission slugs (#3481) * chore(release): version packages (#3482) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: add listPermissions and listRoles (#3483) * chore(release): version packages (#3484) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: Initial implementation of Unkey Deploy (#3488) * feat: Initial implementation of Unkey Deploy - Introduce four core services: assetmanagerd, billaged, builderd, metald - Implement VM lifecycle management with Firecracker/Cloud Hypervisor support - Add SPIFFE/SPIRE integration for mTLS inter-service communication - Include systemd service files and CLI tools for each service - Set up observability with OpenTelemetry and Grafana LGTM stack - Implement tenant isolation, resource management, and usage billing Signed-off-by: Ian Meyer <k@imeyer.io> * [autofix.ci] apply automated fixes --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * fix: cast JSON for interpolate params (#3492) * refactor: use docker-compose with testcontainerrefactos * feat: get rid of testcontainers and just rawdog docker-compose --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: Oğuzhan Olguncu <21091016+ogzhanolguncu@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> Co-authored-by: CodeReaper <148160799+MichaelUnkey@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ian Meyer <imeyer@users.noreply.github.com> Co-authored-by: Flo <53355483+Flo4604@users.noreply.github.com>
* feat: get rid of testcontainers and just rawdog docker-compose * feat: onboarding key creation (#3459) * feat: add new expandable configs * feat: add form submit with conditionals * feat: add description for each section and disable form --------- Co-authored-by: James P <james@unkey.dev> * refactor: add minimized load more (#3399) * refactor: add minimized load more * chore: fmt * refactor: get rid of useEffect animation * chore: fmt * chore: llm search moved to ui (#3409) * llm search moved with docs and replaced in dashboard * eng docs change * [autofix.ci] apply automated fixes * minor refactor from c-rabbit * rabbit * [autofix.ci] apply automated fixes * rabbit --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> * fix: calendar bug (#3478) * fix: first time selection * fix: resetting to initial date of the month * fix: date validation issue * fix: day selection by bypassing react-day-picker * feat: return permission slugs (#3481) * chore(release): version packages (#3482) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: add listPermissions and listRoles (#3483) * chore(release): version packages (#3484) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: Initial implementation of Unkey Deploy (#3488) * feat: Initial implementation of Unkey Deploy - Introduce four core services: assetmanagerd, billaged, builderd, metald - Implement VM lifecycle management with Firecracker/Cloud Hypervisor support - Add SPIFFE/SPIRE integration for mTLS inter-service communication - Include systemd service files and CLI tools for each service - Set up observability with OpenTelemetry and Grafana LGTM stack - Implement tenant isolation, resource management, and usage billing Signed-off-by: Ian Meyer <k@imeyer.io> * [autofix.ci] apply automated fixes --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * fix: cast JSON for interpolate params (#3492) * refactor: use docker-compose with testcontainers (#3476) * refactor: use docker-compose with testcontainerrefactos * feat: get rid of testcontainers and just rawdog docker-compose * feat: onboarding key creation (#3459) * feat: add new expandable configs * feat: add form submit with conditionals * feat: add description for each section and disable form --------- Co-authored-by: James P <james@unkey.dev> * refactor: add minimized load more (#3399) * refactor: add minimized load more * chore: fmt * refactor: get rid of useEffect animation * chore: fmt * chore: llm search moved to ui (#3409) * llm search moved with docs and replaced in dashboard * eng docs change * [autofix.ci] apply automated fixes * minor refactor from c-rabbit * rabbit * [autofix.ci] apply automated fixes * rabbit --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> * fix: calendar bug (#3478) * fix: first time selection * fix: resetting to initial date of the month * fix: date validation issue * fix: day selection by bypassing react-day-picker * feat: return permission slugs (#3481) * chore(release): version packages (#3482) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: add listPermissions and listRoles (#3483) * chore(release): version packages (#3484) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: Initial implementation of Unkey Deploy (#3488) * feat: Initial implementation of Unkey Deploy - Introduce four core services: assetmanagerd, billaged, builderd, metald - Implement VM lifecycle management with Firecracker/Cloud Hypervisor support - Add SPIFFE/SPIRE integration for mTLS inter-service communication - Include systemd service files and CLI tools for each service - Set up observability with OpenTelemetry and Grafana LGTM stack - Implement tenant isolation, resource management, and usage billing Signed-off-by: Ian Meyer <k@imeyer.io> * [autofix.ci] apply automated fixes --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * fix: cast JSON for interpolate params (#3492) * refactor: use docker-compose with testcontainerrefactos * feat: get rid of testcontainers and just rawdog docker-compose --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: Oğuzhan Olguncu <21091016+ogzhanolguncu@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> Co-authored-by: CodeReaper <148160799+MichaelUnkey@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ian Meyer <imeyer@users.noreply.github.com> Co-authored-by: Flo <53355483+Flo4604@users.noreply.github.com> * fix: clean up --------- Signed-off-by: Ian Meyer <k@imeyer.io> Co-authored-by: Oğuzhan Olguncu <21091016+ogzhanolguncu@users.noreply.github.com> Co-authored-by: James P <james@unkey.dev> Co-authored-by: CodeReaper <148160799+MichaelUnkey@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ian Meyer <imeyer@users.noreply.github.com> Co-authored-by: Flo <53355483+Flo4604@users.noreply.github.com>
What does this PR do?
This PR:
iconspackage.Fixes # (issue)
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists
Type of change
How should this be tested?
Checklist
Required
pnpm buildpnpm fmtconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit
New Features
Style