chore: Dialog container into UI keys and API dialog

[MichaelUnkey]

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How should this be tested?

Dialogs look the same as production and function correctly

Checklist

Required

• Filled out the "How to test" section in this PR
• Read Contributing Guide
• Self-reviewed my own code
• Commented on my code in hard-to-understand areas
• Ran pnpm build
• Ran pnpm fmt
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

• Refactor
  • Consolidated the source of dialog and button components to a single external UI library for a more consistent and maintainable user interface experience. No visible changes to functionality or behavior.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6e1f101

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
dashboard	⬜️ Ignored (Inspect)	Visit Preview		Jun 5, 2025 1:54pm
engineering	⬜️ Ignored (Inspect)	Visit Preview		Jun 5, 2025 1:54pm

[coderabbitai]

📝 Walkthrough

Walkthrough

This change updates all imports of the DialogContainer component in the dashboard app to use the external @unkey/ui package instead of a local implementation. The change consolidates UI component imports but does not alter any logic, functionality, or component usage.

Changes

File(s)	Change Summary
.../api-id-navbar.tsx	Changed dynamic import of DialogContainer from local to @unkey/ui package.
.../delete-key.tsx .../disable-key.tsx .../edit-credits/index.tsx .../edit-expiration/index.tsx .../edit-external-id/index.tsx .../edit-key-name.tsx .../edit-metadata/index.tsx .../edit-ratelimits/index.tsx	Replaced local import of DialogContainer with import from @unkey/ui package.
.../batch-edit-external-id.tsx	Changed DialogContainer import from local to @unkey/ui alongside Button.
.../delete-api.tsx .../delete-protection.tsx	Consolidated DialogContainer import with other UI components from @unkey/ui instead of local.

Sequence Diagram(s)

sequenceDiagram
    participant Component
    participant @unkey/ui

    Component->>@unkey/ui: Import DialogContainer
    Note right of @unkey/ui: DialogContainer provided by external UI library

Loading

Possibly related PRs

• chore: copy button with doc #3261: Consolidates the import source of CopyButton from a local path to @unkey/ui, similar to this PR's approach for DialogContainer.
• chore: Dialog container into UI step 1 #3294: Refactors dialog-related components, including DialogContainer, to be imported from @unkey/ui instead of local paths.

Suggested reviewers

• perkinsjr
• chronark
• mcstepp
• ogzhanolguncu

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c2d7e75 and 6e1f101.

📒 Files selected for processing (12)

• apps/dashboard/app/(app)/apis/[apiId]/api-id-navbar.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/delete-key.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/disable-key.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-credits/index.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-expiration/index.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-external-id/index.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-key-name.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-metadata/index.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-ratelimits/index.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/selection-controls/components/batch-edit-external-id.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/settings/components/delete-api.tsx (1 hunks)
• apps/dashboard/app/(app)/apis/[apiId]/settings/components/delete-protection.tsx (1 hunks)

🔇 Additional comments (12)

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-external-id/index.tsx (1)

4-4:

Details

❓ Verification inconclusive

LGTM: Import consolidation successful.

The import consolidation from local components to @unkey/ui package is clean and aligns with the PR objectives. The DialogContainer usage remains unchanged, indicating API compatibility.

Let me verify that the DialogContainer API from @unkey/ui is compatible with the local implementation:

---

🏁 Script executed:

#!/bin/bash
# Description: Verify DialogContainer API compatibility between local and @unkey/ui implementations

# Check if DialogContainer is properly exported from @unkey/ui
rg -A 10 "export.*DialogContainer" --type typescript

# Find the local DialogContainer implementation to compare API
fd "dialog-container" --type f --extension tsx --extension ts | head -5 | xargs cat

# Check for any TypeScript errors related to DialogContainer usage
echo "Checking for DialogContainer prop usage patterns..."
rg "DialogContainer" -A 5 -B 2 --type typescript

Length of output: 6074

---

Manual Verification Needed: Confirm DialogContainer API Consistency

The automated search didn’t produce definitive results—ripgrep reported an unrecognized file type, and no exports for DialogContainer were located in @unkey/ui. Please manually verify that the DialogContainer you’re importing from @unkey/ui exposes the same props and behavior as the local implementation:

• Props to confirm:
  • isOpen: boolean
  • onOpenChange: (open: boolean) => void
  • title: string
  • subTitle?: string
  • footer?: ReactNode
  • contentClassName?: string
  • preventAutoFocus?: boolean (default true)
• Ensure there are no breaking changes in:
  • The DialogContent wrapper (CSS/API)
  • The focus prevention logic (onOpenAutoFocus)
  • Header, content area, and footer slots

Once you’ve checked the @unkey/ui package source (e.g., in packages/ui or libs/ui), confirm that its DialogContainer export matches the above API.

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-metadata/index.tsx (1)

9-9: LGTM: Consistent import consolidation.

The import change follows the same pattern as other files in this refactor, consolidating DialogContainer import to @unkey/ui. No functional changes detected.

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/disable-key.tsx (1)

5-5: LGTM: Comprehensive UI component consolidation.

The import consolidation includes both DialogContainer and FormCheckbox from @unkey/ui, demonstrating a comprehensive approach to UI component unification.

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-expiration/index.tsx (1)

9-9: LGTM: Refactoring completion successful.

The final import consolidation completes the DialogContainer refactoring across all reviewed components. The changes are consistent and maintain functional compatibility.

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-credits/index.tsx (1)

11-11: Consolidated UI imports
Switching DialogContainer and Button to come from @unkey/ui matches the refactor scope and covers all usages in this component.

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-ratelimits/index.tsx (1)

9-9: Unified component import
Importing Button and DialogContainer from @unkey/ui aligns with the new import strategy and satisfies the component’s requirements.

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/edit-key-name.tsx (1)

5-5: Updated import from external UI library
Bringing in Button, DialogContainer, and FormInput from @unkey/ui standardizes the imports and matches the component’s usage.

apps/dashboard/app/(app)/apis/[apiId]/settings/components/delete-api.tsx (1)

7-7: Standardized UI import statement
Consolidating Button, DialogContainer, Input, and SettingCard under @unkey/ui is consistent with the refactor and supports all usages here.

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/components/delete-key.tsx (1)

5-5: Consolidated component imports
Moving Button, DialogContainer, and FormCheckbox to @unkey/ui ensures consistency and covers the component’s UI needs.

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/selection-controls/components/batch-edit-external-id.tsx (1)

4-4: LGTM! Clean import consolidation.

The DialogContainer import has been successfully moved from the local components directory to the @unkey/ui package, maintaining the same grouped import pattern with Button. The component usage remains unchanged, confirming API compatibility.

apps/dashboard/app/(app)/apis/[apiId]/api-id-navbar.tsx (1)

30-32: LGTM! Dynamic import source updated correctly.

The DialogContainer dynamic import has been properly updated to use the @unkey/ui package while preserving the ssr: false configuration. The component usage remains unchanged, ensuring no functional impact.

apps/dashboard/app/(app)/apis/[apiId]/settings/components/delete-protection.tsx (1)

6-6: LGTM! Excellent import consolidation.

DialogContainer has been successfully consolidated into the grouped @unkey/ui import alongside other UI components (Button, InlineLink, Input, SettingCard). This improves import organization and aligns with the refactoring objective.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[ogzhanolguncu]

Why don't I see the preview links 🤔

[perkinsjr]

It’s there, they only show up the first time now versus every single commit

[ogzhanolguncu]

Good to go