Conversation
MichaelUnkey
requested review from
chronark,
mcstepp,
ogzhanolguncu and
perkinsjr
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe changes update all usages of the Changes
Sequence Diagram(s)sequenceDiagram
participant AppComponent
participant @unkey/ui.CopyButton
participant Clipboard
AppComponent->>@unkey/ui.CopyButton: Render with value to copy
AppComponent->>@unkey/ui.CopyButton: User clicks button
@unkey/ui.CopyButton->>Clipboard: Copy value to clipboard
@unkey/ui.CopyButton-->>AppComponent: Show feedback (icon change)
Note right of @unkey/ui.CopyButton: Icon resets after 2 seconds
Possibly related PRs
Suggested labels
Suggested reviewers
Tip ⚡️ Free AI Code Reviews for VS Code, Cursor, Windsurf
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/engineering/content/design/components/copy-button.mdx (2)
9-16: Feature list could include analytics tracking.Consider adding an item such as:
- Analytics tracking via the optional
srcprop
This highlights the purpose ofsrcfor telemetry.
31-38: Behavior documentation is thorough.Steps cover copy action, icon state transitions, and event suppression. Optionally, note that providing
srcwill emit an analytics event if implemented.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (17)
apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/components/key-created-success-dialog.tsx(1 hunks)apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/components/secret-key.tsx(1 hunks)apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/hooks/use-fetch-identities/create-identity-options.tsx(1 hunks)apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/[keyId]/settings/page.tsx(1 hunks)apps/dashboard/app/(app)/authorization/roles/[roleId]/tree.tsx(1 hunks)apps/dashboard/app/(app)/identities/[identityId]/page.tsx(1 hunks)apps/dashboard/app/(app)/ratelimits/_components/ratelimit-client.tsx(1 hunks)apps/dashboard/app/(app)/settings/root-keys/new/client.tsx(1 hunks)apps/dashboard/app/(app)/settings/workspace-navbar.tsx(1 hunks)apps/dashboard/app/new/create-ratelimit.tsx(1 hunks)apps/dashboard/app/new/keys.tsx(1 hunks)apps/dashboard/components/navigation/copyable-id-button.tsx(1 hunks)apps/engineering/content/design/components/button.mdx(0 hunks)apps/engineering/content/design/components/buttons/copy-button.examples.tsx(1 hunks)apps/engineering/content/design/components/copy-button.mdx(1 hunks)internal/ui/src/components/copy-button.tsx(1 hunks)internal/ui/src/index.ts(1 hunks)
💤 Files with no reviewable changes (1)
- apps/engineering/content/design/components/button.mdx
⏰ Context from checks skipped due to timeout of 90000ms (25)
- GitHub Check: Test Go API Local / Test (Shard 1/8)
- GitHub Check: Test Go API Local / Test (Shard 6/8)
- GitHub Check: Test Go API Local / Test (Shard 7/8)
- GitHub Check: Test Go API Local / Test (Shard 5/8)
- GitHub Check: Test Go API Local / Test (Shard 4/8)
- GitHub Check: Test Go API Local / Test (Shard 8/8)
- GitHub Check: Test Go API Local / Test (Shard 3/8)
- GitHub Check: Test Go API Local / Test (Shard 2/8)
- GitHub Check: Test API / API Test Local
- GitHub Check: Build / Build
- GitHub Check: Test Packages / Test ./packages/hono
- GitHub Check: Test Packages / Test ./packages/rbac
- GitHub Check: Test Packages / Test ./apps/dashboard
- GitHub Check: Test Packages / Test ./packages/cache
- GitHub Check: Test Packages / Test ./packages/nextjs
- GitHub Check: Test Packages / Test ./internal/clickhouse
- GitHub Check: Test Packages / Test ./packages/api
- GitHub Check: Test Packages / Test ./internal/keys
- GitHub Check: Test Packages / Test ./internal/resend
- GitHub Check: Test Packages / Test ./internal/encryption
- GitHub Check: Test Packages / Test ./internal/hash
- GitHub Check: Test Packages / Test ./internal/id
- GitHub Check: Test Packages / Test ./internal/billing
- GitHub Check: autofix
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (20)
internal/ui/src/components/copy-button.tsx (1)
4-4: Import path updated to use relative path.The change from an absolute import path to a relative path for the
cnutility is appropriate and aligns with the component being exported from the central UI package.apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/[keyId]/settings/page.tsx (1)
6-6: Import source updated to use the centralized UI package.Good refactoring to import
CopyButtonfrom the@unkey/uipackage instead of a local path, improving consistency across the codebase.apps/dashboard/app/(app)/identities/[identityId]/page.tsx (1)
19-19: Import source updated to use the centralized UI package.Good refactoring to import
CopyButtonfrom the@unkey/uipackage instead of a local path, maintaining consistency with other UI component imports (likeButtonon line 20).apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/components/secret-key.tsx (1)
5-5: Consolidated imports from the UI package.Good improvement to import both
ButtonandCopyButtonfrom the@unkey/uipackage, creating a more consistent import pattern.apps/dashboard/app/(app)/settings/root-keys/new/client.tsx (1)
6-6: Centralize CopyButton import.
ImportingCopyButtonfrom@unkey/uicorrectly replaces the local component path and aligns with the updated UI library. All<CopyButton>usages in this file will now resolve.apps/dashboard/app/(app)/settings/workspace-navbar.tsx (1)
7-7: Switch CopyButton to the shared UI package.
TheCopyButtonis now imported alongsideButtonfrom@unkey/ui, matching the refactor pattern across dashboard files. The<CopyButton>in the workspace navbar will function as expected.apps/dashboard/app/new/keys.tsx (1)
17-17: Consolidate imports from @unkey/ui.
CombiningButton,CopyButton, andEmptyinto a single import from@unkey/uisimplifies the import statements and ensures consistent usage of the shared UI components.apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/components/key-created-success-dialog.tsx (1)
8-8: Standardize CopyButton import path.
Replacing the localCopyButtonimport with the shared export from@unkey/uicentralizes the component reference. All instances of<CopyButton>in this dialog will now resolve properly.internal/ui/src/index.ts (1)
2-2: Expose CopyButton via library index.
Addingexport * from "./components/copy-button";makes theCopyButtoncomponent publicly available through@unkey/ui, enabling the import changes in the dashboard to function.apps/dashboard/app/(app)/authorization/roles/[roleId]/tree.tsx (1)
6-6: LGTM: Import centralization looks goodSuccessfully updated the import path to use the centralized
CopyButtonfrom@unkey/uiinstead of a local path. This aligns with the PR objective of maintaining CopyButton functionality while improving engineering documentation.apps/dashboard/app/(app)/ratelimits/_components/ratelimit-client.tsx (1)
3-3: LGTM: Import consolidation looks goodSuccessfully consolidated the
CopyButtonimport along with other UI components from@unkey/ui. This provides better consistency in component sourcing.apps/dashboard/app/new/create-ratelimit.tsx (1)
6-6: LGTM: Import path update is correctThe import has been properly updated to source
CopyButtonfrom the centralized UI package alongsideButton. This maintains consistency with other files in the codebase.apps/dashboard/components/navigation/copyable-id-button.tsx (1)
1-1: LGTM: Import path correctly updatedSuccessfully updated the import to source both
ButtonandCopyButtonfrom the centralized@unkey/uipackage. The component functionality remains unchanged.apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/hooks/use-fetch-identities/create-identity-options.tsx (1)
3-10: Import consolidation to@unkey/uilooks good.All UI components, including
CopyButton, are now consistently sourced from@unkey/ui, which aligns with the rest of the codebase and removes the prior split import pattern.apps/engineering/content/design/components/buttons/copy-button.examples.tsx (2)
1-2: Verify example imports.The imports for
RenderComponentWithSnippetandCopyButtonare correct. Please confirm that the alias@/app/components/renderresolves properly in the docs build.
3-19: Example component demonstrates correct usage.The
Defaultexample cleanly showcases both basic and styled uses ofCopyButton, includingsrcandclassNameprops. The snippet is clear, focused, and ready for documentation.apps/engineering/content/design/components/copy-button.mdx (4)
1-4: Frontmatter is well-formed.The MDX frontmatter including
titleandsummaryis correctly specified and aligns with repository conventions.
5-5: Import ofDefaultexample is correct.The relative path
./buttons/copy-button.examplesmatches the file structure and will load the example component as intended.
18-24: Props table is comprehensive.All props (
value,src,className) are documented with correct types and descriptions, matching the component API.
27-28: Usage section is clear.Embedding
<Default />effectively demonstrates component incorporation; no further changes needed here.
2 participants
What does this PR do?
Fixes # (issue)
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists
Type of change
How should this be tested?
Dashboard CopyButtons still function as expected
Eng Doc makes sense
Checklist
Required
pnpm buildpnpm fmtconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit