chore: remove old columns

[chronark]

Summary by CodeRabbit

• Refactor

  • Streamlined workspace management by removing outdated data fields for a cleaner, more efficient structure.

• Chore

  • Updated logging methods during data seeding to ensure consistent and informative output.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 10, 2025 6:44am
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 10, 2025 6:44am
play	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 10, 2025 6:44am
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 10, 2025 6:44am

[changeset-bot]

⚠️ No Changeset found

Latest commit: d862322

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

📝 Walkthrough

Walkthrough

This change removes five properties—__toBeDeleted, trialEnds, planLockedUntil, planChanged, and planDowngradeRequest—from workspace objects in both the test harness (createResources method) and the TRPC router (createWorkspace function). The corresponding fields have also been deleted from the workspaces table schema. Additionally, the logging in several seed scripts has been updated by replacing console.log calls with console.info.

Changes

Files	Change Summary
apps/api/src/pkg/testutil/harness.ts apps/dashboard/lib/trpc/routers/workspace/create.ts internal/db/.../workspaces.ts	Removed properties __toBeDeleted, trialEnds, planLockedUntil, planChanged, and planDowngradeRequest from workspace objects and the database schema.
tools/local/src/cmd/seed/apis.ts tools/local/src/cmd/seed/batch-operations.ts tools/local/src/cmd/seed/logs.ts	Replaced console.log with console.info in seed scripts for logging messages without changing the message content or control flow.

Possibly Related PRs

• feat: cancel subscriptions at the end of the period #2944: Involves removal of the same workspace properties, indicating a shared focus on streamlining the workspace data model.
• feat: allow-developer-to-set-a-custom-refill-time-when-using-the #2114: Also removes these properties from workspace-related objects, reinforcing schema and model simplification.
• chore: remove clerk #1 #3095: Addresses similar adjustments in the workspace data model, focusing on the removal of selected properties.

Suggested Reviewers

• perkinsjr
• mcstepp
• ogzhanolguncu
• MichaelUnkey

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c2572aa and d862322.

📒 Files selected for processing (6)

• apps/api/src/pkg/testutil/harness.ts (0 hunks)
• apps/dashboard/lib/trpc/routers/workspace/create.ts (0 hunks)
• internal/db/src/schema/workspaces.ts (2 hunks)
• tools/local/src/cmd/seed/apis.ts (1 hunks)
• tools/local/src/cmd/seed/batch-operations.ts (2 hunks)
• tools/local/src/cmd/seed/logs.ts (1 hunks)

💤 Files with no reviewable changes (2)

• apps/dashboard/lib/trpc/routers/workspace/create.ts
• apps/api/src/pkg/testutil/harness.ts

⏰ Context from checks skipped due to timeout of 90000ms (19)

• GitHub Check: Test Go API Local / Test (Shard 3/8)
• GitHub Check: Test Packages / Test ./packages/hono
• GitHub Check: Test Go API Local / Test (Shard 2/8)
• GitHub Check: Test Packages / Test ./packages/nextjs
• GitHub Check: Test Go API Local / Test (Shard 1/8)
• GitHub Check: Test Packages / Test ./packages/cache
• GitHub Check: Test Packages / Test ./packages/api
• GitHub Check: Test Packages / Test ./internal/keys
• GitHub Check: Test Packages / Test ./internal/resend
• GitHub Check: Test Packages / Test ./internal/clickhouse
• GitHub Check: Test Packages / Test ./internal/id
• GitHub Check: Test Packages / Test ./internal/hash
• GitHub Check: Test Packages / Test ./internal/encryption
• GitHub Check: Test Agent Local / test_agent_local
• GitHub Check: Test Packages / Test ./internal/billing
• GitHub Check: Test API / API Test Local
• GitHub Check: Build / Build
• GitHub Check: autofix
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (7)

tools/local/src/cmd/seed/logs.ts (1)

54-58: Logging method updated for consistency.

Changed from console.log to console.info for success message reporting, which aligns with similar changes across other files in the codebase. This provides better semantic distinction between different log levels.

tools/local/src/cmd/seed/apis.ts (1)

401-403: Logging method updated for consistency.

Changed from console.log to console.info for informational message, maintaining consistency with other logging changes throughout the codebase. This change improves the semantic use of console methods.

tools/local/src/cmd/seed/batch-operations.ts (2)

95-99: Logging method updated for consistency.

Changed from console.log to console.info for successful verification events insertion message, aligning with the consistent logging approach across the codebase.

---

178-182: Logging method updated for consistency.

Changed from console.log to console.info for successful ratelimit events insertion message, maintaining the consistent approach to logging throughout the application.

internal/db/src/schema/workspaces.ts (3)

3-3: Import statement updated to reflect schema changes.

The imports have been simplified, likely removing types that were associated with the deleted workspace fields. This is consistent with the PR's objective of removing old columns.

---

80-84: Comment updated to clarify subscriptions deprecation status.

The updated comment clearly explains that most customers have moved to Stripe subscriptions instead. This provides good context for why these old fields are being removed and aligns with modern payment handling practices.

---

15-91:

Details

❓ Verification inconclusive

Workspace schema columns successfully removed.

The PR has successfully removed the outdated columns (__toBeDeleted, trialEnds, planLockedUntil, planChanged, and planDowngradeRequest) from the workspaces table schema as intended. This cleanup simplifies the schema and removes deprecated functionality.

---

🏁 Script executed:

#!/bin/bash
# Verify that a migration file exists to handle these column removals
fd -e ts migration internal/db/migrations --exec cat {} \; | grep -E '__toBeDeleted|trialEnds|planLockedUntil|planChanged|planDowngradeRequest'

Length of output: 258

---

Action Required: Verify Migration File Location

• The workspace schema file (internal/db/src/schema/workspaces.ts) shows that deprecated columns (__toBeDeleted, trialEnds, planLockedUntil, planChanged, planDowngradeRequest) have been removed as intended.
• However, the migration verification script failed because the expected directory (internal/db/migrations) does not exist. This indicates that either the migration file has been relocated or wasn’t generated.
• Please manually verify that a migration handling these column removals exists in the correct location, or update the migration path accordingly.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏