Skip to content

chore: remove clerk #1#3095

Merged
chronark merged 1 commit intomainfrom
goodbye-clerk-1
Apr 9, 2025
Merged

chore: remove clerk #1#3095
chronark merged 1 commit intomainfrom
goodbye-clerk-1

Conversation

@chronark
Copy link
Collaborator

@chronark chronark commented Apr 9, 2025

Summary by CodeRabbit

  • Refactor
    • Streamlined workspace and API workflows by removing an internal tenant identifier from resource creation processes.
    • Updated the database schema to enforce unique organization identifiers and improved feature configuration.
  • Documentation
    • Standardized API specifications with consistent formatting and updated endpoint tags.
  • Chores
    • Removed deprecated migration tools and obsolete test configurations related to authentication and organization management.

@vercel
Copy link

vercel bot commented Apr 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 4:17pm
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 4:17pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 4:17pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 4:17pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2025

⚠️ No Changeset found

Latest commit: c3edb52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 9, 2025

📝 Walkthrough

Walkthrough

This pull request removes the usage of the clerkTenantId property from various workspace-related code paths. Changes span API testing utilities, front-end components, TRPC router functions, and database seeding/insertion. In addition, the auth migrator package—including its migration scripts and configuration—is entirely removed. Minor syntax fixes and formatting adjustments are also applied to OpenAPI schema definitions and error message returns, while the overall control flow remains unaffected.

Changes

Files Change Summary
Workspace clerkTenantId Removal
- apps/api/src/pkg/testutil/harness.ts
- apps/api/src/routes/v1_keys_getVerifications.security.test.ts
- apps/dashboard/app/(app)/gateway-new/page.tsx
- apps/dashboard/lib/trpc/routers/workspace/create.ts
- tools/local/src/db.ts
- internal/db/src/schema/workspaces.ts
Removed the clerkTenantId property from workspace objects. In addition, the workspaces table now enforces a non-null and unique orgId and features a reorganization of JSON field definitions.
Syntax Adjustment
- apps/dashboard/app/auth/actions.ts
Added a trailing comma to the message property in an error return object, ensuring proper syntax.
OpenAPI JSON Formatting
- go/apps/api/openapi/openapi.json
Converted multiline array declarations for "required" fields into single-line arrays across multiple schema definitions.
Auth Migrator Package Removal
- internal/auth-migrator/package.json
- internal/auth-migrator/src/deleteOrgs.ts
- internal/auth-migrator/src/deleteUser.ts
- internal/auth-migrator/src/organization.ts
- internal/auth-migrator/src/user.ts
- internal/auth-migrator/tsconfig.json
Removed the auth migrator package along with its migration scripts and configuration files, eliminating related organization and user management functionality.

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e501501 and c3edb52.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (14)
  • apps/api/src/pkg/testutil/harness.ts (0 hunks)
  • apps/api/src/routes/v1_keys_getVerifications.security.test.ts (0 hunks)
  • apps/dashboard/app/(app)/gateway-new/page.tsx (0 hunks)
  • apps/dashboard/app/auth/actions.ts (1 hunks)
  • apps/dashboard/lib/trpc/routers/workspace/create.ts (0 hunks)
  • go/apps/api/openapi/openapi.json (32 hunks)
  • internal/auth-migrator/package.json (0 hunks)
  • internal/auth-migrator/src/deleteOrgs.ts (0 hunks)
  • internal/auth-migrator/src/deleteUser.ts (0 hunks)
  • internal/auth-migrator/src/organization.ts (0 hunks)
  • internal/auth-migrator/src/user.ts (0 hunks)
  • internal/auth-migrator/tsconfig.json (0 hunks)
  • internal/db/src/schema/workspaces.ts (2 hunks)
  • tools/local/src/db.ts (0 hunks)
💤 Files with no reviewable changes (11)
  • internal/auth-migrator/tsconfig.json
  • apps/dashboard/lib/trpc/routers/workspace/create.ts
  • internal/auth-migrator/src/user.ts
  • tools/local/src/db.ts
  • apps/api/src/routes/v1_keys_getVerifications.security.test.ts
  • apps/dashboard/app/(app)/gateway-new/page.tsx
  • internal/auth-migrator/src/deleteUser.ts
  • apps/api/src/pkg/testutil/harness.ts
  • internal/auth-migrator/src/deleteOrgs.ts
  • internal/auth-migrator/package.json
  • internal/auth-migrator/src/organization.ts
🧰 Additional context used
🧬 Code Graph Analysis (2)
apps/dashboard/app/auth/actions.ts (1)
apps/dashboard/lib/auth/types.ts (1)
  • errorMessages (178-194)
internal/db/src/schema/workspaces.ts (2)
internal/billing/src/subscriptions.ts (1)
  • Subscriptions (24-24)
internal/db/src/schema/util/lifecycle_dates.ts (1)
  • lifecycleDatesMigration (28-35)
⏰ Context from checks skipped due to timeout of 90000ms (15)
  • GitHub Check: Test Go API Local / Test (Shard 4/8)
  • GitHub Check: Test Packages / Test ./packages/cache
  • GitHub Check: Test Go API Local / Test (Shard 5/8)
  • GitHub Check: Test Go API Local / Test (Shard 1/8)
  • GitHub Check: Test Go API Local / Test (Shard 3/8)
  • GitHub Check: Test Go API Local / Test (Shard 6/8)
  • GitHub Check: Test API / API Test Local
  • GitHub Check: Test Go API Local / Test (Shard 7/8)
  • GitHub Check: Test Go API Local / Test (Shard 2/8)
  • GitHub Check: Test Packages / Test ./packages/hono
  • GitHub Check: Test Agent Local / test_agent_local
  • GitHub Check: Test Packages / Test ./internal/clickhouse
  • GitHub Check: Build / Build
  • GitHub Check: autofix
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (4)
apps/dashboard/app/auth/actions.ts (1)

167-167: Minor Syntax Update: Trailing Comma Added

The addition of the trailing comma on the message property in the return object of completeOrgSelection helps maintain consistent formatting and simplifies future extensions (e.g., adding extra properties). This cosmetic change improves code consistency without impacting functionality.

internal/db/src/schema/workspaces.ts (2)

18-18: Appropriate enforcement of uniqueness on orgId field.

With the removal of clerkTenantId, making orgId both non-nullable and unique is a good approach to ensure each workspace is properly identified by a unique organization ID.

Ensure that the database migration for this change handles existing records properly, especially if there are any duplicate orgId values in the current data.


15-99: Field removal aligns with PR objective.

Successfully removed the clerkTenantId field from the workspaces table definition as per the PR objective. This change streamlines the workspace data model by removing the dependency on Clerk's tenant system.

go/apps/api/openapi/openapi.json (1)

20-1177: Improved OpenAPI schema formatting.

The formatting changes to convert multiline "required" arrays to single-line arrays throughout the OpenAPI schema improve readability and consistency without affecting API functionality.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Thank you for following the naming conventions for pull request titles! 🙏

@chronark chronark changed the title chore: remove clerk tenant id chore: remove clerk #1 Apr 9, 2025
@vercel vercel bot temporarily deployed to Preview – play April 9, 2025 16:13 Inactive
@vercel vercel bot temporarily deployed to Preview – engineering April 9, 2025 16:14 Inactive
@vercel vercel bot temporarily deployed to Preview – www April 9, 2025 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard April 9, 2025 16:17 Inactive
@chronark chronark merged commit c85cd77 into main Apr 9, 2025
34 of 39 checks passed
@chronark chronark deleted the goodbye-clerk-1 branch April 9, 2025 16:57
@coderabbitai coderabbitai bot mentioned this pull request Aug 25, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant