fix: remove navbar action items by chronark · Pull Request #2988 · unkeyed/unkey

chronark · 2025-03-18T16:51:00Z

ci: release agent
perf: add permission and key caches
feat: remove redundant navbar actions and replace old copy-fields

Summary by CodeRabbit

Refactor
- Removed extra copy buttons from the navigation area for permissions.
- Updated the settings pages for permissions and roles by replacing the read-only ID display with a single, dedicated copy button.
- Enhanced interface clarity and streamlined the process for copying IDs.

vercel · 2025-03-18T16:51:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 18, 2025 5:19pm
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 18, 2025 5:19pm
play	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 18, 2025 5:19pm
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 18, 2025 5:19pm

changeset-bot · 2025-03-18T16:51:05Z

⚠️ No Changeset found

Latest commit: 54010c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-03-18T16:51:08Z

📝 Walkthrough

Walkthrough

This pull request removes instances of the CopyableIDButton from the navigation component and replaces read-only Input fields with CopyableIDButton components in the settings components. In the navigation file, the CopyableIDButton for displaying the permission's name and ID has been removed, leaving only the deletion option. In the permissions and roles settings components, the Input fields have been replaced with CopyableIDButton, which now handles the copy-to-clipboard functionality directly.

Changes

File(s)	Change Summary
`apps/dashboard/.../permissions/[permissionId]/navigation.tsx`	Removed two instances of `CopyableIDButton` for displaying the permission’s name and ID, retaining only the `DeletePermission` action.
`apps/dashboard/.../permissions/[permissionId]/settings-client.tsx` `apps/dashboard/.../roles/[roleId]/settings-client.tsx`	Replaced a read-only `Input` component with `CopyableIDButton` to display and copy IDs, consolidating clipboard copy functionality into a single component.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant C as CopyableIDButton
    participant CB as Clipboard
    participant T as Toast

    U->>C: Click copy button
    C->>CB: Write ID to clipboard
    CB-->>C: Confirm copy
    C->>T: Trigger success toast
    T-->>U: Display confirmation

Suggested labels

Bug, 🕹️ oss.gg

Suggested reviewers

mcstepp
ogzhanolguncu
perkinsjr

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
- To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c0a96d and 54010c0.

📒 Files selected for processing (2)

apps/dashboard/app/(app)/authorization/permissions/[permissionId]/settings-client.tsx (3 hunks)
apps/dashboard/app/(app)/authorization/roles/[roleId]/settings-client.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

apps/dashboard/app/(app)/authorization/roles/[roleId]/settings-client.tsx
apps/dashboard/app/(app)/authorization/permissions/[permissionId]/settings-client.tsx

⏰ Context from checks skipped due to timeout of 90000ms (11)

GitHub Check: Test Agent Local / test_agent_local
GitHub Check: Test Packages / Test ./internal/clickhouse
GitHub Check: Test Packages / Test ./packages/nextjs
GitHub Check: Test Packages / Test ./packages/api
GitHub Check: Build / Build
GitHub Check: Test Packages / Test ./internal/billing
GitHub Check: Test Packages / Test ./internal/hash
GitHub Check: Test Packages / Test ./internal/encryption
GitHub Check: Test API / API Test Local
GitHub Check: autofix
GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-18T16:52:03Z

Thank you for following the naming conventions for pull request titles! 🙏

perkinsjr · 2025-03-18T16:57:45Z

This white space and alignment is bad.

ogzhanolguncu · 2025-03-18T16:59:00Z

thats how it looks on my end
image.png

perkinsjr · 2025-03-18T17:03:10Z

Yeah it's because we are determined to use fixed width w-[760px] which on hiDPI causes issues, which is why tailwind is anti fixed width.

If I set my screen to 4k it's fine if I set it to 1080p it's broken

perkinsjr · 2025-03-18T17:10:13Z

I am fine to ship this as is, considering it was like that prior to me looking at it.

chronark · 2025-03-18T17:11:05Z

nah I’ll tweak it slightly

chronark · 2025-03-18T17:11:11Z

I just reviewed auth first

perkinsjr · 2025-03-18T17:11:35Z

Alright I turned off auto merge so go for it.

chronark · 2025-03-18T17:12:54Z

I just right-aligned the copy buttons, that’s it
CleanShot 2025-03-18 at 18.12.37@2x.png

chronark · 2025-03-18T17:13:16Z

I’m also not a huge fan of the fixed pixel width, I just don’t know how to do it properly

chronark added 7 commits March 17, 2025 09:02

ci: release agent

c5528bd

perf: add permission and key caches

30b4f1b

Merge branch 'main' of https://github.com/unkeyed/unkey

8f1abc9

Merge branch 'main' of https://github.com/unkeyed/unkey

e009d64

Merge branch 'main' of https://github.com/unkeyed/unkey

0f4c28d

Merge branch 'main' of https://github.com/unkeyed/unkey

6658613

feat: remove redundant navbar actions and replace old copy-fields

1c0a96d

chronark requested review from mcstepp, ogzhanolguncu and perkinsjr as code owners March 18, 2025 16:51

chronark enabled auto-merge March 18, 2025 16:51

vercel bot temporarily deployed to Preview – play March 18, 2025 16:51 Inactive

vercel bot temporarily deployed to Preview – engineering March 18, 2025 16:51 Inactive

vercel bot temporarily deployed to Preview – www March 18, 2025 16:52 Inactive

vercel bot temporarily deployed to Preview – dashboard March 18, 2025 16:55 Inactive

perkinsjr approved these changes Mar 18, 2025

View reviewed changes

chronark added this pull request to the merge queue Mar 18, 2025

perkinsjr removed this pull request from the merge queue due to a manual request Mar 18, 2025

chronark changed the title ~~remove navbar action items~~ fix: remove navbar action items Mar 18, 2025

fix: spacing/alignment

54010c0

vercel bot temporarily deployed to Preview – play March 18, 2025 17:15 Inactive

vercel bot temporarily deployed to Preview – engineering March 18, 2025 17:15 Inactive

vercel bot temporarily deployed to Preview – www March 18, 2025 17:16 Inactive

perkinsjr approved these changes Mar 18, 2025

View reviewed changes

vercel bot temporarily deployed to Preview – dashboard March 18, 2025 17:19 Inactive

ogzhanolguncu approved these changes Mar 18, 2025

View reviewed changes

perkinsjr merged commit 3042219 into main Mar 18, 2025
27 of 30 checks passed

perkinsjr deleted the remove-navbar-action-items branch March 18, 2025 19:19

p6l-richard mentioned this pull request Apr 4, 2025

feat(billing): update the keyword-research #3077

Merged

18 tasks

This was referenced Jul 8, 2025

chore: Move toaster to UI step 3 #3485

Merged

chore: Move toaster to UI step 4 #3487

Merged

coderabbitai bot mentioned this pull request Oct 10, 2025

fix: Key settings is missing from keys/keyAuthId/keyId #4093

Merged

18 tasks

Conversation

chronark commented Mar 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

perkinsjr commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ogzhanolguncu commented Mar 18, 2025

Uh oh!

perkinsjr commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

perkinsjr commented Mar 18, 2025

Uh oh!

chronark commented Mar 18, 2025

Uh oh!

chronark commented Mar 18, 2025

Uh oh!

Uh oh!

perkinsjr commented Mar 18, 2025

Uh oh!

chronark commented Mar 18, 2025

Uh oh!

chronark commented Mar 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chronark commented Mar 18, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Mar 18, 2025 •

edited

Loading

changeset-bot bot commented Mar 18, 2025 •

edited

Loading

coderabbitai bot commented Mar 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 18, 2025 •

edited

Loading

perkinsjr commented Mar 18, 2025 •

edited

Loading

perkinsjr commented Mar 18, 2025 •

edited

Loading