Skip to content

fix: remove navbar action items #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
perkinsjr merged 8 commits into from
Mar 18, 2025
+9 −45
Merged

fix: remove navbar action items #2988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c5528bd
ci: release agent
chronark Mar 17, 2025
30b4f1b
perf: add permission and key caches
chronark Mar 17, 2025
8f1abc9
Merge branch 'main' of https://github.com/unkeyed/unkey
chronark Mar 17, 2025
e009d64
Merge branch 'main' of https://github.com/unkeyed/unkey
chronark Mar 18, 2025
0f4c28d
Merge branch 'main' of https://github.com/unkeyed/unkey
chronark Mar 18, 2025
6658613
Merge branch 'main' of https://github.com/unkeyed/unkey
chronark Mar 18, 2025
1c0a96d
feat: remove redundant navbar actions and replace old copy-fields
chronark Mar 18, 2025
54010c0
fix: spacing/alignment
chronark Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apps/dashboard/app/(app)/authorization/permissions/[permissionId]/navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"use client";
import { NavbarActionButton } from "@/components/navigation/action-button";
import { CopyableIDButton } from "@/components/navigation/copyable-id-button";
import { Navbar } from "@/components/navigation/navbar";
import type { Permission } from "@unkey/db";
import { ShieldKey } from "@unkey/icons";
Expand Down Expand Up @@ -31,8 +30,6 @@ export function Navigation({
</Navbar.Breadcrumbs.Link>
</Navbar.Breadcrumbs>
<Navbar.Actions>
<CopyableIDButton value={permission.name} />
<CopyableIDButton value={permission.id} />
<DeletePermission
key="delete-permission"
trigger={
Expand Down
27 changes: 5 additions & 22 deletions apps/dashboard/app/(app)/authorization/permissions/[permissionId]/settings-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
"use client";

import { revalidateTag } from "@/app/actions";
import { CopyableIDButton } from "@/components/navigation/copyable-id-button";
import { SettingCard } from "@/components/settings-card";
import { toast } from "@/components/ui/toaster";
import { tags } from "@/lib/cache";
import { trpc } from "@/lib/trpc/client";
import { zodResolver } from "@hookform/resolvers/zod";
import { Clone } from "@unkey/icons";
import { Button, Input } from "@unkey/ui";
import { validation } from "@unkey/validation";
import { format } from "date-fns";
Expand Down Expand Up @@ -119,8 +119,7 @@ export const PermissionClient = ({ permission }: Props) => {
title="Permission name"
description={
<div>
Used in API calls. Changing this may affect your access control
<br /> requests.
Used in API calls. Changing this may affect your access control requests.
</div>
}
border="top"
Expand All @@ -145,25 +144,9 @@ export const PermissionClient = ({ permission }: Props) => {
description="An identifier for the permission, used in API calls."
border="bottom"
>
<Input
readOnly
disabled
defaultValue={permission.id}
placeholder="Permission ID"
rightIcon={
<button
type="button"
onClick={() => {
navigator.clipboard.writeText(permission.id);
toast.success("Copied to clipboard", {
description: permission.id,
});
}}
>
<Clone size="md-regular" />
</button>
}
/>
<div className="flex justify-end w-full">
<CopyableIDButton value={permission.id} />
</div>
</SettingCard>
</div>

Expand Down
24 changes: 4 additions & 20 deletions apps/dashboard/app/(app)/authorization/roles/[roleId]/settings-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
"use client";

import { revalidateTag } from "@/app/actions";
import { CopyableIDButton } from "@/components/navigation/copyable-id-button";
import { SettingCard } from "@/components/settings-card";
import { tags } from "@/lib/cache";
import { trpc } from "@/lib/trpc/client";
import { zodResolver } from "@hookform/resolvers/zod";
import { Clone } from "@unkey/icons";
import { Button, Input } from "@unkey/ui";
import { validation } from "@unkey/validation";
import { format } from "date-fns";
Expand Down Expand Up @@ -133,25 +133,9 @@ export const RoleClient = ({ role, activeKeys, sortedNestedPermissions }: RoleCl
description="An identifier for this role, used in API calls."
border="bottom"
>
<Input
readOnly
disabled
defaultValue={role.id}
placeholder="Role ID"
rightIcon={
<button
type="button"
onClick={() => {
navigator.clipboard.writeText(role.id);
toast.success("Copied to clipboard", {
description: role.id,
});
}}
>
<Clone size="md-regular" />
</button>
}
/>
<div className="flex justify-end w-full">
<CopyableIDButton value={role.id} />
</div>
</SettingCard>
</div>

Expand Down
Loading