Skip to content

fix: discord on command + k dark mode and fixing the link#2102

Merged
chronark merged 4 commits intounkeyed:mainfrom
harshsbhat:harshbhat/discordDarkMode
Sep 17, 2024
Merged

fix: discord on command + k dark mode and fixing the link#2102
chronark merged 4 commits intounkeyed:mainfrom
harshsbhat:harshbhat/discordDarkMode

Conversation

@harshsbhat
Copy link
Contributor

@harshsbhat harshsbhat commented Sep 17, 2024

What does this PR do?

Fixes #2100

The Discord icon in the Cmd + k is displayed correctly in both dark and light mode

Before hover:
image

On hover:
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features

    • Updated the CommandItem in the Command Menu to navigate to an external link for Discord.
  • Style

    • Enhanced visual presentation of the Command Menu with improved SVG styling.

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: 686e6d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 17, 2024

@harshsbhat is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Warning

Rate limit exceeded

@harshsbhat has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 16 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between c572089 and 686e6d3.

Walkthrough

Walkthrough

The changes introduced in this pull request involve modifications to the CommandMenu component, specifically updating the navigation URL for the CommandItem to an external link. Additionally, minor adjustments were made to the SVG element's class attributes, enhancing the visual presentation and allowing for better color management in relation to the component's styling.

Changes

File Change Summary
apps/dashboard/components/dashboard/command-menu.tsx Updated CommandItem navigation URL to https://unkey.com/discord and modified SVG attributes for better visual presentation.

Assessment against linked issues

Objective Addressed Explanation
The icons should be bright in dark mode (#2100) The PR does not address the icon color issue in dark mode.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@chronark chronark enabled auto-merge September 17, 2024 12:25
@vercel
Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 0:31am
planetfall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 0:31am
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 0:31am
workflows ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 0:31am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 0:31am

@vercel vercel bot temporarily deployed to Preview – planetfall September 17, 2024 12:27 Inactive
@vercel vercel bot temporarily deployed to Preview – play September 17, 2024 12:27 Inactive
@vercel vercel bot temporarily deployed to Preview – workflows September 17, 2024 12:28 Inactive
@vercel vercel bot temporarily deployed to Preview – www September 17, 2024 12:29 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard September 17, 2024 12:31 Inactive
@chronark chronark added this pull request to the merge queue Sep 17, 2024
Merged via the queue into unkeyed:main with commit e2471b4 Sep 17, 2024
@coderabbitai coderabbitai bot mentioned this pull request Sep 20, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cmd+k discord icon in darkmode

2 participants