Skip to content

fix(org-selector): force auth page into dark mode#3059

Merged
perkinsjr merged 4 commits intomainfrom
fix-org-selector
Mar 31, 2025
Merged

fix(org-selector): force auth page into dark mode#3059
perkinsjr merged 4 commits intomainfrom
fix-org-selector

Conversation

@mcstepp
Copy link
Collaborator

@mcstepp mcstepp commented Mar 31, 2025

What does this PR do?

Fixes #3058

Before:
Screenshot 2025-03-31 at 12 28 58 PM

After:
Screenshot 2025-03-31 at 12 29 58 PM

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Manual verification in supported browsers

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features
    • Enhanced the sign-in experience by applying a cohesive dark theme styling during the organization selection process, improving visual consistency.
  • Changes
    • Updated the handling of the NEXT_PUBLIC_WORKOS_REDIRECT_URI environment variable to make it optional, affecting how the application manages this variable's absence.

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025

⚠️ No Changeset found

Latest commit: aabde98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 7:24pm
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 7:24pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 7:24pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 7:24pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 31, 2025

📝 Walkthrough

Walkthrough

The OrgSelector component has been updated to enhance its styling for a dark theme, with several elements receiving the "dark" class for improved visual consistency. Additionally, the declaration of the NEXT_PUBLIC_WORKOS_REDIRECT_URI environment variable has been modified to make it optional, removing the previous default value.

Changes

File(s) Change Summary
apps/dashboard/app/auth/sign-in/org-selector.tsx Updated OrgSelector component to apply dark theme styles by adding "dark" class to various elements, including DialogContent, DialogHeader, and DialogTitle.
apps/dashboard/lib/env.ts Changed NEXT_PUBLIC_WORKOS_REDIRECT_URI to be optional without a default value, modifying its declaration from a default URL to .optional().

Assessment against linked issues

Objective Addressed Explanation
Org-Selector should match the auth page theme in light mode (#3058)

Suggested labels

🕹️ oss.gg, :joystick: 150 points, hacktoberfest

Suggested reviewers

  • mcstepp
  • chronark

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74a3174 and aabde98.

📒 Files selected for processing (1)
  • apps/dashboard/app/auth/sign-in/org-selector.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/dashboard/app/auth/sign-in/org-selector.tsx
⏰ Context from checks skipped due to timeout of 90000ms (14)
  • GitHub Check: Test Go API Local / Test (Shard 2/8)
  • GitHub Check: Test Packages / Test ./internal/clickhouse
  • GitHub Check: Test Packages / Test ./packages/rbac
  • GitHub Check: Test Packages / Test ./internal/billing
  • GitHub Check: Test Packages / Test ./packages/hono
  • GitHub Check: Test Go API Local / Test (Shard 6/8)
  • GitHub Check: Test Go API Local / Test (Shard 7/8)
  • GitHub Check: Test Go API Local / Test (Shard 8/8)
  • GitHub Check: Test Packages / Test ./packages/api
  • GitHub Check: Test Go API Local / Test (Shard 3/8)
  • GitHub Check: Test Agent Local / test_agent_local
  • GitHub Check: Test API / API Test Local
  • GitHub Check: Build / Build
  • GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Bug Something isn't working label Mar 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

Thank you for following the naming conventions for pull request titles! 🙏

@vercel vercel bot temporarily deployed to Preview – engineering March 31, 2025 16:32 Inactive
@vercel vercel bot temporarily deployed to Preview – www March 31, 2025 16:32 Inactive
@vercel vercel bot temporarily deployed to Preview – play March 31, 2025 16:33 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard March 31, 2025 16:36 Inactive
@vercel vercel bot temporarily deployed to Preview – play March 31, 2025 17:28 Inactive
@vercel vercel bot temporarily deployed to Preview – engineering March 31, 2025 17:28 Inactive
@vercel vercel bot temporarily deployed to Preview – www March 31, 2025 17:29 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard March 31, 2025 17:32 Inactive
@vercel vercel bot temporarily deployed to Preview – play March 31, 2025 18:56 Inactive
@vercel vercel bot temporarily deployed to Preview – engineering March 31, 2025 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – www March 31, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard March 31, 2025 19:01 Inactive
I am dumb
@vercel vercel bot temporarily deployed to Preview – play March 31, 2025 19:10 Inactive
@vercel vercel bot temporarily deployed to Preview – www March 31, 2025 19:10 Inactive
@vercel vercel bot temporarily deployed to Preview – engineering March 31, 2025 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard March 31, 2025 19:13 Inactive
I removed the useEffect, it would cause light mode to be defaulted too
even if the end user had dark mode selected first.

I just use className to fix it instead
@vercel vercel bot temporarily deployed to Preview – play March 31, 2025 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – engineering March 31, 2025 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – www March 31, 2025 19:22 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard March 31, 2025 19:24 Inactive
@perkinsjr perkinsjr merged commit 4be8e3c into main Mar 31, 2025
34 of 37 checks passed
@perkinsjr perkinsjr deleted the fix-org-selector branch March 31, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Org-Selector is transparent in light mode

2 participants