Fix: Increase size of modal listing property editors#21825
Conversation
|
Hi there @TechPdo, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
…ally top and label in each starts from same position.
…ing-property-editors
|
Hi @TechPdo, thanks so much for your pull request to fix the issue of the icons and the lines as per #21793. I tested it and it looked good and worked to limit the lines to 2 - @nielslyngsoe are you happy for us to merge, and label for the next v17 release? Thanks! |
|
Thanks @TechPdo for the contribution and @emmagarland for the review. I spotted a small regression with the Content Type > Property > Data Type > Create new button's icon alignment, it was a small tweak so I've fixed that up and merged it in. 🚀 |
…ing-property-editors

This PR have the changes in the modals of datatype picker. Before when you create new datatype and select new property editor the modal size was small. This is changed to medium and the text visible below the data types are limited to 2 lines (using
line-clamp) with a tooltip. Same text behavior implemented in content > content type > property > data type / property editor and content type > property > data type / property editorCloses #21793