Skip to content

Fix: Increase size of modal listing property editors#21825

Merged
leekelleher merged 7 commits intoumbraco:mainfrom
TechPdo:v17/bugfix/21793-increase-size-of-modal-listing-property-editors
Feb 27, 2026
Merged

Fix: Increase size of modal listing property editors#21825
leekelleher merged 7 commits intoumbraco:mainfrom
TechPdo:v17/bugfix/21793-increase-size-of-modal-listing-property-editors

Conversation

@TechPdo
Copy link
Copy Markdown
Contributor

@TechPdo TechPdo commented Feb 19, 2026

This PR have the changes in the modals of datatype picker. Before when you create new datatype and select new property editor the modal size was small. This is changed to medium and the text visible below the data types are limited to 2 lines (using line-clamp) with a tooltip. Same text behavior implemented in content > content type > property > data type / property editor and content type > property > data type / property editor

property-editor-modal-medium content-datatype-property

Closes #21793

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2026

Hi there @TechPdo, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland emmagarland self-assigned this Feb 26, 2026
@emmagarland
Copy link
Copy Markdown
Collaborator

Hi @TechPdo, thanks so much for your pull request to fix the issue of the icons and the lines as per #21793.

I tested it and it looked good and worked to limit the lines to 2 - @nielslyngsoe are you happy for us to merge, and label for the next v17 release?

Thanks!

@emmagarland emmagarland self-requested a review February 26, 2026 09:55
Copy link
Copy Markdown
Collaborator

@emmagarland emmagarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works and looks good for me

Image

@leekelleher leekelleher self-requested a review February 26, 2026 16:03
@leekelleher leekelleher enabled auto-merge (squash) February 26, 2026 16:45
@leekelleher
Copy link
Copy Markdown
Member

Thanks @TechPdo for the contribution and @emmagarland for the review.

I spotted a small regression with the Content Type > Property > Data Type > Create new button's icon alignment, it was a small tweak so I've fixed that up and merged it in. 🚀

@leekelleher leekelleher merged commit 5958198 into umbraco:main Feb 27, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase size of modal listing property editors

3 participants