Skip to content

Property Editor Dialog: Set height to 100% for umb-property-editor-ui-picker-modal#22354

Merged
AndyButland merged 4 commits intoumbraco:mainfrom
bjarnef:patch-8
Apr 8, 2026
Merged

Property Editor Dialog: Set height to 100% for umb-property-editor-ui-picker-modal#22354
AndyButland merged 4 commits intoumbraco:mainfrom
bjarnef:patch-8

Conversation

@bjarnef
Copy link
Copy Markdown
Contributor

@bjarnef bjarnef commented Apr 5, 2026

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Changes in #21825 has an impact on how footer aligned in property editor UI modal, which is causes by these lines added to host element:

:host {
    display: block;
    container-type: inline-size;
}

In 17.2.2

image image

With latest changes in main branch, which doesn't align footer at bottom as previous:

image image

Adding height: 100% to host element ensures footer stick to bottom as because in both unfiltered and filtered results.

image image

Copilot AI review requested due to automatic review settings April 5, 2026 22:49
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a regression in the property editor UI picker sidebar modal layout so the footer/actions area aligns to the bottom again (as in 17.2.2), following modal sizing changes introduced in #21825.

Changes:

  • Set the umb-property-editor-ui-picker-modal host element height to 100% so its internal umb-body-layout can correctly stretch and place the footer/actions at the bottom.

@bjarnef bjarnef changed the title Set height to 100% for ui-picker-modal element Fix: Set height to 100% for umb-property-editor-ui-picker-modal Apr 5, 2026
Copy link
Copy Markdown
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjarnef - I've tested this out and can confirm it fixes the issue such that the footer buttons are consistently aligned at the bottom.

@AndyButland AndyButland changed the title Fix: Set height to 100% for umb-property-editor-ui-picker-modal Property Editor Dialog: Set height to 100% for umb-property-editor-ui-picker-modal Apr 8, 2026
@AndyButland AndyButland merged commit ac54cfd into umbraco:main Apr 8, 2026
29 checks passed
@bjarnef bjarnef deleted the patch-8 branch April 8, 2026 10:04
@bjarnef
Copy link
Copy Markdown
Contributor Author

bjarnef commented Apr 8, 2026

@AndyButland probably too late for v17.3.1 .. but perhaps include this tiny change for v17.3.2 ?

@AndyButland
Copy link
Copy Markdown
Contributor

If more critical reasons for another patch release come up, we can include this one too. But I don't think we'll do one just for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants