Property Editor Dialog: Set height to 100% for umb-property-editor-ui-picker-modal#22354
Property Editor Dialog: Set height to 100% for umb-property-editor-ui-picker-modal#22354AndyButland merged 4 commits intoumbraco:mainfrom
umb-property-editor-ui-picker-modal#22354Conversation
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the property editor UI picker sidebar modal layout so the footer/actions area aligns to the bottom again (as in 17.2.2), following modal sizing changes introduced in #21825.
Changes:
- Set the
umb-property-editor-ui-picker-modalhost element height to100%so its internalumb-body-layoutcan correctly stretch and place the footer/actions at the bottom.
umb-property-editor-ui-picker-modal
AndyButland
left a comment
There was a problem hiding this comment.
Thanks @bjarnef - I've tested this out and can confirm it fixes the issue such that the footer buttons are consistently aligned at the bottom.
umb-property-editor-ui-picker-modalumb-property-editor-ui-picker-modal
|
@AndyButland probably too late for v17.3.1 .. but perhaps include this tiny change for v17.3.2 ? |
|
If more critical reasons for another patch release come up, we can include this one too. But I don't think we'll do one just for this. |
…i-picker-modal` (#22354) Set height to 100% for ui-picker-modal element
Prerequisites
Description
Changes in #21825 has an impact on how footer aligned in property editor UI modal, which is causes by these lines added to host element:
In 17.2.2
With latest changes in
mainbranch, which doesn't align footer at bottom as previous:Adding
height: 100%to host element ensures footer stick to bottom as because in both unfiltered and filtered results.