Skip to content

Fix: Increase size of modal listing property editors #21825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leekelleher merged 7 commits into from
Feb 27, 2026
Merged

Fix: Increase size of modal listing property editors #21825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6f317ea
Changed the modal size to medium data type picker modals.
TechPdo Feb 19, 2026
408d16b
Merge branch 'main' into v17/bugfix/21793-increase-size-of-modal-list…
TechPdo Feb 19, 2026
4c529c1
Updated the icon and label alignment so that icon always align vertic…
TechPdo Feb 19, 2026
e5d4d1d
Merge branch 'main' into v17/bugfix/21793-increase-size-of-modal-list…
TechPdo Feb 19, 2026
1fa2e97
Linting
leekelleher Feb 26, 2026
28ce4be
Adds `justify-items: center` for "Create new" button icon
leekelleher Feb 26, 2026
4bd2215
Merge branch 'main' into v17/bugfix/21793-increase-size-of-modal-list…
TechPdo Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 44 additions & 10 deletions .../packages/core/property-editor/ui-picker-modal/property-editor-ui-picker-modal.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,21 +112,29 @@ export class UmbPropertyEditorUIPickerModalElement extends UmbModalBaseElement<
${repeat(
groupItems,
(propertyEditorUI) => propertyEditorUI.alias,
(propertyEditorUI) => html`
<li class="item" ?selected=${this.value.selection.includes(propertyEditorUI.alias)}>
<button type="button" @click=${() => this.#handleClick(propertyEditorUI)}>
<umb-icon name=${propertyEditorUI.meta.icon} class="icon"></umb-icon>
${this.localize.string(propertyEditorUI.meta.label || propertyEditorUI.name)}
</button>
</li>
`,
(propertyEditorUI) => {
const label = this.localize.string(propertyEditorUI.meta.label || propertyEditorUI.name);
return html`
<li class="item" ?selected=${this.value.selection.includes(propertyEditorUI.alias)}>
<button type="button" @click=${() => this.#handleClick(propertyEditorUI)}>
<umb-icon name=${propertyEditorUI.meta.icon} class="icon"></umb-icon>
<span class="label" title=${label}>${label}</span>
</button>
</li>
`;
},
)}
</ul>
`;
}

static override styles = [
css`
:host {
display: block;
container-type: inline-size;
}

#filter {
width: 100%;
margin-bottom: var(--uui-size-space-4);
Expand All @@ -141,12 +149,30 @@ export class UmbPropertyEditorUIPickerModalElement extends UmbModalBaseElement<

#item-grid {
display: grid;
grid-template-columns: repeat(auto-fill, minmax(70px, 1fr));
grid-template-columns: repeat(3, minmax(0, 1fr));
margin: 0;
padding: 0;
grid-gap: var(--uui-size-space-4);
}

@container (min-width: 560px) {
#item-grid {
grid-template-columns: repeat(4, minmax(0, 1fr));
}
}

@container (min-width: 740px) {
#item-grid {
grid-template-columns: repeat(5, minmax(0, 1fr));
}
}

@container (min-width: 920px) {
#item-grid {
grid-template-columns: repeat(6, minmax(0, 1fr));
}
}

#item-grid .item {
display: flex;
align-items: flex-start;
Expand Down Expand Up @@ -176,7 +202,7 @@ export class UmbPropertyEditorUIPickerModalElement extends UmbModalBaseElement<
display: flex;
align-items: center;
flex-direction: column;
justify-content: center;
justify-content: flex-start;
font-size: 0.8rem;
height: 100%;
width: 100%;
Expand All @@ -188,6 +214,14 @@ export class UmbPropertyEditorUIPickerModalElement extends UmbModalBaseElement<
font-size: 2em;
margin-bottom: var(--uui-size-space-2);
}

#item-grid .item .label {
max-width: 100%;
display: -webkit-box;
-webkit-line-clamp: 2;
-webkit-box-orient: vertical;
overflow: hidden;
}
`,
];
}
Expand Down
2 changes: 1 addition & 1 deletion ...rc/packages/core/property-editor/ui-picker-modal/property-editor-ui-picker-modal.token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ export const UMB_PROPERTY_EDITOR_UI_PICKER_MODAL = new UmbModalToken<
>('Umb.Modal.PropertyEditorUiPicker', {
modal: {
type: 'sidebar',
size: 'small',
size: 'medium',
},
});
23 changes: 19 additions & 4 deletions ...type/modals/data-type-picker-flow/data-type-picker-flow-data-type-picker-modal.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class UmbDataTypePickerFlowDataTypePickerModalElement extends UmbModalBas
<uui-button label=${dataType.name} @click=${() => this.#handleClick(dataType)}>
<div class="item-content">
<umb-icon name=${dataType.icon ?? 'icon-circle-dotted'} class="icon"></umb-icon>
${dataType.name}
<span class="label" title=${dataType.name}>${dataType.name}</span>
</div>
</uui-button>
</li>
Expand Down Expand Up @@ -165,15 +165,18 @@ export class UmbDataTypePickerFlowDataTypePickerModalElement extends UmbModalBas

padding: var(--uui-size-space-2);

display: grid;
grid-template-rows: 40px 1fr;
display: flex;
flex-direction: column;
align-items: center;
justify-content: flex-start;
height: 100%;
width: 100%;
word-break: break-word;
}

.icon {
font-size: 2em;
margin: auto;
margin-bottom: var(--uui-size-space-2);
}

#create-button {
Expand All @@ -185,20 +188,32 @@ export class UmbDataTypePickerFlowDataTypePickerModalElement extends UmbModalBas
width: 100%;
height: 100%;
}

#create-button .content {
text-align: center;
box-sizing: border-box;

padding: var(--uui-size-space-2);

display: grid;
justify-items: center;
grid-template-rows: 40px 1fr;

height: 100%;
width: 100%;
}

#create-button:not(:first-child) {
margin-top: var(--uui-size-layout-1);
}

#item-grid .item .label {
max-width: 100%;
display: -webkit-box;
-webkit-line-clamp: 2;
-webkit-box-orient: vertical;
overflow: hidden;
}
`,
];
}
Expand Down
2 changes: 1 addition & 1 deletion ...a-type/modals/data-type-picker-flow/data-type-picker-flow-data-type-picker-modal.token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ export const UMB_DATA_TYPE_PICKER_FLOW_DATA_TYPE_PICKER_MODAL = new UmbModalToke
>('Umb.Modal.DataTypePickerFlowDataTypePicker', {
modal: {
type: 'sidebar',
size: 'small',
size: 'medium',
},
});
21 changes: 16 additions & 5 deletions ...rc/packages/data-type/modals/data-type-picker-flow/data-type-picker-flow-modal.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ export class UmbDataTypePickerFlowModalElement extends UmbModalBaseElement<
return html`
<div class="item-content">
<umb-icon name=${propertyEditorUI.meta.icon} class="icon"></umb-icon>
${label}
<span class="label" title=${label}>${label}</span>
</div>
`;
}
Expand All @@ -398,7 +398,7 @@ export class UmbDataTypePickerFlowModalElement extends UmbModalBaseElement<
<uui-button .label=${dataType.name} type="button" @click=${() => this.#handleDataTypeClick(dataType)}>
<div class="item-content">
<umb-icon name=${dataType.icon ?? 'icon-circle-dotted'} class="icon"></umb-icon>
${dataType.name}
<span class="label" title=${dataType.name}>${dataType.name}</span>
</div>
</uui-button>
</li>
Expand Down Expand Up @@ -467,16 +467,27 @@ export class UmbDataTypePickerFlowModalElement extends UmbModalBaseElement<

padding: var(--uui-size-space-2);

display: grid;
grid-template-rows: 40px 1fr;
display: flex;
flex-direction: column;
align-items: center;
justify-content: flex-start;
height: 100%;
width: 100%;
word-break: break-word;
}

#item-grid .item .icon {
font-size: 2em;
margin: auto;
margin-bottom: var(--uui-size-space-2);
}

#item-grid .item .label {
max-width: 100%;
min-width: 0;
display: -webkit-box;
-webkit-line-clamp: 2;
-webkit-box-orient: vertical;
overflow: hidden;
}

.category-name {
Expand Down
Loading