Trees: Restore backward compatibility for file system based tree controllers (closes #20602)#20608
Merged
AndyButland merged 3 commits intomainfrom Oct 22, 2025
Conversation
AndyButland
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores backward compatibility for file system based tree controllers by fixing constructor hierarchies and removing dependencies on the now-obsolete StaticServiceProvider. The changes ensure that controllers extending from the base classes can continue using legacy constructors (e.g., accepting only FileSystems) until they can be updated to use the newer service-based approach.
Key changes:
- Introduced a
_useFileSystemTreeServiceflag inFileSystemTreeControllerBaseto support both legacy and service-based implementations - Removed
StaticServiceProviderdependencies across all tree controller classes - Standardized obsolescence messages and updated removal timeline to Umbraco 18/19
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| FileSystemTreeControllerBase.cs | Added flag-based routing to support both legacy FileSystem-based and new service-based implementations |
| StylesheetTreeControllerBase.cs | Removed StaticServiceProvider, updated constructor chain and obsolescence messages |
| ScriptTreeControllerBase.cs | Removed StaticServiceProvider, updated constructor chain and obsolescence messages |
| PartialViewTreeControllerBase.cs | Removed StaticServiceProvider, updated constructor chain and obsolescence messages |
| SiblingsStylesheetTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| RootStylesheetTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| ChildrenStylesheetTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| AncestorsStylesheetTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| SiblingsScriptTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| RootScriptTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| ChildrenScriptTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| AncestorsScriptTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| SiblingsPartialViewTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| RootPartialViewTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| ChildrenPartialViewTreeController.cs | Removed StaticServiceProvider, simplified constructors |
| AncestorsPartialViewTreeController.cs | Removed StaticServiceProvider, simplified constructors and unused imports |
…r-file-system-controllers
Contributor
|
@AndyButland I can confirm that's back working correctly for Umbraco Forms 👍 |
lauraneto
reviewed
Oct 22, 2025
src/Umbraco.Cms.Api.Management/Controllers/Tree/FileSystemTreeControllerBase.cs
Show resolved
Hide resolved
lauraneto
approved these changes
Oct 22, 2025
AndyButland
deleted the
v16/bugfix/resolve-backward-compatibility-for-file-system-controllers
branch
This was referenced Oct 27, 2025
AndyButland
added a commit
that referenced
this pull request
Oct 27, 2025
…sses to create null payloads (#20660) * Trees: Restore backward compatibility for file system based tree controllers (closes #20602) (#20608) * Restore backward compatibility for file system based tree controllers. * Aligned obsoletion messages. * Reverts nullability update on ConvertNotificationToRequestPayload.
This was referenced Oct 27, 2025
This was referenced Nov 3, 2025
alexsee
pushed a commit
to alexsee/umbraco-container
that referenced
this pull request
Dec 6, 2025
Updated [Umbraco.Cms.Persistence.Sqlite](https://github.com/umbraco/Umbraco-CMS) from 16.2.0 to 16.3.4. <details> <summary>Release notes</summary> _Sourced from [Umbraco.Cms.Persistence.Sqlite's releases](https://github.com/umbraco/Umbraco-CMS/releases)._ ## 16.3.4 ## What's Changed ### 🐛 Bug Fixes * Content picker: Implement a specific sorting method for statuses (closes #20646) by @nielslyngsoe in umbraco/Umbraco-CMS#20609 * Caching: Resolves publish and install issues related to stale cached data retrieval (closes #20539 and #20630) by @AndyButland in umbraco/Umbraco-CMS#20640 **Full Changelog**: umbraco/Umbraco-CMS@release-16.3.3...release-16.3.4 ## 16.3.3 ## What's Changed ### 🐛 Bug Fixes * Migrations: Use reliable GUID to check for existence of data type when creating (closes #20592) by @AndyButland in umbraco/Umbraco-CMS#20604 * Trees: Restore backward compatibility for file system based tree controllers (closes #20602) by @AndyButland in umbraco/Umbraco-CMS#20608 **Full Changelog**: umbraco/Umbraco-CMS@release-16.3.2...release-16.3.3 ## 16.3.2 ## What's Changed ### 🐛 Bug Fixes * Hybrid Cache: Resolve start-up errors with mis-matched types (closes #20537) by @AndyButland in umbraco/Umbraco-CMS#20554 **Full Changelog**: umbraco/Umbraco-CMS@release-16.3.1...release-16.3.2 ## 16.3.1 ## What's Changed ### 🐛 Bug Fixes * Fixed regression caused by incorrect handling of breaking change on block editor base constructor by @BenWhite27 in umbraco/Umbraco-CMS#20532 **Full Changelog**: umbraco/Umbraco-CMS@release-16.3.0...release-16.3.1 ## 16.3.0 ## What's Changed ### 🙌 Notable Changes * Feature: Client Cache for Document Type and Data Type Detail Models by @madsrasmussen in umbraco/Umbraco-CMS#19904 * Feature: Client Cache for Document Item Models by @madsrasmussen in umbraco/Umbraco-CMS#19923 * Feature: Add client runtime cache for all item endpoints by @madsrasmussen in umbraco/Umbraco-CMS#19960 * Tiptap RTE: Unbundled "Rich Text Essentials" - Toggle basics on/off per data type by @leekelleher in umbraco/Umbraco-CMS#20042 ### 🏠 Internal * build(deps-dev): bump vite from v6 to v7 by @iOvergaard in umbraco/Umbraco-CMS#19974 ### 📦 Dependencies * Chore: upgrade typescript to 5.9 + other minors by @nielslyngsoe in umbraco/Umbraco-CMS#19914 * Bump vite-plugin-static-copy from 3.1.1 to 3.1.2 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#19969 * Bump @hey-api/openapi-ts to 0.81.1 by @iOvergaard in umbraco/Umbraco-CMS#19982 * Bump vite from 7.1.3 to 7.1.5 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20114 * Bump vite from 7.1.3 to 7.1.5 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20181 * Dependencies: Update ImageSharp to latest patch releases (16) by @AndyButland in umbraco/Umbraco-CMS#20276 ### 🌈 Accessibility Improvements * Navigating the App Language Selector with the keyboard by @engijlr in umbraco/Umbraco-CMS#19887 * Profile: Corrected misleading button label by @OskarKruger in umbraco/Umbraco-CMS#20161 * Tiptap RTE: Adds accessibility attributes for RTE input by @OskarKruger in umbraco/Umbraco-CMS#20157 * Workspace Actions: set attributes on the right element for label to work by @nielslyngsoe in umbraco/Umbraco-CMS#20178 * Tags Property Editor: Remove tags with keyboard backspace/delete by @engijlr in umbraco/Umbraco-CMS#19892 * Accessibility changes for the top navbar tabs and settings tabs by @Abdjulaziz in umbraco/Umbraco-CMS#20107 * Update label for tree item caret to identify if open or closed by @OskarKruger in umbraco/Umbraco-CMS#20199 * Tiptap RTE: Adds hover and focus border input states by @OskarKruger in umbraco/Umbraco-CMS#20172 * Installer: Improves user accessibility by adding missing <form> elements and setting the right focus by @iOvergaard in umbraco/Umbraco-CMS#20265 * Allow open split view using the keyboard by @engijlr in umbraco/Umbraco-CMS#19927 ### 🚀 New Features * Update dotnet new umbraco-extension template with newer @hey-api/openapi-ts by @warrenbuckley in umbraco/Umbraco-CMS#19825 * Workspace view navigation context by @nielslyngsoe in umbraco/Umbraco-CMS#19255 * Add timestamps to cache entries and server events by @madsrasmussen in umbraco/Umbraco-CMS#19976 * Block workspace view validation badges by @nielslyngsoe in umbraco/Umbraco-CMS#19987 * Section Sidebar Menu Expansion by @madsrasmussen in umbraco/Umbraco-CMS#19810 * Structure manager refactor implementation by @nielslyngsoe in umbraco/Umbraco-CMS#19970 * Moves icon dependencies to 'core' package.json by @iOvergaard in umbraco/Umbraco-CMS#20041 * Tiptap RTE: Migration to auto-enable new capabilities by @leekelleher in umbraco/Umbraco-CMS#20057 * Database creation/migration for UFM Label editor data-types by @leekelleher in umbraco/Umbraco-CMS#20055 * Workspace View Manifest Overrides by @nielslyngsoe in umbraco/Umbraco-CMS#20033 * Property Editors: Add Missing Property Editor fallback by @lauraneto in umbraco/Umbraco-CMS#19997 * Variants: Implements validation hints to the variant selector (closes #19953) by @iOvergaard in umbraco/Umbraco-CMS#20179 * Interaction Memory: Feature for picker modal state retention (#18305) by @madsrasmussen in umbraco/Umbraco-CMS#20159 * View Context: Implement browser title by @nielslyngsoe in umbraco/Umbraco-CMS#20145 * Icons: Add more heading icons by @bjarnef in umbraco/Umbraco-CMS#20242 * Tiptap RTE: Adds heading (h4-h6) toolbar buttons by @bjarnef in umbraco/Umbraco-CMS#20243 * Introduced sign providers for trees and implemented one for documents with schedule pending by @AndyButland in umbraco/Umbraco-CMS#19806 * Feature: Inflight Request Cache for Document Types and Data Types by @madsrasmussen in umbraco/Umbraco-CMS#19956 * Feature: Redirect to the last visited path when navigating between sections by @madsrasmussen in umbraco/Umbraco-CMS#20084 * Introducing signs to variants by @NillasKA in umbraco/Umbraco-CMS#20053 * Add Vietnamese to UI culture by @NguyenThuyLan in umbraco/Umbraco-CMS#20061 ### 🐛 Bug Fixes * Fixed behaviour on database cache rebuild to update only for requested content types by @AndyButland in umbraco/Umbraco-CMS#19905 ... (truncated) ## 16.3.0-rc4 ## What's Changed in 16.3.0-rc4 ### 🚤 Performance * Performance: Added request cache to media type retrieval in media picker validation, resolving performance regression in validate and save by @AndyButland in umbraco/Umbraco-CMS#20405 **Full Changelog**: umbraco/Umbraco-CMS@release-16.3.0-rc3...release-16.3.0-rc4 ## What's Changed in 16.3.0-rc3 ### 🐛 Bug Fixes * Hybrid cache: Check for `ContentCacheNode` instead of object on exists for hybrid cache to ensure correct deserialization (closes #20352) by @AndyButland in umbraco/Umbraco-CMS#20383 **Full Changelog**: umbraco/Umbraco-CMS@release-16.3.0-rc2...release-16.3.0-rc3 ## What's Changed in 16.3.0-rc2 ### 🐛 Bug Fixes * Caching: Fixes regression of the caching of null representations for missing dictionary items (closes #20336) by @AndyButland in umbraco/Umbraco-CMS#20349 **Full Changelog**: umbraco/Umbraco-CMS@release-16.3.0-rc...release-16.3.0-rc2 ## What's Changed Since The Last Release (16.2.0) ### 🙌 Notable Changes - Testing encouraged and appreciated! * Feature: Client Cache for Document Type and Data Type Detail Models by @madsrasmussen in umbraco/Umbraco-CMS#19904 * Feature: Client Cache for Document Item Models by @madsrasmussen in umbraco/Umbraco-CMS#19923 * Feature: Add client runtime cache for all item endpoints by @madsrasmussen in umbraco/Umbraco-CMS#19960 * Tiptap RTE: Unbundled "Rich Text Essentials" - Toggle basics on/off per data type by @leekelleher in umbraco/Umbraco-CMS#20042 ### 🏠 Internal * build(deps-dev): bump vite from v6 to v7 by @iOvergaard in umbraco/Umbraco-CMS#19974 ### 📦 Dependencies * Chore: upgrade typescript to 5.9 + other minors by @nielslyngsoe in umbraco/Umbraco-CMS#19914 * Bump vite-plugin-static-copy from 3.1.1 to 3.1.2 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#19969 * Bump @hey-api/openapi-ts to 0.81.1 by @iOvergaard in umbraco/Umbraco-CMS#19982 * Bump vite from 7.1.3 to 7.1.5 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20114 * Bump vite from 7.1.3 to 7.1.5 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20181 * Dependencies: Update ImageSharp to latest patch releases (16) by @AndyButland in umbraco/Umbraco-CMS#20276 ### 🌈 Accessibility Improvements * Navigating the App Language Selector with the keyboard by @engijlr in umbraco/Umbraco-CMS#19887 * Profile: Corrected misleading button label by @OskarKruger in umbraco/Umbraco-CMS#20161 * Tiptap RTE: Adds accessibility attributes for RTE input by @OskarKruger in umbraco/Umbraco-CMS#20157 * Workspace Actions: set attributes on the right element for label to work by @nielslyngsoe in umbraco/Umbraco-CMS#20178 * Tags Property Editor: Remove tags with keyboard backspace/delete by @engijlr in umbraco/Umbraco-CMS#19892 * Accessibility changes for the top navbar tabs and settings tabs by @Abdjulaziz in umbraco/Umbraco-CMS#20107 * Update label for tree item caret to identify if open or closed by @OskarKruger in umbraco/Umbraco-CMS#20199 * Tiptap RTE: Adds hover and focus border input states by @OskarKruger in umbraco/Umbraco-CMS#20172 * Installer: Improves user accessibility by adding missing <form> elements and setting the right focus by @iOvergaard in umbraco/Umbraco-CMS#20265 ... (truncated) ## 16.3.0-rc3 ## What's Changed in 16.3.0-rc3 ### 🐛 Bug Fixes * Hybrid cache: Check for `ContentCacheNode` instead of object on exists for hybrid cache to ensure correct deserialization (closes #20352) by @AndyButland in umbraco/Umbraco-CMS#20383 **Full Changelog**: umbraco/Umbraco-CMS@release-16.3.0-rc2...release-16.3.0-rc3 ## What's Changed in 16.3.0-rc2 ### 🐛 Bug Fixes * Caching: Fixes regression of the caching of null representations for missing dictionary items (closes #20336) by @AndyButland in umbraco/Umbraco-CMS#20349 **Full Changelog**: umbraco/Umbraco-CMS@release-16.3.0-rc...release-16.3.0-rc2 ## What's Changed Since The Last Release (16.2.0) ### 🙌 Notable Changes - Testing encouraged and appreciated! * Feature: Client Cache for Document Type and Data Type Detail Models by @madsrasmussen in umbraco/Umbraco-CMS#19904 * Feature: Client Cache for Document Item Models by @madsrasmussen in umbraco/Umbraco-CMS#19923 * Feature: Add client runtime cache for all item endpoints by @madsrasmussen in umbraco/Umbraco-CMS#19960 * Tiptap RTE: Unbundled "Rich Text Essentials" - Toggle basics on/off per data type by @leekelleher in umbraco/Umbraco-CMS#20042 ### 🏠 Internal * build(deps-dev): bump vite from v6 to v7 by @iOvergaard in umbraco/Umbraco-CMS#19974 ### 📦 Dependencies * Chore: upgrade typescript to 5.9 + other minors by @nielslyngsoe in umbraco/Umbraco-CMS#19914 * Bump vite-plugin-static-copy from 3.1.1 to 3.1.2 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#19969 * Bump @hey-api/openapi-ts to 0.81.1 by @iOvergaard in umbraco/Umbraco-CMS#19982 * Bump vite from 7.1.3 to 7.1.5 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20114 * Bump vite from 7.1.3 to 7.1.5 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20181 * Dependencies: Update ImageSharp to latest patch releases (16) by @AndyButland in umbraco/Umbraco-CMS#20276 ### 🌈 Accessibility Improvements * Navigating the App Language Selector with the keyboard by @engijlr in umbraco/Umbraco-CMS#19887 * Profile: Corrected misleading button label by @OskarKruger in umbraco/Umbraco-CMS#20161 * Tiptap RTE: Adds accessibility attributes for RTE input by @OskarKruger in umbraco/Umbraco-CMS#20157 * Workspace Actions: set attributes on the right element for label to work by @nielslyngsoe in umbraco/Umbraco-CMS#20178 * Tags Property Editor: Remove tags with keyboard backspace/delete by @engijlr in umbraco/Umbraco-CMS#19892 * Accessibility changes for the top navbar tabs and settings tabs by @Abdjulaziz in umbraco/Umbraco-CMS#20107 * Update label for tree item caret to identify if open or closed by @OskarKruger in umbraco/Umbraco-CMS#20199 * Tiptap RTE: Adds hover and focus border input states by @OskarKruger in umbraco/Umbraco-CMS#20172 * Installer: Improves user accessibility by adding missing <form> elements and setting the right focus by @iOvergaard in umbraco/Umbraco-CMS#20265 * Allow open split view using the keyboard by @engijlr in umbraco/Umbraco-CMS#19927 ### 🚀 New Features * Update dotnet new umbraco-extension template with newer @hey-api/openapi-ts by @warrenbuckley in umbraco/Umbraco-CMS#19825 * Workspace view navigation context by @nielslyngsoe in umbraco/Umbraco-CMS#19255 * Add timestamps to cache entries and server events by @madsrasmussen in umbraco/Umbraco-CMS#19976 * Block workspace view validation badges by @nielslyngsoe in umbraco/Umbraco-CMS#19987 * Section Sidebar Menu Expansion by @madsrasmussen in umbraco/Umbraco-CMS#19810 * Structure manager refactor implementation by @nielslyngsoe in umbraco/Umbraco-CMS#19970 ... (truncated) ## 16.3.0-rc2 ## What's Changed in 16.3.0-rc2 ### 🐛 Bug Fixes * Caching: Fixes regression of the caching of null representations for missing dictionary items (closes #20336) by @AndyButland in umbraco/Umbraco-CMS#20349 **Full Changelog**: umbraco/Umbraco-CMS@release-16.3.0-rc...release-16.3.0-rc2 ## What's Changed Since The Last Release (16.2.0) ### 🙌 Notable Changes - Testing encouraged and appreciated! * Feature: Client Cache for Document Type and Data Type Detail Models by @madsrasmussen in umbraco/Umbraco-CMS#19904 * Feature: Client Cache for Document Item Models by @madsrasmussen in umbraco/Umbraco-CMS#19923 * Feature: Add client runtime cache for all item endpoints by @madsrasmussen in umbraco/Umbraco-CMS#19960 * Tiptap RTE: Unbundled "Rich Text Essentials" - Toggle basics on/off per data type by @leekelleher in umbraco/Umbraco-CMS#20042 ### 🏠 Internal * build(deps-dev): bump vite from v6 to v7 by @iOvergaard in umbraco/Umbraco-CMS#19974 ### 📦 Dependencies * Chore: upgrade typescript to 5.9 + other minors by @nielslyngsoe in umbraco/Umbraco-CMS#19914 * Bump vite-plugin-static-copy from 3.1.1 to 3.1.2 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#19969 * Bump @hey-api/openapi-ts to 0.81.1 by @iOvergaard in umbraco/Umbraco-CMS#19982 * Bump vite from 7.1.3 to 7.1.5 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20114 * Bump vite from 7.1.3 to 7.1.5 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20181 * Dependencies: Update ImageSharp to latest patch releases (16) by @AndyButland in umbraco/Umbraco-CMS#20276 ### 🌈 Accessibility Improvements * Navigating the App Language Selector with the keyboard by @engijlr in umbraco/Umbraco-CMS#19887 * Profile: Corrected misleading button label by @OskarKruger in umbraco/Umbraco-CMS#20161 * Tiptap RTE: Adds accessibility attributes for RTE input by @OskarKruger in umbraco/Umbraco-CMS#20157 * Workspace Actions: set attributes on the right element for label to work by @nielslyngsoe in umbraco/Umbraco-CMS#20178 * Tags Property Editor: Remove tags with keyboard backspace/delete by @engijlr in umbraco/Umbraco-CMS#19892 * Accessibility changes for the top navbar tabs and settings tabs by @Abdjulaziz in umbraco/Umbraco-CMS#20107 * Update label for tree item caret to identify if open or closed by @OskarKruger in umbraco/Umbraco-CMS#20199 * Tiptap RTE: Adds hover and focus border input states by @OskarKruger in umbraco/Umbraco-CMS#20172 * Installer: Improves user accessibility by adding missing <form> elements and setting the right focus by @iOvergaard in umbraco/Umbraco-CMS#20265 * Allow open split view using the keyboard by @engijlr in umbraco/Umbraco-CMS#19927 ### 🚀 New Features * Update dotnet new umbraco-extension template with newer @hey-api/openapi-ts by @warrenbuckley in umbraco/Umbraco-CMS#19825 * Workspace view navigation context by @nielslyngsoe in umbraco/Umbraco-CMS#19255 * Add timestamps to cache entries and server events by @madsrasmussen in umbraco/Umbraco-CMS#19976 * Block workspace view validation badges by @nielslyngsoe in umbraco/Umbraco-CMS#19987 * Section Sidebar Menu Expansion by @madsrasmussen in umbraco/Umbraco-CMS#19810 * Structure manager refactor implementation by @nielslyngsoe in umbraco/Umbraco-CMS#19970 * Moves icon dependencies to 'core' package.json by @iOvergaard in umbraco/Umbraco-CMS#20041 * Tiptap RTE: Migration to auto-enable new capabilities by @leekelleher in umbraco/Umbraco-CMS#20057 * Database creation/migration for UFM Label editor data-types by @leekelleher in umbraco/Umbraco-CMS#20055 * Workspace View Manifest Overrides by @nielslyngsoe in umbraco/Umbraco-CMS#20033 * Property Editors: Add Missing Property Editor fallback by @lauraneto in umbraco/Umbraco-CMS#19997 * Variants: Implements validation hints to the variant selector (closes #19953) by @iOvergaard in umbraco/Umbraco-CMS#20179 * Interaction Memory: Feature for picker modal state retention (#18305) by @madsrasmussen in umbraco/Umbraco-CMS#20159 * View Context: Implement browser title by @nielslyngsoe in umbraco/Umbraco-CMS#20145 ... (truncated) ## 16.3.0-rc <!-- Release notes generated using configuration in .github/release.yml at release-16.3.0-rc --> ## What's Changed ### 🙌 Notable Changes - Testing encouraged and appreciated! * Feature: Client Cache for Document Type and Data Type Detail Models by @madsrasmussen in umbraco/Umbraco-CMS#19904 * Feature: Client Cache for Document Item Models by @madsrasmussen in umbraco/Umbraco-CMS#19923 * Feature: Add client runtime cache for all item endpoints by @madsrasmussen in umbraco/Umbraco-CMS#19960 * Tiptap RTE: Unbundled "Rich Text Essentials" - Toggle basics on/off per data type by @leekelleher in umbraco/Umbraco-CMS#20042 ### 🏠 Internal * build(deps-dev): bump vite from v6 to v7 by @iOvergaard in umbraco/Umbraco-CMS#19974 ### 📦 Dependencies * Chore: upgrade typescript to 5.9 + other minors by @nielslyngsoe in umbraco/Umbraco-CMS#19914 * Bump vite-plugin-static-copy from 3.1.1 to 3.1.2 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#19969 * Bump @hey-api/openapi-ts to 0.81.1 by @iOvergaard in umbraco/Umbraco-CMS#19982 * Bump vite from 7.1.3 to 7.1.5 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20114 * Bump vite from 7.1.3 to 7.1.5 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20181 * Dependencies: Update ImageSharp to latest patch releases (16) by @AndyButland in umbraco/Umbraco-CMS#20276 ### 🌈 Accessibility Improvements * Navigating the App Language Selector with the keyboard by @engijlr in umbraco/Umbraco-CMS#19887 * Profile: Corrected misleading button label by @OskarKruger in umbraco/Umbraco-CMS#20161 * Tiptap RTE: Adds accessibility attributes for RTE input by @OskarKruger in umbraco/Umbraco-CMS#20157 * Workspace Actions: set attributes on the right element for label to work by @nielslyngsoe in umbraco/Umbraco-CMS#20178 * Tags Property Editor: Remove tags with keyboard backspace/delete by @engijlr in umbraco/Umbraco-CMS#19892 * Accessibility changes for the top navbar tabs and settings tabs by @Abdjulaziz in umbraco/Umbraco-CMS#20107 * Update label for tree item caret to identify if open or closed by @OskarKruger in umbraco/Umbraco-CMS#20199 * Tiptap RTE: Adds hover and focus border input states by @OskarKruger in umbraco/Umbraco-CMS#20172 * Installer: Improves user accessibility by adding missing <form> elements and setting the right focus by @iOvergaard in umbraco/Umbraco-CMS#20265 * Allow open split view using the keyboard by @engijlr in umbraco/Umbraco-CMS#19927 ### 🚀 New Features * Update dotnet new umbraco-extension template with newer @hey-api/openapi-ts by @warrenbuckley in umbraco/Umbraco-CMS#19825 * Workspace view navigation context by @nielslyngsoe in umbraco/Umbraco-CMS#19255 * Add timestamps to cache entries and server events by @madsrasmussen in umbraco/Umbraco-CMS#19976 * Block workspace view validation badges by @nielslyngsoe in umbraco/Umbraco-CMS#19987 * Section Sidebar Menu Expansion by @madsrasmussen in umbraco/Umbraco-CMS#19810 * Structure manager refactor implementation by @nielslyngsoe in umbraco/Umbraco-CMS#19970 * Moves icon dependencies to 'core' package.json by @iOvergaard in umbraco/Umbraco-CMS#20041 * Tiptap RTE: Migration to auto-enable new capabilities by @leekelleher in umbraco/Umbraco-CMS#20057 * Database creation/migration for UFM Label editor data-types by @leekelleher in umbraco/Umbraco-CMS#20055 * Workspace View Manifest Overrides by @nielslyngsoe in umbraco/Umbraco-CMS#20033 * Property Editors: Add Missing Property Editor fallback by @lauraneto in umbraco/Umbraco-CMS#19997 * Variants: Implements validation hints to the variant selector (closes #19953) by @iOvergaard in umbraco/Umbraco-CMS#20179 * Interaction Memory: Feature for picker modal state retention (#18305) by @madsrasmussen in umbraco/Umbraco-CMS#20159 * View Context: Implement browser title by @nielslyngsoe in umbraco/Umbraco-CMS#20145 * Icons: Add more heading icons by @bjarnef in umbraco/Umbraco-CMS#20242 * Tiptap RTE: Adds heading (h4-h6) toolbar buttons by @bjarnef in umbraco/Umbraco-CMS#20243 * Introduced sign providers for trees and implemented one for documents with schedule pending by @AndyButland in umbraco/Umbraco-CMS#19806 * Feature: Inflight Request Cache for Document Types and Data Types by @madsrasmussen in umbraco/Umbraco-CMS#19956 * Feature: Redirect to the last visited path when navigating between sections by @madsrasmussen in umbraco/Umbraco-CMS#20084 * Introducing signs to variants by @NillasKA in umbraco/Umbraco-CMS#20053 * Add Vietnamese to UI culture by @NguyenThuyLan in umbraco/Umbraco-CMS#20061 ... (truncated) Commits viewable in [compare view](umbraco/Umbraco-CMS@release-16.2.0...release-16.3.4). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Addresses: #20602 and umbraco/Umbraco.Forms.Issues#1472
Description
This PR corrects and cleans up the constructor hierarchy for file system based tree controllers and fixes the backward compatibility regression discussed in the linked issues.
Testing
Firstly verify that the scripts, partial views and stylesheets trees work as before.
Then to check backward compatibility, modify some controllers - e.g.
RootScriptTreeControllerandChildrenScriptTreeControllerto keep only the constructor with this signatures:FileSystems fileSystems. Verify that the scripts tree works as before.@mattbrailsford / @rickbutterfield - ideally if you could take the build from this PR and verify that it resolves the issue for Forms please, that would be a good check too.