Moves icon dependencies to 'core' package.json

[iOvergaard]

This pull request updates icon generation and registry logic, modernizes dependencies, and improves code clarity and maintainability. The main changes include upgrading icon-related packages, updating generated icons to include titles for accessibility, and refactoring parts of the icon generation script for better readability and error handling.

Dependency upgrades and maintenance:

• Upgraded lucide-static, simple-icons, and svgo to their latest versions in both package.json and package-lock.json, ensuring access to new icons and improved SVG optimization.

Script refactoring and code quality:

• Refactored the icon generation script (src/Umbraco.Web.UI.Client/devops/icons/index.js) to improve readability and maintainability: switched some variable declarations from var to let, reordered imports, and clarified regex usage in string replacements. [1] [2] [3]
• Simplified error handling in the icon collection process by removing unused error variables in the catch blocks. [1] [2] [3]
• Removed unnecessary ESLint disable comments from the script, making the code cleaner and easier to maintain. [1] [2]

[Copilot]

Pull Request Overview

This PR consolidates icon-related dependencies by moving them from the main UI client package to the core package, specifically moving lucide-static, simple-icons, and svgo to the core package's devDependencies. Additionally, it updates various icon files with improved SVG content and adds title elements for better accessibility.

• Moves icon build dependencies to the core package where icons are actually generated
• Updates icon SVG content with improved paths and accessibility features
• Cleans up build script code style and error handling

Reviewed Changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 2 comments.

File	Description
src/Umbraco.Web.UI.Client/src/packages/core/package.json	Adds icon-related devDependencies (lucide-static, simple-icons, svgo)
src/Umbraco.Web.UI.Client/package.json	Removes icon dependencies that were moved to core package
src/Umbraco.Web.UI.Client/devops/icons/index.js	Improves code style, error handling, and removes unused eslint disables
Multiple icon files (umbrella, twitter, twitter-x, pictures, microsoft, mastodon, google, gitlab, github, gitbook, facebook, azure)	Updates SVG content with improved paths and adds title elements for accessibility

Files not reviewed (1)

• src/Umbraco.Web.UI.Client/package-lock.json: Language not supported