Merged
Conversation
This feature is not ready yet.
Unrelated to Tiptap, but causes data-types to throw an error. Bug introduced in PR #20033
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR tidies up various aspects of the Tiptap Rich Text Editor implementation following a previous PR, addressing missing mock data, styling issues, and adding proper deprecation notices.
- Adds missing mock data for Tiptap extensions to improve test coverage
- Fixes UFM code element styling with proper font-family fallback
- Improves button alignment in Tiptap configuration interfaces
- Adds proper deprecation notices for v17 removal
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ufm-render.element.ts | Adds fallback value for monospace font-family CSS variable |
| types.ts | Updates deprecation notice from TODO comment to proper JSDoc |
| tiptap-toolbar-group-configuration.element.ts | Adds flex-end alignment for configuration buttons |
| property-editor-ui-tiptap-toolbar-configuration.element.ts | Adds flex-end alignment for toolbar configuration buttons |
| property-editor-ui-tiptap-statusbar-configuration.element.ts | Adds flex-end alignment for statusbar configuration buttons |
| font-size/manifests.ts | Removes unused menu manifest and simplifies export structure |
| font-family/manifests.ts | Removes unused menu manifest and simplifies export structure |
| content-collection-workspace.context-token.ts | Adds optional chaining to prevent runtime errors |
| document.data.ts | Updates mock data to use span instead of div for embed holder |
| data-type.data.ts | Adds comprehensive list of Tiptap extensions to mock data |
| index.ts | Corrects deprecation notice version from v18 to v17 |
iOvergaard
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up with PR #20042, I'd found a few things to tidy-up.
<code>was missing a variable fallback formonospace