Tiptap: Relocation of external extensions/package#20256
Merged
iOvergaard merged 16 commits intov17/devfrom Sep 25, 2025
Merged
Conversation
relocated Tiptap exports to the "@umbraco-cms/backoffice/tiptap" package.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR relocates the Tiptap "external" extensions source code from the "external/tiptap" module into the main "tiptap" package as part of the v17 breaking changes. The refactor consolidates all Tiptap-related functionality under a single namespace while removing the deprecated external module structure.
Key changes:
- Removes the
@umbraco-cms/backoffice/external/tiptapimport namespace - Consolidates all Tiptap extensions and dependencies into the main
@umbraco-cms/backoffice/tiptappackage - Updates import statements across all files to use the new internal module structure
Reviewed Changes
Copilot reviewed 129 out of 130 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/tsconfig.json | Removes external/tiptap path mapping from TypeScript configuration |
| src/Umbraco.Web.UI.Client/src/packages/tiptap/package.json | Adds all Tiptap dependencies previously defined in external module |
| src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts | New file exporting all Tiptap core extensions for internal use |
| Multiple extension files | Updates imports from external/tiptap to use relative paths to externals.js |
| Multiple custom extension files | Removes deprecated comments and updates interface/export names |
| src/Umbraco.Web.UI.Client/src/external/tiptap/ | Removes entire external tiptap module directory |
| src/Umbraco.Web.UI.Client/package.json | Removes external/tiptap export mapping |
Files not reviewed (1)
- src/Umbraco.Web.UI.Client/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)
src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/table.tiptap-extension.ts:1
- Remove large blocks of commented-out code. If this functionality might be needed in the future, consider creating a TODO comment or filing an issue instead of keeping dead code.
/* eslint-disable @typescript-eslint/consistent-type-imports */
src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/table.tiptap-extension.ts:1
- Remove large blocks of commented-out code. If this functionality might be needed in the future, consider creating a TODO comment or filing an issue instead of keeping dead code.
/* eslint-disable @typescript-eslint/consistent-type-imports */
src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/table.tiptap-extension.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/table.tiptap-extension.ts
Outdated
Show resolved
Hide resolved
...aco.Web.UI.Client/src/packages/tiptap/extensions/bubble-menu/bubble-menu.tiptap-extension.ts
Show resolved
Hide resolved
iOvergaard
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the Tiptap capabilities refactor in PR #20078 (for v16.3), we wanted to bring the "external" extensions source-code into the main "tiptap" package, however this is a breaking-change, so has been saved for v17.
In practical terms, the import namespace
"@umbraco-cms/backoffice/external/tiptap"has been removed, replaced with"@umbraco-cms/backoffice/tiptap".Meaning that any 3rd-party extension code would need to be updated from...
to...
It is worth noting that we no longer export the Tiptap
StarterKit(@tiptap/starter-kit) library, as it has been removed since it is no longer used internally in the CMS backoffice.How to test this?
In terms of testing the core CMS, it's mainly to check that the Tiptap RTE still functions as expected, with no JS errors or warnings.